Moodle

problems saving wiki pages

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 1.8
  • Fix Version/s: None
  • Component/s: Wiki (1.x)
  • Labels:
    None
  • Environment:
    linux/mysql
  • Database:
    MySQL
  • Affected Branches:
    MOODLE_18_STABLE

Description

when I edit an existing wiki page and save it, all seems well. Changes are visible on screen. When I re-edit the page, all seems normal , although sometimes things start to wrong from here : what is visble is the old page, not the new one. Sometimes things go wrong from the next point : Moodle refuses to save the second edit, claiming that 'someone has already saved a change'. That someone is me, of course, in the same explorer session, no less. From here on, what you get with view and edit is the oldest page version. the second one seems gone.

Digging in the database, you can see both oldest versions there. Why Moodle insists on picking the older one is not clear, though when you look at the structure of the mdle_wiki_locks table, phpadmin complains about the structure of the indexes.
The issue cannot be resolved by exiting explorer; you can no longer save edits for that page. Ever. I had no other option but to delete the oldest mdl_wiki_pages records, close the explorer and return to the site in a new explorer session.

Issue Links

This issue is a clone of:
MDL-10327 CLONE -problems saving wiki pages Major Closed
This issue has been marked as being related by:
MDL-8494 New wiki locking in 1.7 / 1.8 is too strict ... stops students editing their own page in the individual or group modes because they have the same name Blocker Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Hagar Qim added a comment -

ah, forgot to tell : the servers runs php 5.
Also, I suspect it might be connected to the fact that I update the wiki from 2 different machines. So far I had no problem on the machine where I originally created the pages; problems seem restricted to the other machine (although they do not always occur. Nice).

Show
Hagar Qim added a comment - ah, forgot to tell : the servers runs php 5. Also, I suspect it might be connected to the fact that I update the wiki from 2 different machines. So far I had no problem on the machine where I originally created the pages; problems seem restricted to the other machine (although they do not always occur. Nice).
Hide
Permalink
onitzuka added a comment -

I am having this same problem on a brand new fresh install of 1.8.3+.

I have been unable to save the text.... and further there is no way to be sure of what text anyone will see when they visit the site as the wiki appears to randomly pick if it will show the old text or the new text. But one thing for sure, it is biased towards showing the older text.

I cannot edit the pages.

I cannot make any more progress with the wiki.

Show
onitzuka added a comment - I am having this same problem on a brand new fresh install of 1.8.3+. I have been unable to save the text.... and further there is no way to be sure of what text anyone will see when they visit the site as the wiki appears to randomly pick if it will show the old text or the new text. But one thing for sure, it is biased towards showing the older text. I cannot edit the pages. I cannot make any more progress with the wiki.
Hide
Permalink
Jordi Piguillem Poch added a comment -

Are you running Moodle default wiki or NWiki?

Show
Jordi Piguillem Poch added a comment - Are you running Moodle default wiki or NWiki?
Hide
Permalink
Hagar Qim added a comment -

default wiki

Show
Hagar Qim added a comment - default wiki
Hide
Permalink
Sue Harper added a comment -

We are running 1.8.1 and are having this same issue. Can create an initial wiki entry, and when you go to edit and then save, it goes back to the original and does not show the new edit.

Is there any update on this issue?

Show
Sue Harper added a comment - We are running 1.8.1 and are having this same issue. Can create an initial wiki entry, and when you go to edit and then save, it goes back to the original and does not show the new edit. Is there any update on this issue?
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Assigning this to Sam...

Sam... plz, reasign this to me if I'm wrong... but I remember vaguely this (locking) was introduced by you. Any insight ?

Show
Eloy Lafuente (stronk7) added a comment - Assigning this to Sam... Sam... plz, reasign this to me if I'm wrong... but I remember vaguely this (locking) was introduced by you. Any insight ?
Hide
Permalink
Sam Marshall added a comment -

I don't think this is mine. I think even before the lock table, there was an existing message that causes an error if you update a page which somebody else had already saved in the meantime.

The locks table may prevent you from editing a page (giving you a somebody-else-is-editing-it message instead) but it doesn't have any effect once you actually get in to edit. As far as I can tell from the code, the only message that a lock failure can generate when you try to save the page is $string['savenolock'].

The user who reported the error message didn't give the exact copy/paste of the error, only some approximation of the words, which wasn't very helpful. (Well, maybe they were using another language.) However I'm pretty sure they meant $string['errversionsave']:

'Sorry, while you edited this page someone else did already save a changed version. Please go back to the previous screen and copy your changes to your computers clipboard to insert it again after you reload the edit screen.'

(The mdl_wiki_locks table is mine, but if the 'structure of the index' is somehow broken, as one comment mentioned, then that sounds like a bug for MySQL not moodle's problem at all?!)

Show
Sam Marshall added a comment - I don't think this is mine. I think even before the lock table, there was an existing message that causes an error if you update a page which somebody else had already saved in the meantime. The locks table may prevent you from editing a page (giving you a somebody-else-is-editing-it message instead) but it doesn't have any effect once you actually get in to edit. As far as I can tell from the code, the only message that a lock failure can generate when you try to save the page is $string['savenolock']. The user who reported the error message didn't give the exact copy/paste of the error, only some approximation of the words, which wasn't very helpful. (Well, maybe they were using another language.) However I'm pretty sure they meant $string['errversionsave']: 'Sorry, while you edited this page someone else did already save a changed version. Please go back to the previous screen and copy your changes to your computers clipboard to insert it again after you reload the edit screen.' (The mdl_wiki_locks table is mine, but if the 'structure of the index' is somehow broken, as one comment mentioned, then that sounds like a bug for MySQL not moodle's problem at all?!)
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Hi Sam, thanks for the feedback... was trying to eliminate possibilities. I'll perform some tests here.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Hi Sam, thanks for the feedback... was trying to eliminate possibilities. I'll perform some tests here. Ciao
Hide
Permalink
Kenneth Newquist added a comment -

I'm seeing similar behavior in a course wiki under Moodle 1.9.x. I'm not getting any on-screen errors, but the home page of the wiki is not being updated with the latest version; instead it is stuck two versions earlier. If I edit the home page, it pulls up the most current revision for editing. When I save the wiki page, it takes me to the page for that revision, which displays my text correctly. However, when I return to the wiki home page, it still shows the older text.

I am able to recreate this bug within the problem wiki, but I have not been able to recreate it in any other course's wiki.

The wiki is using groups.

Show
Kenneth Newquist added a comment - I'm seeing similar behavior in a course wiki under Moodle 1.9.x. I'm not getting any on-screen errors, but the home page of the wiki is not being updated with the latest version; instead it is stuck two versions earlier. If I edit the home page, it pulls up the most current revision for editing. When I save the wiki page, it takes me to the page for that revision, which displays my text correctly. However, when I return to the wiki home page, it still shows the older text. I am able to recreate this bug within the problem wiki, but I have not been able to recreate it in any other course's wiki. The wiki is using groups.
Hide
Permalink
Kenneth Newquist added a comment -

I believe there may be two separate issues here; one involving the locking behavior, and another with the wiki truncating any page with a pound (#) sign in it, as reported in this tracker:

http://tracker.moodle.org/browse/MDL-17237

Show
Kenneth Newquist added a comment - I believe there may be two separate issues here; one involving the locking behavior, and another with the wiki truncating any page with a pound (#) sign in it, as reported in this tracker: http://tracker.moodle.org/browse/MDL-17237
Hide
Permalink
Michael de Raadt added a comment -

Thanks for reporting this issue.

We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

Michael d;

lqjjLKA0p6

Show
Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
Hide
Permalink
Michael de Raadt added a comment -

I'm closing this issue as it has become inactive and does not appear to affect a current supported version. If you are encountering this problem or one similar, please launch a new issue.

Show
Michael de Raadt added a comment - I'm closing this issue as it has become inactive and does not appear to affect a current supported version. If you are encountering this problem or one similar, please launch a new issue.

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.