Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.5.4, 1.6, 1.6.1, 1.6.2, 1.6.3, 1.6.4, 1.6.5, 1.7, 1.7.1, 1.7.2
-
Component/s: Calendar
-
Labels:None
-
Environment:Probably irrelevant, but RHEL4 w/ apache2, php 5.2.0 and a remote MSSQL 2005 database
-
Affected Branches:MOODLE_15_STABLE, MOODLE_16_STABLE, MOODLE_17_STABLE
-
Fixed Branches:MOODLE_18_STABLE, MOODLE_19_STABLE
Description
If you go to the detailed view of a calendar from a course, it will include the course id in the url (e.g. calendar/view.php?view=month&course=13&cal_d=1&cal_m=06&cal_y=2007). However, all of the links in the calendar do not have the course parameter so you'll get something like calendar/view.php?view=month&cal_d=1&cal_m=06&cal_y=2007. Oddly enough, it still stores which course you came from because that shows up in the breadcrumb, but it must be in a cookie or something.
This is bad on a number of accounts.
1. If the user bookmarks what they think is their calendar in one course, they come back later and it's another course because the cookie got changed.
2. For admin users who are viewing calendars for courses their not enrolled in, this is a big problem. Only the URLs with the course parameter will display the course's events. So as soon as they try to navigate anywhere in the calendar, they can't see anything anymore.
Attachments
Issue Links
| This issue is duplicated by: | ||||
| MDL-10319 | Can't create new course event |
|
|
|
| MDL-11133 | Course selection drop down does not work |
|
|
|
| MDL-10839 | Calendar unexpectedly shows events from other courses when switching months in editing view |
|
|
|
| MDL-11208 | Calendar always shows All Courses view even after selecting a single Course |
|
|
|
| This issue has a non-specific relationship to: | ||||
| MDL-9772 | Calendar events disappear twice a month, sometimes more often |
|
|
|
| MDL-9059 | When teacher creates Group event on calendar, they cannot see it |
|
|
|
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
I can't manage to get group events correctly, neither in 1.8.2 (fresh from CVS) or in 1.9beta+ (fresh from CVS too). Can someone confirm that the bug is still present in this case.
All other issues seems to be gone. Thank you Yu 
Hi Yu, there are still some glitches (in 1.8):
1. under calendar/view.php at around line #136
$prefsbutton = calendar_preferences_button();
The calendar_preferences_button() does not pass over the course id info
2. under calendar/view.php at around line #165 (//Link to calendar export page), this line should also pass the course id
print_single_button('export.php', false, get_string('exportcalendar', 'calendar'));
By the way, I talked to Yu and I volunteered to backport all these fixes to 1.5 (currently only tested on 1.5), so far it works although I still need some more testing. I will try to clean them up a little bit and post the backported version (for 1.5, and possibly for 1.6, 1.7 too) here so that people could help testing them. Thanks! 
Yu, I think you fixed the export one. Good job!
However, I still can easily reproduce the preferences bug. Here are steps to reproduce:
Login as admin
1. Create two courses and assign them to one teacher, create whole bunch of events for both courses (very important)
2. Login as that teacher, get into one of the two courses, and click on Calendar, say October 2007 (see screenshot BEFORE_clicking_preferences.png)
3. Click on the "Preferences" button on the upper-right corner
4. Notice now that course ID was not passed over and the preferences.php shows ? at the end (although the session should have passed over), now do NOT click on "Save changes", click on the "Calendar" on the breadcrumb (navigation) bar, now suddenly you will be able to see BOTH course events, and the "Upcoming Events" pull-down menu is now reset to "All courses" (see screenshot AFTER_clicking_preferences_then_Calendar_breadcrumb.png)
It's not a major issue, but it could get teachers confused if they don't know they should use the "Upcoming Events" pull down menu and set it back to one course only. I have identified where need to be fixed. In preferences.php line#61, the $navigation should probably be handled similar to how $nav is handled in both view.php (line#70) or export.php (line#25), what do you think? This should be able to fix this issue. Hope this helps.
However, I still can easily reproduce the preferences bug. Here are steps to reproduce:
Login as admin
1. Create two courses and assign them to one teacher, create whole bunch of events for both courses (very important)
2. Login as that teacher, get into one of the two courses, and click on Calendar, say October 2007 (see screenshot BEFORE_clicking_preferences.png)
3. Click on the "Preferences" button on the upper-right corner
4. Notice now that course ID was not passed over and the preferences.php shows ? at the end (although the session should have passed over), now do NOT click on "Save changes", click on the "Calendar" on the breadcrumb (navigation) bar, now suddenly you will be able to see BOTH course events, and the "Upcoming Events" pull-down menu is now reset to "All courses" (see screenshot AFTER_clicking_preferences_then_Calendar_breadcrumb.png)
It's not a major issue, but it could get teachers confused if they don't know they should use the "Upcoming Events" pull down menu and set it back to one course only. I have identified where need to be fixed. In preferences.php line#61, the $navigation should probably be handled similar to how $nav is handled in both view.php (line#70) or export.php (line#25), what do you think? This should be able to fix this issue. Hope this helps. Hi Teresa, the fix for 1.8.2 is already committed into MOODLE_18_STABLE. You just need to upgrade your 1.8.2 installation to the latest 1.8.x codes (through moodle cvs or download.moodle.org) and you will be able to get this fix. If you want to manually fix it you could also click on the "Version Control" tab in this ticket to see how to patch your current code. Hope this helps.
Hello all,
Thank you for your effective efforts!
I've recently installed Moodle 2.1 for our university, and I'm facing the same problem with the calendar. The course selection drop down is not working:
If I open the calendar while I'm inside a course, the drop down list shows the course I'm on. If I then try to select another option it does nothing. The drop down list remains on the course I'm on, and the query string in the URL shows ?course=[the id of the course I'm on]. So I'm assuming the selection does not succeed in sending the new query string.
Can anyone help out with this issue?
Thanks in advance! =)
I've recently installed Moodle 2.1 for our university, and I'm facing the same problem with the calendar. The course selection drop down is not working:
If I open the calendar while I'm inside a course, the drop down list shows the course I'm on. If I then try to select another option it does nothing. The drop down list remains on the course I'm on, and the query string in the URL shows ?course=[the id of the course I'm on]. So I'm assuming the selection does not succeed in sending the new query string.
Can anyone help out with this issue?
Thanks in advance! =) 
See thread http://moodle.org/mod/forum/discuss.php?d=75161
Affects 1.8.2 as well