http://moodle.org/mod/forum/discuss.php?d=75161

Affects 1.8.2 as well

It appears that the &course=XY parameter is not being carried across on any links or in the javascript in the drop-down box for choosing the course to view.

Cheers,

Yu

I can still reproduce the following issue:

1) In a course, go to the calendar view.
2) Observe that the course var is correctly set in the URL and the course is correctly selected in the drop down menu.
3) In the Month view (calendars on the right column), click in the title link (name of the month), e.g. "october 2007".
4) Observe that the course var disappears from the URL and that the dropdown menu shows now "All courses".

Thanks for fixing this.

Could you let us know the contact detail (email will be good) of David or Derek from Open University. So I can ask him how to fix the bug for Version of 1.8.2. Many thanks.

Best wishes,
Brad

Nicolas, I agree with you. I did some testing and it IS partially fixed. The problem is that it's not consistent. For example, here is how you can reproduce the still existing problem:
1. Create a GROUP event (as sys admin) for Oct 15 2007
2. Then create a new COURSE event for Oct 22 2007. Here when you are creating the COURSE event, you will notice that the GROUP event that you just created is NOT displayed correctly (see screenshot).
3. After you finish creating the COURSE event, you will notice that the GROUP event that you just created for Oct 15 2007 is now back.

I will do some more testing and report back here..

But the problem seems old and I can't test on older versions.

Thanks for letting me know. It seem works fine after download those updates.

Cheers,
Brad

All other issues seems to be gone. Thank you Yu

When I create a new event, upon event being saved I get 2 error messages:

• • • Notice: Use of undefined constant CALENDAR_MAXCOURSES - assumed 'CALENDAR_MAXCOURSES' in C:\moodle\www\moodle18\moodle\calendar\view.php on line 264
    • Warning: Division by zero in C:\moodle\www\moodle18\moodle\calendar\view.php on line 264

Joseph

1. If you go into the "calendar" view then click on "Preferences" button on the upper-right corner (see screenshot), the course id won't carry over and therefore, if you "save changes" (even that you didn't change anything), then click on "Continue", then you will be redirected to /calendar/view.php without any parameters carry over. I double checked with the /calendar/preferences.php and noticed that it was not changed for this fix

2. If you navigate back to the Moodle Test Case course, then all of your events should now re-appear (as now the course=3 parameter is back), except the Global event (see the screenshot).

Yu could you help fixing these two issues please? Thanks so much!

Fixed in notice and warning, sorry, backported something from HEAD by accident.

Wen,

1) Fixed, but it's set in session not visible in URL, however you should return to the same course view after setting preferences.

2) There's a setting (a preference) "Upcoming events look-ahead" that determines how far ahead to look. I noticed in your screenshot the event is in Nov so you probably don't have it set for more than 30 days.

Cheers,

Yu

Now that the above issues are fixed. I still notice that the calendar/export.php is untouched and so whenever you click on the "export calendar" button then your most of your events would be gone! Also, when you are on the export.php page, if you click on the Calendar link from the Breadcrumbs, again that redirect does not include the course ID (see screenshot #3 "calendar_export_breadcrumb_wrong_parameter.png" above) and therefore you will lost most of your events in the next page view (displayed by view.php). Thanks again for your efforts on fixing this issue!

You are right it's trying to get a course variable which is not being passed in at all. I changed to use the session referrer variable if available. Please test again, thanks!

Cheers,

Yu

I got a new error msg here after update all the files changed.

The error msg came out when I try to create new event inside calendar's monthly view:

Fatal error: Call to undefined function build_navigation() in /moodle/calendar/event.php on line 274

Any idea?

Cheers,
Brad

1. under calendar/view.php at around line #136
$prefsbutton = calendar_preferences_button();
The calendar_preferences_button() does not pass over the course id info

2. under calendar/view.php at around line #165 (//Link to calendar export page), this line should also pass the course id
print_single_button('export.php', false, get_string('exportcalendar', 'calendar'));

By the way, I talked to Yu and I volunteered to backport all these fixes to 1.5 (currently only tested on 1.5), so far it works although I still need some more testing. I will try to clean them up a little bit and post the backported version (for 1.5, and possibly for 1.6, 1.7 too) here so that people could help testing them. Thanks!

Wen, preference and export use session variable to keep tracker of the course id (for redirects, and headers). So I wasn't sure why course ids need to be passed in explicitly, please explain. Thanks.

Cheers,

Yu

Thank you for your message. Can't connect with CVS this morning.

I download the wrong version of event.php file.
My moodle is version 1.8.2. So I need the v1.63.2.6 of event.php instead of V1.7.3.

Everything works fine after upload correct file. Many thanks you guys.

What's the V1.7.3 for? Is it for Moodle 1.9?

Cheers,
Brad

New problem. Please see the attached photo of Calendar_Day_View.png and Calendar_Editing_evet.png.

The course id and events all disappeared after edit a excising event. Moodle version 1.8.2.

Cheers,
Brad

I was able to reproduce the problem Brad reported. I think the switch($action) in event.php does handle case 'new' correctly but not the cases of 'edit' and possibly 'delete', Yu could you please take a look at this please?

Another separate issue. I also created screenshot #3 and #1 to demonstrate it probably still need course ID when you click on the "Export calendar" button (export.php) . As you could see if you login as an admin and login to one of the courses, then click on the "Export calendar" button, as the course ID was not carried over, so on your right hand view ("monthly view") many events will disappear. Same thing with "Preferences" button. Please let me know if you have questions. Thanks!

Fixed the events not showing up problem in export, and when editing existing event. However, I was unable to reproduce the problem in preferences. Wen maybe you can help me there, can you tell me exactly how to reproduce the exact problem in preferences?

Cheers,

Yu

I can't reproduce the preferences problem neither on 1.8.2+ or 1.9beta2. Even if the courseid isn't present in the URL, the session seems to take care of it and keeps the correct course id.

Suggesting closing of this bug, since the remaining problems (group issues with calendar) should be dealed in MDL-9059.

Login as admin
1. Create two courses and assign them to one teacher, create whole bunch of events for both courses (very important)
2. Login as that teacher, get into one of the two courses, and click on Calendar, say October 2007 (see screenshot BEFORE_clicking_preferences.png)
3. Click on the "Preferences" button on the upper-right corner
4. Notice now that course ID was not passed over and the preferences.php shows ? at the end (although the session should have passed over), now do NOT click on "Save changes", click on the "Calendar" on the breadcrumb (navigation) bar, now suddenly you will be able to see BOTH course events, and the "Upcoming Events" pull-down menu is now reset to "All courses" (see screenshot AFTER_clicking_preferences_then_Calendar_breadcrumb.png)

It's not a major issue, but it could get teachers confused if they don't know they should use the "Upcoming Events" pull down menu and set it back to one course only. I have identified where need to be fixed. In preferences.php line#61, the $navigation should probably be handled similar to how $nav is handled in both view.php (line#70) or export.php (line#25), what do you think? This should be able to fix this issue. Hope this helps.

I have back ported the fixes to moodle 1.5.x and I could do the same thing with 1.6.x and 1.7.x too. Attached please find the fix for 1.5. I tested it throughly but it would be good if someone could help testing it before I commit it to the MOODLE_15_STABLE branch. Thanks!

Thanks.

On line the 249 of event.php an HTML representation of the "&" character is used.

This should be changed to a literal value, i.e. change & to &

http://www.w3.org/TR/xhtml1/#C_12

So the other ones on that line need changing.

That line of code never render's to (X)HTML, it is used in a redirect.

Can we close this now?

It would be easier to find how to solve this issue when we use version 1.8.2.