Issue Details (XML | Word | Printable)

Key: MDL-10353
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Wen Hao Chuang
Reporter: Alan Trick
Votes: 17
Watchers: 25
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

calendar doesn't remember course properly in moodle (1.6-1.7)

Created: 06/Jul/07 12:28 AM   Updated: 30/Jan/09 09:44 AM
Return to search
Component/s: Calendar
Affects Version/s: 1.5.4, 1.6, 1.6.1, 1.6.2, 1.6.3, 1.6.4, 1.6.5, 1.7, 1.7.1, 1.7.2
Fix Version/s: 1.8.4, 1.9

File Attachments: 1. Zip Archive calendar15x.zip (29 kB)

Image Attachments:

1. 0_AFTER_clicking_preferences_then_Calendar_breadcrumb.png
(82 kB)

2. 0_BEFORE_clicking_preferences.png
(73 kB)

3. After_click_on_Export_calendar_button.png
(125 kB)

4. after_create_a_new_course_event.png
(122 kB)

5. Before_click_on_Export_calendar_button.png
(136 kB)

6. calendar_course_id_back_to_3.png
(84 kB)

7. Calendar_Day_View.png
(176 kB)

8. Calendar_Editing_event.png
(167 kB)

9. calendar_export_breadcrumb_wrong_parameter.png
(115 kB)

10. calendar_not_listing_global_event.png
(112 kB)

11. when_you_create_a_new_event.png
(122 kB)
Environment: Probably irrelevant, but RHEL4 w/ apache2, php 5.2.0 and a remote MSSQL 2005 database
Issue Links:
Duplicate
 
Relates
 

Participants: Alan Trick, Anthony Borrow, Brad Hong, Chris Fryer, Frédéric Hoogstoel, Jeremy Hopkins, Joseph Rézeau, Ken Bauer, Martin Dougiamas, Nicolas Martignoni, Paul Stokes, Teresa Pomposo, Wen Hao Chuang and Yu Zhang
Security Level: None
QA Assignee: Nicolas Martignoni
Resolved date: 28/Jan/09
Affected Branches: MOODLE_15_STABLE, MOODLE_16_STABLE, MOODLE_17_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
If you go to the detailed view of a calendar from a course, it will include the course id in the url (e.g. calendar/view.php?view=month&course=13&cal_d=1&cal_m=06&cal_y=2007). However, all of the links in the calendar do not have the course parameter so you'll get something like calendar/view.php?view=month&cal_d=1&cal_m=06&cal_y=2007. Oddly enough, it still stores which course you came from because that shows up in the breadcrumb, but it must be in a cookie or something.

This is bad on a number of accounts.
1. If the user bookmarks what they think is their calendar in one course, they come back later and it's another course because the cookie got changed.
2. For admin users who are viewing calendars for courses their not enrolled in, this is a big problem. Only the URLs with the course parameter will display the course's events. So as soon as they try to navigate anywhere in the calendar, they can't see anything anymore.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
toyomoyo committed 8 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 02/Oct/07 02:26 PM
MDL-10353, calendar not keeping course id in url, backporting MDL-10084
MODIFY calendar/event.php   Rev. 1.63.2.5    (+8 -8 lines)
MODIFY calendar/Attic/event_new.html   Rev. 1.11.2.1    (+1 -0 lines)
MODIFY calendar/view.php   Rev. 1.77.2.9    (+26 -16 lines)
MODIFY calendar/lib.php   Rev. 1.164.2.20    (+20 -7 lines)
MODIFY calendar/set.php   Rev. 1.17.6.3    (+11 -4 lines)
MODIFY calendar/Attic/event_select.html   Rev. 1.7.20.1    (+1 -0 lines)
MODIFY calendar/Attic/event_edit.html   Rev. 1.12.2.1    (+1 -0 lines)
MODIFY calendar/Attic/event_delete.html   Rev. 1.6.2.1    (+3 -0 lines)
toyomoyo committed 2 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 03/Oct/07 12:20 PM
MDL-10353, fixing 2 more raised calendar issues
MODIFY calendar/event.php   Rev. 1.63.2.6    (+6 -2 lines)
MODIFY calendar/lib.php   Rev. 1.164.2.21    (+8 -8 lines)
toyomoyo committed 1 file to 'Moodle CVS' - 03/Oct/07 12:21 PM
MDL-10353, in view.php we should not supply default course, otherwise calendar filters will not be set up properly (course filter wrong)
MODIFY calendar/event.php   Rev. 1.73    (+6 -2 lines)
toyomoyo committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 04/Oct/07 11:00 AM
MDL-10353, (calendar) accidentally backported new stuff from HEAD
MODIFY calendar/view.php   Rev. 1.77.2.10    (+1 -7 lines)
toyomoyo committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 04/Oct/07 01:12 PM
MDL-10353, after setting preferences in calendar user should return to same course
MODIFY calendar/preferences.php   Rev. 1.16.4.2    (+2 -2 lines)
toyomoyo committed 1 file to 'Moodle CVS' - 04/Oct/07 01:13 PM
merged fix for MDL-10353, after setting preferences user should return to same course view
MODIFY calendar/preferences.php   Rev. 1.19    (+2 -2 lines)
toyomoyo committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 05/Oct/07 11:51 AM
MDL-10353, calender export not handling course variable correctly
MODIFY calendar/export.php   Rev. 1.2.4.3    (+11 -6 lines)
toyomoyo committed 1 file to 'Moodle CVS' - 05/Oct/07 11:52 AM
merged fix for MDL-10353, calendar export not handing course variable correctly
MODIFY calendar/export.php   Rev. 1.7    (+7 -2 lines)
toyomoyo committed 3 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 11/Oct/07 01:22 PM
MDL-10353, calender redirection broken when editting and exporting
MODIFY calendar/export.php   Rev. 1.2.4.4    (+20 -15 lines)
MODIFY calendar/lib.php   Rev. 1.164.2.22    (+2 -2 lines)
MODIFY calendar/view.php   Rev. 1.77.2.11    (+5 -2 lines)
toyomoyo committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 11/Oct/07 01:23 PM
MDL-10353, calender redirection broken when editting and exporting
MODIFY calendar/view.php   Rev. 1.95.2.1    (+2 -1 lines)
MODIFY calendar/export.php   Rev. 1.7.2.1    (+8 -9 lines)
toyomoyo committed 2 files to 'Moodle CVS' - 11/Oct/07 01:24 PM
MDL-10353, calender redirection broken when editting and exporting
MODIFY calendar/export.php   Rev. 1.8    (+8 -9 lines)
MODIFY calendar/view.php   Rev. 1.96    (+2 -1 lines)
toyomoyo committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 15/Oct/07 12:45 PM
MDL-10353, adding couse variable to nav bar in calendar preferences
MODIFY calendar/preferences.php   Rev. 1.16.4.3    (+3 -3 lines)
toyomoyo committed 4 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 15/Oct/07 12:46 PM
MDL-10353, adding couse variable to nav bar in calendar preferences
MODIFY calendar/preferences.php   Rev. 1.19.2.1    (+2 -2 lines)
MODIFY calendar/export.php   Rev. 1.7.2.3    (+14 -6 lines)
MODIFY calendar/lib.php   Rev. 1.206.2.1    (+6 -2 lines)
MODIFY calendar/view.php   Rev. 1.95.2.3    (+2 -2 lines)
toyomoyo committed 3 files to 'Moodle CVS' - 15/Oct/07 12:46 PM
MDL-10353, adding couse variable to nav bar in calendar preferences
MODIFY calendar/export.php   Rev. 1.9    (+9 -2 lines)
MODIFY calendar/view.php   Rev. 1.97    (+2 -2 lines)
MODIFY calendar/lib.php   Rev. 1.207    (+6 -2 lines)
whchuang committed 9 files to 'Moodle CVS' on branch 'MOODLE_15_STABLE' - 26/Oct/07 08:06 AM
Fixed MDL-10353. Note that this problem is now fixed in 1.5.x, 1.8.x, 1.9.x and HEAD, but not yet in 1.6.x and 1.7.x (not yet backported).
MODIFY calendar/Attic/event_edit.html   Rev. 1.10.2.1    (+2 -1 lines)
MODIFY calendar/lib.php   Rev. 1.125.2.5    (+26 -11 lines)
MODIFY calendar/Attic/event_delete.html   Rev. 1.5.2.1    (+6 -3 lines)
MODIFY calendar/set.php   Rev. 1.15.2.1    (+31 -22 lines)
MODIFY calendar/Attic/event_select.html   Rev. 1.7.2.1    (+1 -0 lines)
MODIFY calendar/view.php   Rev. 1.66.2.3    (+40 -17 lines)
MODIFY calendar/Attic/event_new.html   Rev. 1.7.2.1    (+5 -4 lines)
MODIFY calendar/preferences.php   Rev. 1.14.2.2    (+3 -3 lines)
MODIFY calendar/event.php   Rev. 1.42.2.6    (+25 -10 lines)