Issue Details (XML | Word | Printable)

Key: MDL-10359
Type: Bug Bug
Status: Open Open
Priority: Major Major
Assignee: Martin Dougiamas
Reporter: Wen Hao Chuang
Votes: 0
Watchers: 3
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Arrows missing when assigning roles in certain Web browsers

Created: 06/Jul/07 06:30 AM   Updated: 03/Jun/08 05:51 AM
Return to search
Component/s: Lib
Affects Version/s: 1.8, 1.8.1
Fix Version/s: None

File Attachments: None
Image Attachments:

1. Mac_firefox_arrow_broken.png
(165 kB)

2. mac_safari_missing_part_of_arrow.png
(263 kB)

Participants: Dan Poltawski, Martin Dougiamas and Wen Hao Chuang
Security Level: None
Affected Branches: MOODLE_18_STABLE


 Description  « Hide
Arrow symbols missing when assigning roles (See screenshots). Initially we found that the arrows are missing in a lot of places in Firefox on a Mac. Then we found that a part of an arrow in Safari (both PC and Mac) are missing as well.

Here is a proposed fix:
in /lib/weblib.php (at around line 2834):

[original]
        if (false !== strpos($uagent, 'Opera')
            || false !== strpos($uagent, 'Mac')) {

[suggest change to]

    if (false !== strpos($uagent, 'Safari')
|| (false !== strpos ($uagent, 'Firefox') && false !== strpos($uagent, 'Mac'))) {
            // Looks good in Win XP/Mac/Opera 8/9, Mac/Firefox 2, Camino, Safari.
            // Not broken in Mac/IE 5, Mac/Netscape 7 (?).
            $THEME->rarrow = '>';
            $THEME->larrow = '<';
        }
elseif (false !== strpos($uagent, 'Opera')) {
            // Looks good in Win XP/Mac/Opera 8/9, Mac/Firefox 2, Camino, Safari.
            // Not broken in Mac/IE 5, Mac/Netscape 7 (?).



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Dan Poltawski added a comment - 06/Jul/07 06:07 PM
I've also seen this on occasion, can currently verify it in Safari but not FF

Wen Hao Chuang added a comment - 03/Jun/08 05:51 AM
This one is also related to MDL-14932 which has been resolved, could someone please do some more testing with the latest 1.9.x+ build to see if this issue still happen in Safari? thanks!