|
|
|
File Attachments:
|
None
|
|
Image Attachments:
|
|
|
|
Arrow symbols missing when assigning roles (See screenshots). Initially we found that the arrows are missing in a lot of places in Firefox on a Mac. Then we found that a part of an arrow in Safari (both PC and Mac) are missing as well.
Here is a proposed fix:
in /lib/weblib.php (at around line 2834):
[original]
if (false !== strpos($uagent, 'Opera')
|| false !== strpos($uagent, 'Mac')) {
[suggest change to]
if (false !== strpos($uagent, 'Safari')
|| (false !== strpos ($uagent, 'Firefox') && false !== strpos($uagent, 'Mac'))) {
// Looks good in Win XP/Mac/Opera 8/9, Mac/Firefox 2, Camino, Safari.
// Not broken in Mac/IE 5, Mac/Netscape 7 (?).
$THEME->rarrow = '>';
$THEME->larrow = '<';
}
elseif (false !== strpos($uagent, 'Opera')) {
// Looks good in Win XP/Mac/Opera 8/9, Mac/Firefox 2, Camino, Safari.
// Not broken in Mac/IE 5, Mac/Netscape 7 (?).
|
|
Description
|
Arrow symbols missing when assigning roles (See screenshots). Initially we found that the arrows are missing in a lot of places in Firefox on a Mac. Then we found that a part of an arrow in Safari (both PC and Mac) are missing as well.
Here is a proposed fix:
in /lib/weblib.php (at around line 2834):
[original]
if (false !== strpos($uagent, 'Opera')
|| false !== strpos($uagent, 'Mac')) {
[suggest change to]
if (false !== strpos($uagent, 'Safari')
|| (false !== strpos ($uagent, 'Firefox') && false !== strpos($uagent, 'Mac'))) {
// Looks good in Win XP/Mac/Opera 8/9, Mac/Firefox 2, Camino, Safari.
// Not broken in Mac/IE 5, Mac/Netscape 7 (?).
$THEME->rarrow = '>';
$THEME->larrow = '<';
}
elseif (false !== strpos($uagent, 'Opera')) {
// Looks good in Win XP/Mac/Opera 8/9, Mac/Firefox 2, Camino, Safari.
// Not broken in Mac/IE 5, Mac/Netscape 7 (?).
|
Show » |
|