Moodle

Arrows missing when assigning roles in certain Web browsers

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.8, 1.8.1
  • Fix Version/s: None
  • Component/s: Libraries
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE

Description

Arrow symbols missing when assigning roles (See screenshots). Initially we found that the arrows are missing in a lot of places in Firefox on a Mac. Then we found that a part of an arrow in Safari (both PC and Mac) are missing as well.

Here is a proposed fix:
in /lib/weblib.php (at around line 2834):

[original]
if (false !== strpos($uagent, 'Opera')

false !== strpos($uagent, 'Mac')) {

[suggest change to]

if (false !== strpos($uagent, 'Safari')

(false !== strpos ($uagent, 'Firefox') && false !== strpos($uagent, 'Mac'))) { // Looks good in Win XP/Mac/Opera 8/9, Mac/Firefox 2, Camino, Safari. // Not broken in Mac/IE 5, Mac/Netscape 7 (?). $THEME->rarrow = '>'; $THEME->larrow = '<'; }
elseif (false !== strpos($uagent, 'Opera')) {
// Looks good in Win XP/Mac/Opera 8/9, Mac/Firefox 2, Camino, Safari.
// Not broken in Mac/IE 5, Mac/Netscape 7 .

Activity

Hide
Dan Poltawski added a comment -

I've also seen this on occasion, can currently verify it in Safari but not FF

Show
Dan Poltawski added a comment - I've also seen this on occasion, can currently verify it in Safari but not FF
Hide
Wen Hao Chuang added a comment -

This one is also related to MDL-14932 which has been resolved, could someone please do some more testing with the latest 1.9.x+ build to see if this issue still happen in Safari? thanks!

Show
Wen Hao Chuang added a comment - This one is also related to MDL-14932 which has been resolved, could someone please do some more testing with the latest 1.9.x+ build to see if this issue still happen in Safari? thanks!

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated: