|
History
| Log In
|
|
|
|
I've checked in the latest changes. Jerome, do you need direct CVS access?
I've only checked it into 1.8.x .... and not tested it.
IT STILL NEEDS TO BE MERGED TO HEAD (1.9). Can someone do that please? if you have access to one then you have access to the other ... to check out a copy of Moodle 1.8 use:
cvs -q update -dP -r MOODLE_18_STABLE and this to get HEAD: cvs -q update -dP -A BTW, please be really careful with your editing ... make sure you use Unix line feeds. The code I saw had a lot of line feed problems which I had to fix (and even then I missed some):
http://moodle.cvs.sourceforge.net/moodle/moodle/auth/cas/auth.php?r1=1.3.2.6&r2=1.3.2.7&pathrev=MOODLE_18_STABLE It's ok for me to access the cvs MOODLE_18_STABLE.
For the line feeds, i've convert the files into unix format, and i validate to the cvs. I think it's ok now. for 1.9 : i didn't install the 1.9 yet, and i wonder if the code of the cas module in 1.9 must be different of the cas module in 1.8, Hi, I've just noticed that CVS status for this module looks a bit strange.
On July 6th there was one big change by Martin and on July 9th another one by Jerôme apparently deleting a lot of lines. And those changes were only performed in the MOODLE_18_STABLE branch! So, can you confirm the status of the CAS module in MOODLE_18_STABLE ? And all those changes should go to HEAD too! And, also, the MOODLE_18_MERGED tag should be synchronised once everything is ok in HEAD. Would be great to have that fixed in both branches asap. Ciao :-) Raising priority a bit, so 1.9 Beta is near and changes must be sent to HEAD before!
Also, Jerôme, I've added you to the bug MDL-8912. We use it to inform developers about the presence of an important list of unmerged files (like the CAS ones actually). I hope you'll agree receiving such notifications (else, you can "unsuscribe" yourself).
Thanks and ciao :-) Raising to BLOCKER.
all the cool changes are only in 18_STABLE (never sent to HEAD). IMO no branching before this to be addressed. Any gutiérrez out there? ;-) Yes, definitely should be merged to HEAD as well or all that work will be lost. Can the original developer do it because we don't have facilities to test CAS.
doing a merge like this in HEAD
cvs -q update -dP -kk -j MOODLE_18_MERGED -j MOODLE_18_STABLE gives: C CAS/CAS.php C CAS/client.php M CAS/domxml-php4-php5.php M CAS/PGTStorage/pgt-db.php C CAS/PGTStorage/pgt-file.php C CAS/PGTStorage/pgt-main.php M CAS/languages/english.php M CAS/languages/french.php M CAS/languages/german.php M CAS/languages/greek.php The conflicts seem to be because of a formatting change. I've merged everything over to HEAD - can you please verify the CAS module still works? |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
Bug
Resolved
Major
BUG authentification CAS for new users
I think the problème is the same in the ldap module, as i take the ldap module code for this part of the cas module.
The probleme was in the ldap_get_entries function, i put a strtolower where i get entries in the array.