Moodle

BUG authentification CAS for new users

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8.1
  • Fix Version/s: 1.8.3, 1.9
  • Component/s: Authentication
  • Labels:
    None
  • Database:
    MySQL
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE

Description

The authentification CAS functions only for the users being already connected on Moodle before the migration to 1.8.1. For the new ones, moodle recovers only the attributes name and email but not the first name.

Issue Links

This issue has a non-specific relationship to:
MDL-8813 The CAS authentication is broken in 1.8 Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
GUTIERREZ added a comment -

Here is a new version of the cas module. The ldap attribute are not yet case sensitive.

I think the problème is the same in the ldap module, as i take the ldap module code for this part of the cas module.
The probleme was in the ldap_get_entries function, i put a strtolower where i get entries in the array.

Show
GUTIERREZ added a comment - Here is a new version of the cas module. The ldap attribute are not yet case sensitive. I think the problème is the same in the ldap module, as i take the ldap module code for this part of the cas module. The probleme was in the ldap_get_entries function, i put a strtolower where i get entries in the array.
Hide
Permalink
roumec added a comment -

Thanks a lot,
The authentification works now

Show
roumec added a comment - Thanks a lot, The authentification works now
Hide
Permalink
Martin Dougiamas added a comment -

I've checked in the latest changes. Jerome, do you need direct CVS access?

Show
Martin Dougiamas added a comment - I've checked in the latest changes. Jerome, do you need direct CVS access?
Hide
Permalink
Martin Dougiamas added a comment -

I've only checked it into 1.8.x .... and not tested it.

IT STILL NEEDS TO BE MERGED TO HEAD (1.9). Can someone do that please?

Show
Martin Dougiamas added a comment - I've only checked it into 1.8.x .... and not tested it. IT STILL NEEDS TO BE MERGED TO HEAD (1.9). Can someone do that please?
Hide
Permalink
GUTIERREZ added a comment -

I can do the modification on Moodle 1.9 if you want and i can be assigned systematically if there is some new bugs on the CAS module,
I still have cvs access to head (1.9) but not on 1.8. Could you give me this access,

thanks

Show
GUTIERREZ added a comment - I can do the modification on Moodle 1.9 if you want and i can be assigned systematically if there is some new bugs on the CAS module, I still have cvs access to head (1.9) but not on 1.8. Could you give me this access, thanks
Hide
Permalink
Martin Dougiamas added a comment -

if you have access to one then you have access to the other ... to check out a copy of Moodle 1.8 use:

cvs -q update -dP -r MOODLE_18_STABLE

and this to get HEAD:

cvs -q update -dP -A

Show
Martin Dougiamas added a comment - if you have access to one then you have access to the other ... to check out a copy of Moodle 1.8 use: cvs -q update -dP -r MOODLE_18_STABLE and this to get HEAD: cvs -q update -dP -A
Hide
Permalink
Martin Dougiamas added a comment -

BTW, please be really careful with your editing ... make sure you use Unix line feeds. The code I saw had a lot of line feed problems which I had to fix (and even then I missed some):

http://moodle.cvs.sourceforge.net/moodle/moodle/auth/cas/auth.php?r1=1.3.2.6&r2=1.3.2.7&pathrev=MOODLE_18_STABLE

Show
Martin Dougiamas added a comment - BTW, please be really careful with your editing ... make sure you use Unix line feeds. The code I saw had a lot of line feed problems which I had to fix (and even then I missed some): http://moodle.cvs.sourceforge.net/moodle/moodle/auth/cas/auth.php?r1=1.3.2.6&r2=1.3.2.7&pathrev=MOODLE_18_STABLE
Hide
Permalink
GUTIERREZ added a comment -

It's ok for me to access the cvs MOODLE_18_STABLE.
For the line feeds, i've convert the files into unix format, and i validate to the cvs. I think it's ok now.

for 1.9 : i didn't install the 1.9 yet, and i wonder if the code of the cas module in 1.9 must be different of the cas module in 1.8,

Show
GUTIERREZ added a comment - It's ok for me to access the cvs MOODLE_18_STABLE. For the line feeds, i've convert the files into unix format, and i validate to the cvs. I think it's ok now. for 1.9 : i didn't install the 1.9 yet, and i wonder if the code of the cas module in 1.9 must be different of the cas module in 1.8,
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Hi, I've just noticed that CVS status for this module looks a bit strange.

On July 6th there was one big change by Martin and on July 9th another one by Jerôme apparently deleting a lot of lines. And those changes were only performed in the MOODLE_18_STABLE branch!

So, can you confirm the status of the CAS module in MOODLE_18_STABLE ? And all those changes should go to HEAD too! And, also, the MOODLE_18_MERGED tag should be synchronised once everything is ok in HEAD.

Would be great to have that fixed in both branches asap. Ciao

Show
Eloy Lafuente (stronk7) added a comment - Hi, I've just noticed that CVS status for this module looks a bit strange. On July 6th there was one big change by Martin and on July 9th another one by Jerôme apparently deleting a lot of lines. And those changes were only performed in the MOODLE_18_STABLE branch! So, can you confirm the status of the CAS module in MOODLE_18_STABLE ? And all those changes should go to HEAD too! And, also, the MOODLE_18_MERGED tag should be synchronised once everything is ok in HEAD. Would be great to have that fixed in both branches asap. Ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Raising priority a bit, so 1.9 Beta is near and changes must be sent to HEAD before!

Show
Eloy Lafuente (stronk7) added a comment - Raising priority a bit, so 1.9 Beta is near and changes must be sent to HEAD before!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Also, Jerôme, I've added you to the bug MDL-8912. We use it to inform developers about the presence of an important list of unmerged files (like the CAS ones actually). I hope you'll agree receiving such notifications (else, you can "unsuscribe" yourself).

Thanks and ciao

Show
Eloy Lafuente (stronk7) added a comment - Also, Jerôme, I've added you to the bug MDL-8912. We use it to inform developers about the presence of an important list of unmerged files (like the CAS ones actually). I hope you'll agree receiving such notifications (else, you can "unsuscribe" yourself). Thanks and ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Raising to BLOCKER.

all the cool changes are only in 18_STABLE (never sent to HEAD). IMO no branching before this to be addressed.

Any gutiérrez out there?

Show
Eloy Lafuente (stronk7) added a comment - Raising to BLOCKER. all the cool changes are only in 18_STABLE (never sent to HEAD). IMO no branching before this to be addressed. Any gutiérrez out there?
Hide
Permalink
Martin Dougiamas added a comment -

Yes, definitely should be merged to HEAD as well or all that work will be lost. Can the original developer do it because we don't have facilities to test CAS.

Show
Martin Dougiamas added a comment - Yes, definitely should be merged to HEAD as well or all that work will be lost. Can the original developer do it because we don't have facilities to test CAS.
Hide
Permalink
GUTIERREZ added a comment -

Hi,

I've just verify the files cas/auth.php in head and 18_STABLE, and the files are the same. So i think the changes are in HEAD.
What files are unmerge ?

Show
GUTIERREZ added a comment - Hi, I've just verify the files cas/auth.php in head and 18_STABLE, and the files are the same. So i think the changes are in HEAD. What files are unmerge ?
Hide
Permalink
Martin Dougiamas added a comment -

doing a merge like this in HEAD

cvs -q update -dP -kk -j MOODLE_18_MERGED -j MOODLE_18_STABLE

gives:

C CAS/CAS.php
C CAS/client.php
M CAS/domxml-php4-php5.php
M CAS/PGTStorage/pgt-db.php
C CAS/PGTStorage/pgt-file.php
C CAS/PGTStorage/pgt-main.php
M CAS/languages/english.php
M CAS/languages/french.php
M CAS/languages/german.php
M CAS/languages/greek.php

The conflicts seem to be because of a formatting change.

I've merged everything over to HEAD - can you please verify the CAS module still works?

Show
Martin Dougiamas added a comment - doing a merge like this in HEAD cvs -q update -dP -kk -j MOODLE_18_MERGED -j MOODLE_18_STABLE gives: C CAS/CAS.php C CAS/client.php M CAS/domxml-php4-php5.php M CAS/PGTStorage/pgt-db.php C CAS/PGTStorage/pgt-file.php C CAS/PGTStorage/pgt-main.php M CAS/languages/english.php M CAS/languages/french.php M CAS/languages/german.php M CAS/languages/greek.php The conflicts seem to be because of a formatting change. I've merged everything over to HEAD - can you please verify the CAS module still works?

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.