Moodle

Allow removing of elements with disabledIf conditions

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.9
  • Component/s: Forms Library
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

The problem is that the getLockOptionEndScript() may try to use getElement with the name of removed element

Issue Links

This issue will help resolve:
MDL-10408 remove incompatibility between Moodle and Mootools JS framework Major Open

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

fixed in cvs

Show
Petr Škoda (skodak) added a comment - fixed in cvs
Hide
Permalink
Jamie Pratt added a comment -

This fix has broken disabledIf in many forms. The problem is that if the dependentOn element is an element in a group then elementExists will return false.

Will revert this for now.

Show
Jamie Pratt added a comment - This fix has broken disabledIf in many forms. The problem is that if the dependentOn element is an element in a group then elementExists will return false. Will revert this for now.
Hide
Permalink
Petr Škoda (skodak) added a comment -

Oh, sorry - working on another fix - thanks!

I am glad I did not try to commit it into head

Show
Petr Škoda (skodak) added a comment - Oh, sorry - working on another fix - thanks! I am glad I did not try to commit it into head
Hide
Permalink
Petr Škoda (skodak) added a comment -

reclosing - thanks!

Show
Petr Škoda (skodak) added a comment - reclosing - thanks!
Hide
Permalink
Petr Škoda (skodak) added a comment -

added some more checks to prevent JS errors when hardFreezing elements with disabledIf conditions

Show
Petr Škoda (skodak) added a comment - added some more checks to prevent JS errors when hardFreezing elements with disabledIf conditions
Hide
Permalink
Jamie Pratt added a comment -

The code to fix this is very similar to the patch Urs is working on to have mooTools js framework work with Moodle.

Show
Jamie Pratt added a comment - The code to fix this is very similar to the patch Urs is working on to have mooTools js framework work with Moodle.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.