Issue Details (XML | Word | Printable)

Key: MDL-10385
Type: Sub-task Sub-task
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Yu Zhang
Reporter: Nicolas Connault
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-9628

Use locale settings for decimal separators

Created: 09/Jul/07 04:22 PM   Updated: 19/Aug/09 07:56 PM
Return to search
Component/s: Gradebook
Affects Version/s: 1.9
Fix Version/s: 1.9

Issue Links:
Relates
 

Participants: Nicolas Connault, Nicolas Martignoni, Paul Nijbakker, Petr Skoda and Yu Zhang
Security Level: None
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
Use locale settings for thousands and decimal separators

edit: thousand separator support was removed because it often collided with list separator :-(

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Nicolas Martignoni added a comment - 10/Jul/07 08:07 PM
Is the   entity allowed for string thousandsep? (It's used in french language).

Nicolas Connault added a comment - 11/Jul/07 12:49 AM
As far as I know, PHP's number_format() function will be used, so only the locale settings will be applied. For french, I believe it is dot (.) for thousands and comma (,) for decimals. I don't think we'll implement customised separators.

Yu Zhang added a comment - 11/Jul/07 10:56 AM
Hi,

Yes it uses number_format(), but this is actually not locale based. This is tied to the language pack, so every language pack can have it's own decimal point and thousand separator. So if 2 courses have 2 different languages, the grades in the gradebook will look different (if the decimal point or thousand separators are different)

I think   might have some issues, because when user submit I think you can end up getting   (printed) and & (when manually entered) so might be tricky to process.

Yu


Nicolas Martignoni added a comment - 11/Jul/07 02:17 PM
Thanks for the clarification Yu.

OT: hello Nicolas, Hope you're well installed now in Rennes


Yu Zhang added a comment - 18/Jul/07 04:44 PM
added 2 more strings in config.

Petr Skoda added a comment - 27/Sep/07 05:57 PM
thousand separators are not supported

Paul Nijbakker added a comment - 19/Aug/09 07:56 PM
This setting does not seem to affect the decimal separators in calculated quiz questions or numerical cloze questions. Is there any way to achieve that these quiz question types recognise a comma as decimal separator?