[#MDL-10385] Use locale settings for decimal separators

Issue Details (XML | Word | Printable)

Key:	MDL-10385
Type:	Sub-task
Status:	Closed
Resolution:	Fixed
Priority:	Major
Assignee:	Yu Zhang
Reporter:	Nicolas Connault
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-9628

Use locale settings for decimal separators

Created: 09/Jul/07 04:22 PM Updated: 19/Aug/09 07:56 PM

Return to search

Component/s:

Gradebook

Affects Version/s:

1.9

Fix Version/s:

1.9

Issue Links:

Relates

This issue has been marked as being related by:

~~MDL-10791~~ improve handling of floating point numbers in moodle

Participants:	Nicolas Connault, Nicolas Martignoni, Paul Nijbakker, Petr Skoda and Yu Zhang
Security Level:	None
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

Use locale settings for thousands and decimal separators

edit: thousand separator support was removed because it often collided with list separator :-(

All

Comments

Change History

Version Control

Sort Order:

toyomoyo committed 2 files to 'Moodle CVS' - 10/Jul/07 05:01 PM

~~MDL-10385~~, use langconfig specific decimal point and thousand separator when printing grades. Grade validation for grademin/grademax range

MODIFY	grade/report/grader/index.php		Rev. 1.35		(+60 -9 lines)
MODIFY	lang/en_utf8/langconfig.php		Rev. 1.6		(+3 -1 lines)

martignoni committed 1 file to 'Lang CVS' - 10/Jul/07 08:05 PM

~~MDL-10385~~, use langconfig specific decimal point and thousand separator when printing grades. Grade validation for grademin/grademax range

MODIFY

fr_utf8/langconfig.php

Rev. 1.5

(+2 -0 lines)

[ Permalink | « Hide ]

Nicolas Martignoni added a comment - 10/Jul/07 08:07 PM

Is the entity allowed for string thousandsep? (It's used in french language).

Mitsuhiro Yoshida committed 25 files to 'Lang CVS' - 10/Jul/07 11:05 PM

Brushed up translated docs ~~MDL-4912~~.
Removed most of the docs based on lang/en_utf8 change ~~MDL-4912~~.
Updated langconfig based on lang/en_utf8 change ~~MDL-10385~~.

DEL	ja_utf8/docs/Attic/future.html	Rev. 1.7	(+0 -0 lines)
DEL	ja_utf8/docs/Attic/faq.html	Rev. 1.7	(+0 -0 lines)
DEL	ja_utf8/docs/Attic/upgrade.html	Rev. 1.6	(+0 -0 lines)
MODIFY	ja_utf8/langconfig.php	Rev. 1.8	(+6 -4 lines)
DEL	ja_utf8/docs/Attic/cvs.html	Rev. 1.6	(+0 -0 lines)
DEL	ja_utf8/docs/Attic/intro.html	Rev. 1.7	(+0 -0 lines)
DEL	ja_utf8/docs/Attic/developer.html	Rev. 1.10	(+0 -0 lines)
DEL	ja_utf8/docs/Attic/install.html	Rev. 1.15	(+0 -0 lines)
MODIFY	ja_utf8/docs/licence.html	Rev. 1.9	(+4 -3 lines)
MODIFY	ja_utf8/docs/README.txt	Rev. 1.4	(+8 -39 lines)
DEL	ja_utf8/docs/Attic/teacher.html	Rev. 1.15	(+0 -0 lines)
MODIFY	ja_utf8/docs/module_files.txt	Rev. 1.4	(+3 -3 lines)
DEL	ja_utf8/docs/Attic/coding.html	Rev. 1.10	(+0 -0 lines)
DEL	ja_utf8/docs/Attic/background.html	Rev. 1.10	(+0 -0 lines)
DEL	ja_utf8/docs/Attic/installamp.html	Rev. 1.9	(+0 -0 lines)
DEL	ja_utf8/docs/Attic/release.html	Rev. 1.13	(+0 -0 lines)
MODIFY	ja_utf8/README	Rev. 1.455	(+1 -1 lines)
DEL	ja_utf8/docs/Attic/other.html	Rev. 1.5	(+0 -0 lines)
DEL	ja_utf8/docs/Attic/releaseold.html	Rev. 1.31	(+0 -0 lines)
DEL	ja_utf8/docs/Attic/translation.html	Rev. 1.8	(+0 -0 lines)
DEL	ja_utf8/docs/Attic/docstyles.css	Rev. 1.4	(+0 -0 lines)
DEL	ja_utf8/docs/Attic/credits.html	Rev. 1.10	(+0 -0 lines)
DEL	ja_utf8/docs/Attic/files.php	Rev. 1.3	(+0 -0 lines)
DEL	ja_utf8/docs/Attic/philosophy.html	Rev. 1.11	(+0 -0 lines)
DEL	ja_utf8/docs/Attic/features.html	Rev. 1.10	(+0 -0 lines)

[ Permalink | « Hide ]

Nicolas Connault added a comment - 11/Jul/07 12:49 AM

As far as I know, PHP's number_format() function will be used, so only the locale settings will be applied. For french, I believe it is dot (.) for thousands and comma (,) for decimals. I don't think we'll implement customised separators.

[ Permalink | « Hide ]

Yu Zhang added a comment - 11/Jul/07 10:56 AM

Hi,

Yes it uses number_format(), but this is actually not locale based. This is tied to the language pack, so every language pack can have it's own decimal point and thousand separator. So if 2 courses have 2 different languages, the grades in the gradebook will look different (if the decimal point or thousand separators are different)

I think might have some issues, because when user submit I think you can end up getting (printed) and & (when manually entered) so might be tricky to process.

[ Permalink | « Hide ]

Nicolas Martignoni added a comment - 11/Jul/07 02:17 PM

Thanks for the clarification Yu.

OT: hello Nicolas, Hope you're well installed now in Rennes

[ Permalink | « Hide ]

Yu Zhang added a comment - 18/Jul/07 04:44 PM

added 2 more strings in config.

Yu Zhang made changes - 18/Jul/07 04:44 PM

Field	Original Value	New Value
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Closed [ 6 ]
Fix Version/s		1.9 [ 10190 ]

Petr Skoda made changes - 11/Aug/07 12:03 AM

Link

This issue has been marked as being related by ~~MDL-10791~~ [ ~~MDL-10791~~ ]

[ Permalink | « Hide ]

Petr Skoda added a comment - 27/Sep/07 05:57 PM

thousand separators are not supported

Petr Skoda made changes - 27/Sep/07 05:57 PM

Summary	Use locale settings for thousands and decimal separators	Use locale settings for decimal separators
Description	Use locale settings for thousands and decimal separators	Use locale settings for thousands and decimal separators edit: thousand separator support was removed because it often collided with list separator :-(

[ Permalink | « Hide ]

Paul Nijbakker added a comment - 19/Aug/09 07:56 PM

This setting does not seem to affect the decimal separators in calculated quiz questions or numerical cloze questions. Is there any way to achieve that these quiz question types recognise a comma as decimal separator?

All content on this web site is made available under the GNU General Public License, unless otherwise stated.