|
Any ideas as to why this has not yet been comitted to core on the 1.8 branch? Still have this problem on 1.8.3, which is solved by the patch above.
I do not think this is a proper solution, unfortunately I do not have either MS Windows or MS Office on my computers anymore, sorry.
Assigning to Nicolas.
Petr Skoda made changes - 18/Dec/07 04:17 AM
looks like this fixes it for power points opening in a new window only. same window powerpoint resources open in powerpoint but show only one blank slide.
We are currently advising teachers to use power point shows pps or ppsx as these have the added advantage of not needing powerpoint. But as a quick fix I edited mod/resource/type/file/resource.class.php to add at line 257 else if ($mimetype == "application/vnd.ms-powerpoint") { $resource->popup = 'resizable=1,scrollbars=1,directories=1,location=1,menubar=1,toolbar=1,status=1,height=450,width=620'; $inpopup = true; } This forces all power points to open in a new window. Sorry cant do diff I don't have MS Office either, and unless it is offered to me (highly unlikely), I will never have it. Unless someone is opposed to it, I will implement the proposed fix to satisfy all the users who depend on MS Office.
Petr Skoda made changes - 25/Jan/08 05:05 AM
Oki, I finally have office licenses again, goint to work on this next week
We found and resolve this problem on 1.6.5. We migrating to 1.8 and found that the bug still there so we patched again.
With a sniffer I founded that PowerPoint try to open the file with a new socket has suggest Juan Segarra Montesinos on Our solution is a little different but still to force download. We have tested lately on Vista and Office 07 and found that it works whit out the patch but take to much time to display. The sniffer show us that it try to open and get file status before having no choice but to use the file get by the browser kept in cache. Here our solution, hope it help.
Patch for lib/filelib.php
Daniel Pouliot made changes - 05/Feb/08 01:58 AM
Petr Skoda made changes - 05/Feb/08 03:08 AM
I did extensive testing on several computers running XP, Vista + Office 2003 and 2007. I could replicate the problem only on systems with Office 2007 without service pack. After installing SP1 for 2007, everything works fine again.
this is not our bug, I suppose the problem involved is: http://support.microsoft.com/kb/935869
Petr Skoda made changes - 05/Feb/08 05:04 AM
thanks for the report anyway!
Petr Skoda made changes - 20/Feb/08 01:24 AM
I do think it is possible and worthwhile to try to workaround this issue based on the client string. Trying to come up with a patch...
In terms of diagnosing what is happening, I think that IE sees the URL ending in ppt, and perhaps even does a HEAD on the URL to see the MIME type, and as it is application/vnd.ms-powerpoint it just invokes powerpoint and gives it the url. But Powerpoint does not have the right access cookies. I also suspect that Powerpoint may be assuming that the URL is WebDAV-capable, and may be trying to do a WebDAV-style "in-place" open. In any case, this is literally limited to a particular version of IE. Trying to track this down... This patch implements a very specific workaround: only for IE clients, the application/vnd.ms-powerpoint mimetype gets changed to application/x-download.
The other two patches posted have the following problems
I think it is suitable that this remains as a patch – but if enough people have problem with installign SP1, then we could put this into CVS and make it conditional on a config setting ($CFG->workaroundppt2007downloadbug).
Martín Langhoff made changes - 26/Feb/08 08:46 AM
Pretty colour-coded version of the patch here http://git.catalyst.net.nz/gitweb?p=moodle-r2.git;a=commitdiff;h=6a3154bb35deedc9819f9a737630259330db48ff
 This patch fixes up a problem with the previous one, and tests correctly.
Martín Langhoff made changes - 27/Feb/08 08:39 AM
And the fixed up colour coded patch http://git.catalyst.net.nz/gitweb?p=moodle-r2.git;a=commitdiff;h=b277f77bafbada47359e799ba2a1aebae2fbd129
This problem seems to turn up when there are proxies or special cookie authentication mechanisms in place. With a vanilla moodle, I could not reproduce the issue - from the same client machine that reproduces the problem against a moodle with a special auth module. Martín, I do not understand why it works for me on my Vista+office 2007SP1 test setup. Your "patch" breaks my PowerPoint, hmmm...
Does your Office 2007 have SP1 installed? Could I get access to that machine to review what exactly is going over the wire? Or could you send me some wireshark dumps?
Hi Petr! My 2nd patch breaks stuff? Are you sure? All it does is change the mimetype and forces a download.
The test machine does not have SP1 applied – we checked – and I don't really have access to it. Yesterday I was visiting the user that has the problem, and I came up with this patch. Without the patch, it's broken, with the patch it works. Make sure you use the newer one - there are two patches I've uploaded.
If the Office does not have SP1 then PLEASE do install it, the vanilla 2007 is known to be broken in many ways.
"Breaks" means it open the file fine inside the browser, with the patch it open outside which is different from the rest 
my -2 for the patch is SP1 works |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Improvement
Resolved
Major
IE can't open powerpoint resource file type.
 |
|
This fix saved us, so thanks for posting! I hope this is adopted in core soon, and also provided for 1.8.2.