Moodle

$table->head of admin/user.php needs some fix.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8.4, 1.9
  • Fix Version/s: 1.8.6, 1.9.2
  • Component/s: Administration
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE

Description

Now $table->head of admin/user.php is fixed as "Firstname / Lastname".
We need to change this title order depends on $CFG->fullnamedisplay as below.

Index: user.php
===================================================================
RCS file: /cvsroot/moodle/moodle/admin/user.php,v
retrieving revision 1.108
diff -u -r1.108 user.php
— user.php 30 Apr 2007 17:08:41 -0000 1.108
+++ user.php 24 Jul 2007 10:34:08 -0000
@@ -303,7 +303,20 @@

$mainadmin = get_admin();

  • $table->head = array ("$firstname / $lastname", $email, $city, $country, $lastaccess, "", "", "");
    + $override->firstname = 'firstname';
    + $override->lastname = 'lastname';
    + $fullnamelanguage = get_string('fullnamedisplay', '', $override);
    + if ($CFG->fullnamedisplay == 'firstname lastname') { + $table->head = array ("$firstname / $lastname", $email, $city, $country, $lastaccess, "", "", ""); + } else if ($CFG->fullnamedisplay == 'language')
    Unknown macro: {+ if ($fullnamelanguage == 'firstname lastname') { + $table->head = array ("$firstname / $lastname", $email, $city, $country, $lastaccess, "", "", ""); + } else { + $table->head = array ("$lastname / $firstname", $email, $city, $country, $lastaccess, "", "", ""); + }+ }
    else { + $table->head = array ("$lastname / $firstname", $email, $city, $country, $lastaccess, "", "", ""); + }
    $table->align = array ("left", "left", "left", "left", "left", "center", "center", "center");
    $table->width = "95%";
    foreach ($users as $user) {

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Agree that the $CFG->fullnamedisplay should be respected there (both permutations and lag based setting).

+1 for this from 18_STABLE to HEAD.

Assigning to Mathieu. Confirm with MD.

Thanks for the report and initial patch, Mits! B-)

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Agree that the $CFG->fullnamedisplay should be respected there (both permutations and lag based setting). +1 for this from 18_STABLE to HEAD. Assigning to Mathieu. Confirm with MD. Thanks for the report and initial patch, Mits! B-) Ciao
Hide
Mathieu Petit-Clair added a comment -

Tested, adjusted & committed to 1.8/1.9/head. Thanks.

Show
Mathieu Petit-Clair added a comment - Tested, adjusted & committed to 1.8/1.9/head. Thanks.
Hide
Petr Škoda (skodak) added a comment -

closing, next time please do not forget to initialise all objects (fixed in cvs)

Show
Petr Škoda (skodak) added a comment - closing, next time please do not forget to initialise all objects (fixed in cvs)

Dates

  • Created:
    Updated:
    Resolved: