Moodle

Popup windows need uniform body class

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8.2
  • Fix Version/s: 2.0
  • Component/s: Themes
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

Popup windows in Moodle cannot currently be styled separately from non-popup windows due to lack of a uniform body class identifying it as such (ex: #mod-resource-view and .mod-resource will modify all resources).

This is problematic when creating themes that are fixed-width and/or use margins or padding around the page or content. Popups appear fixed or padded in windows that do not support their size. A uniform class attached to all popups would really open the doors to theme development.

Moodle Themes discussion on this topic here: http://moodle.org/mod/forum/discuss.php?d=77000

Issue Links

This issue has a clone:
MDL-12093 It is not possible to change the page layout in popup windows Major Closed
This issue will be resolved by:
MDL-10665 Moodle page optimization Major Open

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Urs Hunkler added a comment -

Same issue

Show
Urs Hunkler added a comment - Same issue
Hide
Permalink
Urs Hunkler added a comment - - edited

Martin, please support the solution Eloy has proposed and I started to integrate.

Show
Urs Hunkler added a comment - - edited Martin, please support the solution Eloy has proposed and I started to integrate.
Hide
Permalink
Tim Hunt added a comment -

Petr, I am pretty sure you did this with your second round of theme changes, so closing this.

Show
Tim Hunt added a comment - Petr, I am pretty sure you did this with your second round of theme changes, so closing this.

People

Vote (2)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.