[#MDL-10718] Undefined property $email notice from /admin/settings/server.php prior to login

Issue Details (XML | Word | Printable)

Key:	MDL-10718
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Trivial
Assignee:	Petr Skoda
Reporter:	Anthony Borrow
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Undefined property $email notice from /admin/settings/server.php prior to login

Created: 05/Aug/07 10:54 PM Updated: 20/Dec/07 12:41 PM

Return to search

Component/s:

Administration

Affects Version/s:

1.9

Fix Version/s:

1.9

Issue Links:

Relates

This issue has a non-specific relationship to:

~~MDL-12401~~ list of other admin problems

Participants:	Anthony Borrow, Martin Dougiamas and Petr Skoda
Security Level:	None
QA Assignee:	Anthony Borrow
Resolved date:	20/Dec/07
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

With debugging on and prior to login, the front page displays

Notice: Undefined property: object::$email in /home/aborrow/workspace/MoodleHead/admin/settings/server.php on line 60

The code is attempting to get the user's email; however, there is no user. Should this be checked for? Is it worth checking?

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 06/Aug/07 11:06 PM

Yep did this today, thanks!

Martin Dougiamas made changes - 06/Aug/07 11:06 PM

Field	Original Value	New Value
Fix Version/s		1.9 [ 10190 ]
Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

[ Permalink | « Hide ]

Anthony Borrow added a comment - 07/Aug/07 11:36 AM

Martin - I'm not sure why as the code you posted to fix this would seem to address the issue; however, now I am getting the following:

Notice: Undefined property: object::$email in /home/aborrow/workspace/MoodleHead/admin/settings/server.php on line 68

I would be curious what $USER is prior to logging in. Whatever it is it does not seem to have an email attribute. I'll see if I can figure out what might be happening.

I went ahead and re-opened the issue since it is still there; however, I still consider this to be pretty trivial. Best of luck as you get closer to releasing 1.9. Peace - Anthony

Anthony Borrow made changes - 07/Aug/07 11:36 AM

Status	Resolved [ 5 ]	Reopened [ 4 ]
Resolution	Fixed [ 1 ]

Petr Skoda made changes - 01/Dec/07 06:16 AM

Link

This issue has a non-specific relationship to ~~MDL-12401~~ [ ~~MDL-12401~~ ]

[ Permalink | « Hide ]

Petr Skoda added a comment - 20/Dec/07 03:12 AM

this should be fixed now, please reopen if needed
thanks

Petr Skoda made changes - 20/Dec/07 03:12 AM

Assignee	Martin Dougiamas [ dougiamas ]	Petr Skoda [ skodak ]
Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

[ Permalink | « Hide ]

Anthony Borrow added a comment - 20/Dec/07 12:41 PM

Skodak - I attempted to recreate and the issue indeed seems to be resolved. I'm going to go ahead and close it. Peace - Anthony

Anthony Borrow made changes - 20/Dec/07 12:41 PM

QA Assignee		aborrow
Status	Resolved [ 5 ]	Closed [ 6 ]

All content on this web site is made available under the GNU General Public License, unless otherwise stated.