Moodle

RTL tabs problems

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8, 1.8.1, 1.8.2
  • Fix Version/s: None
  • Component/s: Other, Themes, Unicode, Unknown
  • Labels:
    None
  • Environment:
    Cross-platform
  • Database:
    MySQL
  • Affected Branches:
    MOODLE_18_STABLE

Description

Users that choose a Right-to-Left Interface language cannot press use their account's tabbed links (edit profile etc.).
It seems that the links are not in sync with the words position; no hand is present.

This bug was tested on two different computers, and several Moodle 1.8+ and 1.8.2+ installations.

Attachments

  1. File
    rtl.css
    07/Apr/09 3:27 PM
    12 kB
    Shamim Rezaie
  2. File
    rtl.css
    20/Mar/09 3:00 AM
    12 kB
    Shamim Rezaie
  3. File
    rtl.css
    07/Mar/09 5:15 AM
    11 kB
    Shamim Rezaie
  1. 1.8.png
    33 kB
    05/Aug/07 11:11 PM
  2. FF.jpg
    87 kB
    09/Mar/09 6:21 AM
  3. IE.jpg
    118 kB
    09/Mar/09 6:21 AM
  4. IE6 Problems.jpg
    174 kB
    07/Jun/09 7:06 PM

Issue Links

This issue duplicates:
MDL-7782 Better 2 Row Tabs Visualization Major Open

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

Does this still happen with Moodle 1.9.4?

Show
Tim Hunt added a comment - Does this still happen with Moodle 1.9.4?
Hide
Permalink
Martin Dougiamas added a comment -

Shamim, as the Farsi translator, is it possible you can check and resolve this? Thank you!

Show
Martin Dougiamas added a comment - Shamim, as the Farsi translator, is it possible you can check and resolve this? Thank you!
Hide
Permalink
Shamim Rezaie added a comment -

Sure, I'll check it.

Show
Shamim Rezaie added a comment - Sure, I'll check it.
Hide
Permalink
Tal Daniel added a comment -

In 1.9+ versions of Moodle, the above mentioned problem is almost resolved:
The links are pressable by users of IE6; There are still problems of submenu alignment though, which causes a messy look and feel, which sometimes obscures parts of the form below the menu.

Show
Tal Daniel added a comment - In 1.9+ versions of Moodle, the above mentioned problem is almost resolved: The links are pressable by users of IE6; There are still problems of submenu alignment though, which causes a messy look and feel, which sometimes obscures parts of the form below the menu.
Hide
Permalink
Shamim Rezaie added a comment - - edited

Tal,

Would you please replace the attached rtl.css with the one in your /theme/strandard direcory and let me know if the issue has been resolved?

Shamim

Show
Shamim Rezaie added a comment - - edited Tal, Would you please replace the attached rtl.css with the one in your /theme/strandard direcory and let me know if the issue has been resolved? Shamim
Hide
Permalink
Tal Daniel added a comment -

Shamim, thank you for dealing with this issue, but I cannot help you immediatly, since we no longer have version 1.8+ installed (upgraded to 1.9). The RTL handling looks much better in 1.9+.

Show
Tal Daniel added a comment - Shamim, thank you for dealing with this issue, but I cannot help you immediatly, since we no longer have version 1.8+ installed (upgraded to 1.9). The RTL handling looks much better in 1.9+.
Hide
Permalink
Shamim Rezaie added a comment -

I attached 2 images demonstrating what is displayed in IE and FF using the old and the new rtl.css file in Moodle 1.9.

As you can see there would be a significant improvement using the new file - especially in FireFox.

Show
Shamim Rezaie added a comment - I attached 2 images demonstrating what is displayed in IE and FF using the old and the new rtl.css file in Moodle 1.9. As you can see there would be a significant improvement using the new file - especially in FireFox.
Hide
Permalink
Shamim Rezaie added a comment -

I made a minor change to the file to make it compatible with IE6 also

Show
Shamim Rezaie added a comment - I made a minor change to the file to make it compatible with IE6 also
Hide
Permalink
Shamim Rezaie added a comment -

Tested on IE 6, IE 7, Firefox, Safari, Opera

Show
Shamim Rezaie added a comment - Tested on IE 6, IE 7, Firefox, Safari, Opera
Hide
Permalink
Shamim Rezaie added a comment -

Applied in CVS

Show
Shamim Rezaie added a comment - Applied in CVS
Hide
Permalink
Tal Daniel added a comment -

Thank you for finding this issue still relevant to take care of.

Show
Tal Daniel added a comment - Thank you for finding this issue still relevant to take care of.
Hide
Permalink
Amir Elion added a comment -

There are still problems with this.
This is using the patch you added here on stadard theme.
Using the current release of 1.9.5+ I have other RTL Tabs probelms when editting Lesson activity or Face-to-Face for example.

Show
Amir Elion added a comment - There are still problems with this. This is using the patch you added here on stadard theme. Using the current release of 1.9.5+ I have other RTL Tabs probelms when editting Lesson activity or Face-to-Face for example.
Hide
Permalink
Amir Elion added a comment -

This was resolved by downloading the latest CVS version of the Standard theme RTL stylesheet file.

Show
Amir Elion added a comment - This was resolved by downloading the latest CVS version of the Standard theme RTL stylesheet file.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.