Moodle

Grade category edit form has no hidden or locked elements

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9.5, 2.0
  • Component/s: Gradebook
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE, MOODLE_20_STABLE

Description

The category headers in the grader report have eye-cons and padlocks, but they have no corresponding elements in the edit forms. It is rather puzzling.

I came across this when I decided to try setting a hiddenuntil date for the entire course. The only logical place to do this is in the category edit form. No such luck

Issue Links

Activity

Hide
Petr Škoda (skodak) added a comment -

The icons and forms do a bit different hiding and locking internally. The category itself does not have own lock or hiding flag - only the grade item does and this is the problem. The UI icons on grader report do not display actual state of category, they change the state of all children (course item, items + grades).

Maybe we could use another set of icons there, we might display show/hide all the time there...

Show
Petr Škoda (skodak) added a comment - The icons and forms do a bit different hiding and locking internally. The category itself does not have own lock or hiding flag - only the grade item does and this is the problem. The UI icons on grader report do not display actual state of category, they change the state of all children (course item, items + grades). Maybe we could use another set of icons there, we might display show/hide all the time there...
Hide
Nicolas Connault added a comment -

How would I be able to set a hiddenuntil date for the entire course at once? Is it even possible? Or do I have to enter one manually for each individual grade_item?

Show
Nicolas Connault added a comment - How would I be able to set a hiddenuntil date for the entire course at once? Is it even possible? Or do I have to enter one manually for each individual grade_item?
Hide
Petr Škoda (skodak) added a comment -

Hmm, you can not do it.

I think we need some new locking/hiding labels in category edit form:

something shorter than: Force locking/hiding status on all category children + checkbox + normal locking/hiding fields that would be enabled by it

Show
Petr Škoda (skodak) added a comment - Hmm, you can not do it. I think we need some new locking/hiding labels in category edit form: something shorter than: Force locking/hiding status on all category children + checkbox + normal locking/hiding fields that would be enabled by it
Hide
Nicolas Connault added a comment -

This is actually addressed by the 1.9.5 gradebook patch (MDL-18083).

Show
Nicolas Connault added a comment - This is actually addressed by the 1.9.5 gradebook patch (MDL-18083).
Hide
Nicolas Connault added a comment -

Gradebook patch applied, resolving this issue.

Show
Nicolas Connault added a comment - Gradebook patch applied, resolving this issue.
Hide
Sam Hemelryk added a comment -

Confirmed Thanks

Show
Sam Hemelryk added a comment - Confirmed Thanks

People

Vote (1)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: