Issue Details (XML | Word | Printable)

Key: MDL-10791
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

improve handling of floating point numbers in moodle

Created: 10/Aug/07 04:26 PM   Updated: 27/Sep/07 05:59 PM
Return to search
Component/s: General, Gradebook
Affects Version/s: 1.9
Fix Version/s: 1.9

File Attachments: 1. Text File decsep.patch (31 kB)
Issue Links:
Relates
 

Participants: Petr Skoda
Security Level: None
Resolved date: 27/Sep/07
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
we already have format_float and some similar code in grade/

going to post a patch with some more improvements and fixes...

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda made changes - 10/Aug/07 04:33 PM
Field Original Value New Value
Attachment decsep.patch [ 11662 ]
Petr Skoda committed 20 files to 'Moodle CVS' - 10/Aug/07 11:00 PM
MDL-10791 improve handling of localised floating point numbers in moodle; replaced/fixed some float_format() that were used instead of round(); expect some more patches soon
MODIFY lib/mathslib.php   Rev. 1.4    (+25 -0 lines)
MODIFY enrol/paypal/ipn.php   Rev. 1.20    (+2 -2 lines)
MODIFY grade/edit/tree/grade_form.php   Rev. 1.9    (+3 -1 lines)
MODIFY grade/edit/tree/outcomeitem_form.php   Rev. 1.11    (+7 -2 lines)
MODIFY grade/edit/tree/outcomeitem.php   Rev. 1.11    (+37 -11 lines)
MODIFY grade/report/grader/lib.php   Rev. 1.59    (+9 -14 lines)
MODIFY lib/adminlib.php   Rev. 1.147    (+2 -2 lines)
MODIFY grade/edit/tree/grade.php   Rev. 1.11    (+20 -2 lines)
MODIFY enrol/authorize/locallib.php   Rev. 1.54    (+3 -3 lines)
MODIFY enrol/authorize/config_form.php   Rev. 1.4    (+2 -2 lines)
MODIFY enrol/paypal/enrol.php   Rev. 1.27    (+1 -3 lines)
MODIFY mod/lesson/report.php   Rev. 1.37    (+4 -4 lines)
MODIFY grade/report/user/lib.php   Rev. 1.8    (+4 -4 lines)
MODIFY grade/report/lib.php   Rev. 1.21    (+1 -55 lines)
MODIFY lib/moodlelib.php   Rev. 1.918    (+30 -8 lines)
MODIFY grade/edit/tree/item_form.php   Rev. 1.11    (+1 -7 lines)
MODIFY grade/edit/tree/item.php   Rev. 1.10    (+36 -12 lines)
MODIFY lang/en_utf8/langconfig.php   Rev. 1.7    (+3 -3 lines)
MODIFY grade/edit/tree/calculation_form.php   Rev. 1.4    (+3 -2 lines)
MODIFY grade/edit/tree/calculation.php   Rev. 1.6    (+6 -3 lines)
martignoni committed 1 file to 'Lang CVS' - 10/Aug/07 11:13 PM
MDL-10791 improve handling of localised floating point numbers in moodle; replaced/fixed some float_format() that were used instead of round(); expect some more patches soon
MODIFY fr_utf8/langconfig.php   Rev. 1.7    (+3 -3 lines)
Petr Skoda committed 42 files to 'Lang CVS' - 10/Aug/07 11:58 PM
MDL-10791 adding decimal and list separators to lang packs, the list may not be complete - source: wikipedia
MODIFY sl_utf8/langconfig.php   Rev. 1.6    (+3 -1 lines)
MODIFY ca_utf8/langconfig.php   Rev. 1.5    (+2 -0 lines)
MODIFY es_utf8/langconfig.php   Rev. 1.3    (+2 -0 lines)
MODIFY lt_utf8/langconfig.php   Rev. 1.3    (+2 -0 lines)
MODIFY hu_utf8/langconfig.php   Rev. 1.4    (+2 -0 lines)
MODIFY uk_utf8/langconfig.php   Rev. 1.3    (+2 -0 lines)
MODIFY ro_utf8/langconfig.php   Rev. 1.3    (+2 -0 lines)
MODIFY sr_cr_bo_utf8/langconfig.php   Rev. 1.2    (+2 -0 lines)
MODIFY nl_utf8/langconfig.php   Rev. 1.3    (+2 -0 lines)
MODIFY de_du_utf8/langconfig.php   Rev. 1.2    (+17 -0 lines)
MODIFY sq_utf8/langconfig.php   Rev. 1.4    (+2 -0 lines)
MODIFY pl_utf8/langconfig.php   Rev. 1.4    (+3 -1 lines)
MODIFY hr_utf8/langconfig.php   Rev. 1.2    (+2 -0 lines)
MODIFY is_utf8/langconfig.php   Rev. 1.5    (+2 -0 lines)
MODIFY ru_utf8/langconfig.php   Rev. 1.3    (+2 -0 lines)
MODIFY es_es_utf8/langconfig.php   Rev. 1.2    (+13 -1 lines)
MODIFY pt_utf8/langconfig.php   Rev. 1.4    (+2 -0 lines)
MODIFY eu_utf8/langconfig.php   Rev. 1.7    (+1 -1 lines)
MODIFY de_utf8/langconfig.php   Rev. 1.6    (+2 -0 lines)
MODIFY da_utf8/langconfig.php   Rev. 1.5    (+2 -0 lines)
MODIFY lv_utf8/langconfig.php   Rev. 1.4    (+2 -0 lines)
MODIFY fi_utf8/langconfig.php   Rev. 1.6    (+2 -0 lines)
MODIFY sr_cr_utf8/langconfig.php   Rev. 1.7    (+3 -3 lines)
MODIFY el_utf8/langconfig.php   Rev. 1.5    (+2 -0 lines)
MODIFY gl_utf8/langconfig.php   Rev. 1.5    (+2 -0 lines)
MODIFY no_utf8/langconfig.php   Rev. 1.4    (+3 -1 lines)
MODIFY sv_utf8/langconfig.php   Rev. 1.3    (+2 -0 lines)
MODIFY bs_utf8/langconfig.php   Rev. 1.4    (+2 -0 lines)
MODIFY tr_utf8/langconfig.php   Rev. 1.5    (+2 -0 lines)
MODIFY no_gr_utf8/langconfig.php   Rev. 1.2    (+14 -0 lines)
MODIFY cs_utf8/langconfig.php   Rev. 1.8    (+2 -0 lines)
MODIFY vi_utf8/langconfig.php   Rev. 1.4    (+2 -0 lines)
MODIFY et_utf8/langconfig.php   Rev. 1.3    (+3 -1 lines)
MODIFY pt_br_utf8/langconfig.php   Rev. 1.4    (+2 -0 lines)
MODIFY it_utf8/langconfig.php   Rev. 1.5    (+2 -0 lines)
MODIFY sr_lt_utf8/langconfig.php   Rev. 1.4    (+4 -4 lines)
MODIFY id_utf8/langconfig.php   Rev. 1.3    (+2 -0 lines)
MODIFY nn_utf8/langconfig.php   Rev. 1.7    (+2 -0 lines)
MODIFY sk_utf8/langconfig.php   Rev. 1.4    (+2 -0 lines)
MODIFY be_utf8/langconfig.php   Rev. 1.5    (+2 -0 lines)
MODIFY es_ar_utf8/langconfig.php   Rev. 1.3    (+2 -0 lines)
MODIFY bg_utf8/langconfig.php   Rev. 1.4    (+2 -0 lines)
Petr Skoda made changes - 11/Aug/07 12:03 AM
Link This issue has a non-specific relationship to MDL-10385 [ MDL-10385 ]
Petr Skoda committed 1 file to 'Lang CVS' - 11/Aug/07 12:05 AM
MDL-10791 adding decimal and list separators to lang packs
MODIFY ja_utf8/langconfig.php   Rev. 1.10    (+2 -2 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 11/Aug/07 12:06 AM
Majority of language packs should be updated now, working on export/import now

[ Permalink | « Hide ]
Petr Skoda added a comment - 25/Sep/07 12:08 AM
basic solution for grading is in, it will require much more work in 2.0

Petr Skoda made changes - 25/Sep/07 12:08 AM
Fix Version/s 2.0 [ 10122 ]
Fix Version/s 1.9 [ 10190 ]
Petr Skoda committed 1 file to 'Moodle CVS' - 27/Sep/07 05:58 PM
MDL-10791 format_float() now supports non-localised output too (. decimal separator forced)
MODIFY lib/moodlelib.php   Rev. 1.951    (+10 -5 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 27/Sep/07 05:59 PM
implemented in grades and core, module will have to be updated later...

Petr Skoda made changes - 27/Sep/07 05:59 PM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Petr Skoda made changes - 27/Sep/07 05:59 PM
Fix Version/s 1.9 [ 10190 ]
Fix Version/s 2.0 [ 10122 ]

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators