Issue Details (XML | Word | Printable)

Key: MDL-10820
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Petr Skoda
Reporter: Eloy Lafuente (stronk7)
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-10169

Fix double quotes in SQL statements

Created: 12/Aug/07 05:13 PM   Updated: 17/Sep/07 05:48 AM
Return to search
Component/s: Other
Affects Version/s: 1.9
Fix Version/s: 1.9

Database: Any
Participants: Eloy Lafuente (stronk7) and Petr Skoda
Security Level: None
Resolved date: 17/Sep/07
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
I'm getting some SQL erros. The main cause seems to be that some queries use double-quotes to enclose literals.

For example:

ERROR: column "site" does not exist<br /><br />SELECT id,courseid,userid,content,format,created,lastmodified,usermodified,publishstate FROM mdl_post WHERE userid=2 AND publishstate="site" AND module="notes" ORDER BY lastmodified DESC

in the note_list() function.

It would be interesting to fix this and to perform a quick review to detect-and-kill such quoting.

Ciao :-)



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda made changes - 17/Sep/07 05:48 AM
Field Original Value New Value
Assignee Luiz Cruz [ luiz.laydner ] Petr Skoda [ skodak ]
Petr Skoda made changes - 17/Sep/07 05:48 AM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]