Moodle

Upgrading from 1.7 to 1.8, groups->password is lost

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Cannot Reproduce
  • Affects Version/s: 1.8.2
  • Fix Version/s: 1.8.3
  • Component/s: Groups
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE

Description

While examining MDL-10575, I've seen that, in (one of) the migrations between different group structures, there is a moment where the group->password field is transformed to the group->enrolmentkey. But data doesn't seem to be properly copied and old passwords are lost.

Ciao

Issue Links

This issue has a non-specific relationship to:
MDL-10575 (ORA) errors with database upgrading from 1.7(.1) to 1.8(.2) Blocker Closed
MDL-11062 Groups 1.7 => 1.8 upgrade problems Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dan Poltawski added a comment -

From what I recall seeing the groups password used to be md5ed, and is now stored plain text? Which is never really going to upgrade

Show
Dan Poltawski added a comment - From what I recall seeing the groups password used to be md5ed, and is now stored plain text? Which is never really going to upgrade
Hide
Permalink
Petr Škoda (skodak) added a comment -

No, it was always plain text - I am going to commit a patch that is part of the "new" grades in 1.9 today...

Show
Petr Škoda (skodak) added a comment - No, it was always plain text - I am going to commit a patch that is part of the "new" grades in 1.9 today...
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Just a remark... was this committed "today" ? :-P

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Just a remark... was this committed "today" ? :-P Ciao
Hide
Permalink
Petr Škoda (skodak) added a comment -

1.9 does not suffer from this problem, looking at 1.8x code

Show
Petr Škoda (skodak) added a comment - 1.9 does not suffer from this problem, looking at 1.8x code
Hide
Permalink
Petr Škoda (skodak) added a comment -

I can not reproduce the problem during upgrade 1.7.x -> 1.8.x
the code looks ok too

feel free to reopen

Show
Petr Škoda (skodak) added a comment - I can not reproduce the problem during upgrade 1.7.x -> 1.8.x the code looks ok too feel free to reopen
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Uhm... yes... after reviewing groups upgrade code a bit more... I think the root cause for the original bug can be caused by MDL-11062, so this seems to be properly closed. Thanks!

Show
Eloy Lafuente (stronk7) added a comment - Uhm... yes... after reviewing groups upgrade code a bit more... I think the root cause for the original bug can be caused by MDL-11062, so this seems to be properly closed. Thanks!

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.