Issue Details (XML | Word | Printable)

Key: MDL-10870
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Nicolas Connault
Reporter: Martin Dougiamas
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

update all remaining instances of the old navigation bar in core Moodle

Created: 16/Aug/07 10:14 AM   Updated: 18/Aug/07 11:39 AM
Return to search
Component/s: General
Affects Version/s: 1.9
Fix Version/s: 1.9

Participants: Martin Dougiamas and Nicolas Connault
Security Level: None
Resolved date: 18/Aug/07
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
Can you switch to developer debugging mode and cruise around the menus a bit (especially under admin) and fix any other navigation bars that need upgrading? ie so that they pass the correct array of values instead of the string. I noticed quite a few notices around the place yesterday in 1.9 Beta relating to use of the old method.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Martin Dougiamas added a comment - 16/Aug/07 10:14 AM
Nicolas: this is a present for you.

Martin Dougiamas made changes - 16/Aug/07 10:14 AM
Field Original Value New Value
Assignee Martin Dougiamas [ dougiamas ] Nicolas Connault [ nicolasconnault ]
Nicolas Connault committed 12 files to 'Moodle CVS' - 16/Aug/07 11:01 PM
MDL-10870 All files updated to new build_navigation() method.
MODIFY course/edit.php   Rev. 1.107    (+25 -12 lines)
MODIFY mod/resource/index.php   Rev. 1.26    (+6 -10 lines)
MODIFY admin/roles/tabs.php   Rev. 1.24    (+46 -16 lines)
MODIFY lib/moodlelib.php   Rev. 1.922    (+26 -14 lines)
MODIFY admin/Attic/pagelib.php   Rev. 1.23    (+18 -13 lines)
MODIFY files/index.php   Rev. 1.119    (+19 -13 lines)
MODIFY mod/data/edit.php   Rev. 1.30    (+5 -6 lines)
MODIFY blog/preferences.php   Rev. 1.18    (+4 -3 lines)
MODIFY mod/lams/Attic/mod.html   Rev. 1.9    (+8 -5 lines)
MODIFY calendar/preferences.php   Rev. 1.18    (+8 -7 lines)
MODIFY admin/lang.php   Rev. 1.102    (+1 -3 lines)
MODIFY blocks/rss_client/Attic/block_rss_client_action.php   Rev. 1.54    (+8 -9 lines)
[ Permalink | « Hide ]
Nicolas Connault added a comment - 16/Aug/07 11:03 PM
All done except the lams module, which is such a mess that I thought it should be cleaned up first.

Nicolas Connault made changes - 16/Aug/07 11:03 PM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Nicolas Connault committed 1 file to 'Moodle CVS' - 17/Aug/07 12:53 AM
MDL-10870 A few more fixes to the file.php page's navigation
MODIFY files/index.php   Rev. 1.120    (+16 -3 lines)
Nicolas Connault committed 1 file to 'Moodle CVS' - 17/Aug/07 12:29 PM
MDL-10870 Missed an instance of old nav in login/index.php
MODIFY login/index.php   Rev. 1.127    (+27 -25 lines)
Nicolas Connault committed 1 file to 'Moodle CVS' - 17/Aug/07 01:19 PM
MDL-10870 Missed an instance of old nav in admin/lang.php
MODIFY admin/lang.php   Rev. 1.103    (+3 -3 lines)
Nicolas Connault committed 14 files to 'Moodle CVS' - 17/Aug/07 03:25 PM
MDL-10870 All files updated to new build_navigation() method.
MODIFY admin/dbperformance.php   Rev. 1.9    (+5 -3 lines)
MODIFY admin/roles/tabs.php   Rev. 1.26    (+5 -2 lines)
MODIFY lib/weblib.php   Rev. 1.927    (+16 -16 lines)
MODIFY mod/assignment/lib.php   Rev. 1.260    (+5 -5 lines)
MODIFY lib/adminlib.php   Rev. 1.148    (+9 -6 lines)
MODIFY admin/Attic/stickyblocks.php   Rev. 1.17    (+18 -14 lines)
MODIFY lang/en_utf8/mnet.php   Rev. 1.20    (+7 -6 lines)
MODIFY admin/register.php   Rev. 1.25    (+13 -11 lines)
MODIFY admin/timezone.php   Rev. 1.8    (+2 -2 lines)
MODIFY admin/index.php   Rev. 1.280    (+19 -13 lines)
MODIFY mod/resource/Attic/config.html   Rev. 1.20    (+1 -1 lines)
MODIFY admin/roles/assign.php   Rev. 1.55    (+17 -11 lines)
MODIFY admin/mnet/delete.html   Rev. 1.5    (+6 -3 lines)
MODIFY admin/roles/override.php   Rev. 1.34    (+14 -10 lines)
Nicolas Connault committed 23 files to 'Moodle CVS' - 17/Aug/07 07:18 PM
MDL-10870 All files updated to new build_navigation() method.
MODIFY calendar/export_basic.html   Rev. 1.6    (+5 -5 lines)
MODIFY backup/log.php   Rev. 1.14    (+20 -14 lines)
MODIFY blog/Attic/header.php   Rev. 1.38    (+77 -27 lines)
MODIFY admin/xmldb/actions/edit_table_save/edit_table_save.class.php   Rev. 1.6    (+6 -4 lines)
MODIFY backup/restore.php   Rev. 1.43    (+22 -16 lines)
MODIFY auth/cas/auth.php   Rev. 1.17    (+23 -19 lines)
MODIFY calendar/event.php   Rev. 1.71    (+19 -18 lines)
MODIFY calendar/lib.php   Rev. 1.197    (+42 -36 lines)
MODIFY backup/backup.php   Rev. 1.46    (+17 -9 lines)
MODIFY admin/xmldb/actions/edit_index_save/edit_index_save.class.php   Rev. 1.4    (+6 -4 lines)
MODIFY admin/xmldb/actions/edit_sentence_save/edit_sentence_save.class.php   Rev. 1.4    (+6 -4 lines)
MODIFY course/delete.php   Rev. 1.29    (+20 -16 lines)
MODIFY calendar/export.php   Rev. 1.6    (+10 -3 lines)
MODIFY course/category.php   Rev. 1.112    (+35 -32 lines)
MODIFY admin/xmldb/actions/edit_key_save/edit_key_save.class.php   Rev. 1.4    (+7 -4 lines)
MODIFY calendar/Attic/event_select.html   Rev. 1.9    (+55 -33 lines)
MODIFY blog/edit_form.php   Rev. 1.5    (+4 -2 lines)
MODIFY auth/email/auth.php   Rev. 1.11    (+5 -1 lines)
MODIFY auth/ldap/auth.php   Rev. 1.23    (+20 -16 lines)
MODIFY blog/edit.php   Rev. 1.45    (+10 -7 lines)
MODIFY admin/xmldb/actions/edit_field_save/edit_field_save.class.php   Rev. 1.4    (+8 -5 lines)
MODIFY backup/lib.php   Rev. 1.87    (+7 -3 lines)
MODIFY calendar/view.php   Rev. 1.93    (+12 -8 lines)
[ Permalink | « Hide ]
Nicolas Connault added a comment - 17/Aug/07 07:19 PM
There is a lot more to do there than I thought. See the version system tab for details.

Nicolas Connault made changes - 17/Aug/07 07:19 PM
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Nicolas Connault committed 59 files to 'Moodle CVS' - 18/Aug/07 03:09 AM
MDL-10870 All files updated to new build_navigation() method. Most are untested, because they are not easily accessible within a moodle site.
MODIFY user/view.php   Rev. 1.164    (+43 -43 lines)
MODIFY login/change_password.php   Rev. 1.62    (+16 -16 lines)
MODIFY userpix/index.php   Rev. 1.9    (+7 -7 lines)
MODIFY group/assign.php   Rev. 1.15    (+8 -6 lines)
MODIFY lib/moodlelib.php   Rev. 1.924    (+5 -3 lines)
MODIFY course/index.php   Rev. 1.80    (+32 -31 lines)
MODIFY user/groupaddnote.php   Rev. 1.3    (+92 -94 lines)
MODIFY mod/glossary/showentry.php   Rev. 1.40    (+8 -13 lines)
MODIFY course/import.php   Rev. 1.14    (+5 -3 lines)
MODIFY lib/adminlib.php   Rev. 1.149    (+11 -6 lines)
MODIFY course/editsection.php   Rev. 1.25    (+4 -4 lines)
MODIFY user/groupextendenrol.php   Rev. 1.3    (+12 -15 lines)
MODIFY user/edit.php   Rev. 1.165    (+14 -15 lines)
MODIFY course/pending.php   Rev. 1.11    (+6 -6 lines)
MODIFY search/stats.php   Rev. 1.11    (+24 -21 lines)
MODIFY course/import/groups/index.php   Rev. 1.13    (+32 -26 lines)
MODIFY course/import/activities/index.php   Rev. 1.9    (+16 -9 lines)
MODIFY user/addnote.php   Rev. 1.3    (+87 -89 lines)
MODIFY mod/lams/Attic/view.php   Rev. 1.9    (+7 -4 lines)
MODIFY course/report/log/index.php   Rev. 1.18    (+20 -17 lines)
MODIFY course/mod.php   Rev. 1.125    (+5 -5 lines)
MODIFY lib/blocklib.php   Rev. 1.128    (+13 -9 lines)
MODIFY login/mnet_email.php   Rev. 1.4    (+2 -1 lines)
MODIFY mod/resource/type/text/Attic/resource.class.php   Rev. 1.37    (+6 -3 lines)
MODIFY search/query.php   Rev. 1.15    (+58 -56 lines)
MODIFY course/report/participation/index.php   Rev. 1.20    (+36 -40 lines)
MODIFY enrol/imsenterprise/importnow.php   Rev. 1.6    (+8 -5 lines)
MODIFY user/messageselect.php   Rev. 1.15    (+8 -3 lines)
MODIFY course/search.php   Rev. 1.46    (+24 -20 lines)
MODIFY lib/Attic/locallib.php   Rev. 1.10    (+35 -34 lines)
MODIFY enrol/authorize/enrol.php   Rev. 1.135    (+7 -4 lines)
MODIFY course/reset.php   Rev. 1.6    (+17 -14 lines)
MODIFY course/recent.php   Rev. 1.32    (+9 -18 lines)
MODIFY login/confirm.php   Rev. 1.29    (+3 -3 lines)
MODIFY mod/hotpot/view.php   Rev. 1.37    (+14 -17 lines)
MODIFY course/report/outline/index.php   Rev. 1.12    (+8 -6 lines)
MODIFY enrol/authorize/index.php   Rev. 1.40    (+6 -2 lines)
MODIFY enrol/authorize/uploadcsv.php   Rev. 1.12    (+6 -2 lines)
MODIFY userpix/upgrade.php   Rev. 1.5    (+7 -7 lines)
MODIFY course/loginas.php   Rev. 1.46    (+5 -4 lines)
MODIFY enrol/paypal/enrol.php   Rev. 1.28    (+6 -3 lines)
MODIFY course/user.php   Rev. 1.71    (+24 -24 lines)
MODIFY course/enrol.php   Rev. 1.50    (+10 -10 lines)
MODIFY course/report/stats/index.php   Rev. 1.14    (+14 -14 lines)
MODIFY enrol/manual/enrol.php   Rev. 1.23    (+28 -23 lines)
MODIFY login/signup.php   Rev. 1.56    (+8 -3 lines)
MODIFY course/report.php   Rev. 1.6    (+6 -4 lines)
MODIFY theme/preview.php   Rev. 1.6    (+6 -2 lines)
MODIFY user/policy.php   Rev. 1.13    (+2 -2 lines)
MODIFY login/forgot_password.php   Rev. 1.44    (+10 -13 lines)
MODIFY user/extendenrol.php   Rev. 1.12    (+12 -15 lines)
MODIFY user/editadvanced.php   Rev. 1.20    (+13 -14 lines)
MODIFY course/request.php   Rev. 1.14    (+6 -2 lines)
MODIFY group/members.php   Rev. 1.2    (+8 -6 lines)
MODIFY user/index.php   Rev. 1.183    (+27 -30 lines)
MODIFY mod/resource/type/ims/Attic/resource.class.php   Rev. 1.42    (+10 -6 lines)
MODIFY course/unenrol.php   Rev. 1.27    (+10 -8 lines)
MODIFY course/importstudents.php   Rev. 1.24    (+2 -3 lines)
MODIFY mod/resource/type/repository/Attic/resource.class.php   Rev. 1.21    (+14 -8 lines)
[ Permalink | « Hide ]
Nicolas Connault added a comment - 18/Aug/07 11:39 AM
Phew! I think (or hope) I got them all! 111 files in total, and what a repetitive job it was...

Nicolas Connault made changes - 18/Aug/07 11:39 AM
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Mitsuhiro Yoshida committed 3 files to 'Lang CVS' - 19/Aug/07 01:46 PM
Translated new strings for flickr and youtube to tags MDL-10169.
Translated a new string for mnet MDL-10870.
MODIFY ja_utf8/block_tag_youtube.php   Rev. 1.2    (+2 -1 lines)
MODIFY ja_utf8/block_tag_flickr.php   Rev. 1.2    (+3 -1 lines)
MODIFY ja_utf8/mnet.php   Rev. 1.35    (+3 -2 lines)
martignoni committed 1 file to 'Lang CVS' - 20/Aug/07 09:01 PM
MDL-10870 All files updated to new build_navigation() method.
MODIFY fr_utf8/mnet.php   Rev. 1.23    (+2 -1 lines)
Nicolas Connault committed 2 files to 'Moodle CVS' - 23/Aug/07 10:58 PM
MDL-10870 A few more files with old style navigation strings.
MODIFY course/search.php   Rev. 1.47    (+7 -3 lines)
MODIFY blog/lib.php   Rev. 1.71    (+30 -30 lines)
Nicolas Connault committed 1 file to 'Moodle CVS' - 23/Aug/07 11:08 PM
MDL-10910 Corrected two errors committed while fixing MDL-10870
MODIFY course/index.php   Rev. 1.82    (+8 -5 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators