Issue Details (XML | Word | Printable)

Key: MDL-10883
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Koen Roggemans
Reporter: David Mudrak
Votes: 0
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Remove 3rd party modules langpacks from en_utf8

Created: 17/Aug/07 04:15 AM   Updated: 31/Aug/07 05:52 PM
Return to search
Component/s: Languages
Affects Version/s: 1.8.2, 1.8.3, 1.9
Fix Version/s: 1.9

Issue Links:
Cloners
 

Participants: David Mudrak, Koen Roggemans, Martin Dougiamas and Nicolas Martignoni
Security Level: None
QA Assignee: Nicolas Martignoni
Resolved date: 30/Aug/07
Affected Branches: MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
There are still some files in lang/en_utf8 that belongs to a 3rd party module and, therefore, should be part of the module lang dir, not the core one. This might be a little bit confusing for translators as they should focus on the standard language pack first and then continue with optional 3rd party modules.

This was already discussed in MDL-4395.

I have found:

* attendance.php
* dialogue.php
* simpletest.php (???)


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Koen Roggemans added a comment - 17/Aug/07 05:17 AM
journal.php (can this go or not?)
webquest.php (is this ever been used at all?)

Martin Dougiamas added a comment - 21/Aug/07 01:26 PM
Keep dialogue and journal but all the rest can go

Koen Roggemans added a comment - 23/Aug/07 04:25 AM
from the previous bug MDL-4395 about this I also found
appointment.php: appointment doesn't work in 1.7 and onwards and not in 1.5 and onwards without the mentioned fixes in the forum - think that can go out

exercise.php:
I notice that exercise is still in HEAD, although disabled by default. So that should stay

questionnaire.php: file is extremely outdated - strings should be pulled out the mod/questionnaire/lang folder


Nicolas Martignoni added a comment - 24/Aug/07 04:36 PM
Suggesting re-introduction of simpletest.php, as it is called from these files (at least) :
  • admin/report/simpletest/ex_reporter.php (see line 193)
  • admin/report/simpletest/index.php (see line 25)

Koen Roggemans added a comment - 24/Aug/07 05:04 PM
Arch - I checked moodle/grade/simpletest

I did a cvs update -r 1.2 simpletest.php to get it back in

Thanks for your head up as ever!


Koen Roggemans added a comment - 30/Aug/07 04:20 AM
This should be it

Nicolas Martignoni added a comment - 30/Aug/07 02:30 PM
Hi Koen,
The simpletest.php file you committed is empty.

Koen Roggemans added a comment - 31/Aug/07 04:21 AM
this is getting ridiculous.
Should be ok now

Nicolas Martignoni added a comment - 31/Aug/07 05:52 PM
Yes it's OK now
Closing