Issue Details (XML | Word | Printable)

Key: MDL-10883
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Koen Roggemans
Reporter: David Mudrak
Votes: 0
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Remove 3rd party modules langpacks from en_utf8

Created: 17/Aug/07 04:15 AM   Updated: 31/Aug/07 05:52 PM
Return to search
Component/s: Languages
Affects Version/s: 1.8.2, 1.8.3, 1.9
Fix Version/s: 1.9

Issue Links:
Cloners
 

Participants: David Mudrak, Koen Roggemans, Martin Dougiamas and Nicolas Martignoni
Security Level: None
QA Assignee: Nicolas Martignoni
Resolved date: 30/Aug/07
Affected Branches: MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
There are still some files in lang/en_utf8 that belongs to a 3rd party module and, therefore, should be part of the module lang dir, not the core one. This might be a little bit confusing for translators as they should focus on the standard language pack first and then continue with optional 3rd party modules.

This was already discussed in MDL-4395.

I have found:

* attendance.php
* dialogue.php
* simpletest.php (???)

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
David Mudrak made changes - 17/Aug/07 04:15 AM
Field Original Value New Value
Link This issue is a clone of MDL-4395 [ MDL-4395 ]
[ Permalink | « Hide ]
Koen Roggemans added a comment - 17/Aug/07 05:17 AM
journal.php (can this go or not?)
webquest.php (is this ever been used at all?)

[ Permalink | « Hide ]
Martin Dougiamas added a comment - 21/Aug/07 01:26 PM
Keep dialogue and journal but all the rest can go

[ Permalink | « Hide ]
Koen Roggemans added a comment - 23/Aug/07 04:25 AM
from the previous bug MDL-4395 about this I also found
appointment.php: appointment doesn't work in 1.7 and onwards and not in 1.5 and onwards without the mentioned fixes in the forum - think that can go out

exercise.php:
I notice that exercise is still in HEAD, although disabled by default. So that should stay

questionnaire.php: file is extremely outdated - strings should be pulled out the mod/questionnaire/lang folder


koenr committed 5 files to 'Moodle CVS' - 23/Aug/07 04:32 AM
MDL-10883 - removing 3th party modules strings and never used strings
DEL lang/en_utf8/Attic/webquest.php   Rev. 1.3    (+0 -0 lines)
DEL lang/en_utf8/simpletest.php   Rev. 1.3    (+0 -0 lines)
DEL lang/en_utf8/Attic/attendance.php   Rev. 1.3    (+0 -0 lines)
DEL lang/en_utf8/Attic/questionnaire.php   Rev. 1.4    (+0 -0 lines)
DEL lang/en_utf8/Attic/appointment.php   Rev. 1.3    (+0 -0 lines)
Koen Roggemans made changes - 23/Aug/07 04:33 AM
Fix Version/s 1.9 [ 10190 ]
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
koenr committed 5 files to 'Lang CVS' - 23/Aug/07 04:38 AM
MDL-10883 - removing 3th party modules strings and never used strings
DEL nl_utf8/Attic/attendance.php   Rev. 1.2    (+0 -0 lines)
DEL nl_utf8/Attic/questionnaire.php   Rev. 1.2    (+0 -0 lines)
DEL nl_utf8/simpletest.php   Rev. 1.2    (+0 -0 lines)
DEL nl_utf8/Attic/appointment.php   Rev. 1.2    (+0 -0 lines)
DEL nl_utf8/Attic/webquest.php   Rev. 1.2    (+0 -0 lines)
koenr committed 12 files to 'Moodle CVS' - 23/Aug/07 04:42 AM
MDL-10883 - removing 3th party modules strings and never used strings
DEL lang/en_utf8/help/questionnaire/Attic/qmanage.html   Rev. 1.3    (+0 -0 lines)
DEL lang/en_utf8/help/questionnaire/Attic/respondenttype.html   Rev. 1.3    (+0 -0 lines)
DEL lang/en_utf8/help/questionnaire/Attic/questionnaireid.html   Rev. 1.3    (+0 -0 lines)
DEL lang/en_utf8/help/attendance/Attic/mods.html   Rev. 1.2    (+0 -0 lines)
DEL lang/en_utf8/help/attendance/Attic/maxgrade.html   Rev. 1.3    (+0 -0 lines)
DEL lang/en_utf8/help/questionnaire/Attic/qtype.html   Rev. 1.3    (+0 -0 lines)
DEL lang/en_utf8/help/attendance/Attic/hours.html   Rev. 1.3    (+0 -0 lines)
DEL lang/en_utf8/help/attendance/Attic/dynsection.html   Rev. 1.3    (+0 -0 lines)
DEL lang/en_utf8/help/attendance/Attic/autoattend.html   Rev. 1.3    (+0 -0 lines)
DEL lang/en_utf8/help/attendance/Attic/grade.html   Rev. 1.3    (+0 -0 lines)
DEL lang/en_utf8/help/attendance/Attic/choosedays.html   Rev. 1.3    (+0 -0 lines)
DEL lang/en_utf8/help/attendance/Attic/index.html   Rev. 1.4    (+0 -0 lines)
koenr committed 8 files to 'Lang CVS' - 23/Aug/07 04:44 AM
MDL-10883 - removing 3th party modules strings and never used strings
DEL nl_utf8/help/attendance/Attic/hours.html   Rev. 1.3    (+0 -0 lines)
DEL nl_utf8/help/attendance/Attic/autoattend.html   Rev. 1.3    (+0 -0 lines)
DEL nl_utf8/help/attendance/Attic/maxgrade.html   Rev. 1.3    (+0 -0 lines)
DEL nl_utf8/help/attendance/Attic/dynsection.html   Rev. 1.4    (+0 -0 lines)
DEL nl_utf8/help/attendance/Attic/index.html   Rev. 1.2    (+0 -0 lines)
DEL nl_utf8/help/attendance/Attic/choosedays.html   Rev. 1.3    (+0 -0 lines)
DEL nl_utf8/help/attendance/Attic/mods.html   Rev. 1.2    (+0 -0 lines)
DEL nl_utf8/help/attendance/Attic/grade.html   Rev. 1.3    (+0 -0 lines)
koenr committed 11 files to 'Lang CVS' - 23/Aug/07 05:10 AM
MDL-10883 - removing 3th party modules strings and never used strings from langpack
DEL nl_utf8/help/questionnaire/Attic/respondenttype.html   Rev. 1.3    (+0 -0 lines)
DEL nl_utf8/help/questionnaire/Attic/respondenteligible.html   Rev. 1.3    (+0 -0 lines)
DEL nl_utf8/help/questionnaire/Attic/createcontent.html   Rev. 1.3    (+0 -0 lines)
DEL nl_utf8/help/questionnaire/Attic/questionnaireid.html   Rev. 1.3    (+0 -0 lines)
DEL nl_utf8/help/questionnaire/Attic/closedate.html   Rev. 1.3    (+0 -0 lines)
DEL nl_utf8/help/questionnaire/Attic/qmanage.html   Rev. 1.2    (+0 -0 lines)
DEL nl_utf8/help/questionnaire/Attic/opendate.html   Rev. 1.3    (+0 -0 lines)
DEL nl_utf8/help/questionnaire/Attic/realm.html   Rev. 1.3    (+0 -0 lines)
DEL nl_utf8/help/questionnaire/Attic/qtype.html   Rev. 1.3    (+0 -0 lines)
DEL nl_utf8/help/questionnaire/Attic/resume.html   Rev. 1.3    (+0 -0 lines)
DEL nl_utf8/help/questionnaire/Attic/mods.html   Rev. 1.2    (+0 -0 lines)
martignoni committed 4 files to 'Lang CVS' - 24/Aug/07 04:27 PM
MDL-10883 - removing 3th party modules strings and never used strings
DEL fr_utf8/Attic/questionnaire.php   Rev. 1.2    (+0 -0 lines)
DEL fr_utf8/Attic/appointment.php   Rev. 1.2    (+0 -0 lines)
DEL fr_utf8/Attic/webquest.php   Rev. 1.2    (+0 -0 lines)
DEL fr_utf8/Attic/attendance.php   Rev. 1.2    (+0 -0 lines)
[ Permalink | « Hide ]
Nicolas Martignoni added a comment - 24/Aug/07 04:36 PM
Suggesting re-introduction of simpletest.php, as it is called from these files (at least) :
  • admin/report/simpletest/ex_reporter.php (see line 193)
  • admin/report/simpletest/index.php (see line 25)

Nicolas Martignoni made changes - 24/Aug/07 04:36 PM
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
martignoni committed 4 files to 'Lang CVS' - 24/Aug/07 04:45 PM
MDL-10883 - removing 3th party modules strings and never used strings
DEL fr_utf8/help/questionnaire/Attic/qmanage.html   Rev. 1.2    (+0 -0 lines)
DEL fr_utf8/help/questionnaire/Attic/questionnaireid.html   Rev. 1.2    (+0 -0 lines)
DEL fr_utf8/help/questionnaire/Attic/respondenttype.html   Rev. 1.2    (+0 -0 lines)
DEL fr_utf8/help/questionnaire/Attic/qtype.html   Rev. 1.2    (+0 -0 lines)
[ Permalink | « Hide ]
Koen Roggemans added a comment - 24/Aug/07 05:04 PM
Arch - I checked moodle/grade/simpletest

I did a cvs update -r 1.2 simpletest.php to get it back in

Thanks for your head up as ever!


koenr committed 1 file to 'Lang CVS' - 30/Aug/07 04:16 AM
reverting partly MDL-10883
ADD nl_utf8/simpletest.php   Rev. 1.3    (+0 -0 lines)
koenr committed 1 file to 'Moodle CVS' - 30/Aug/07 04:20 AM
reverting partly MDL-10883
ADD lang/en_utf8/simpletest.php   Rev. 1.4    (+0 -0 lines)
[ Permalink | « Hide ]
Koen Roggemans added a comment - 30/Aug/07 04:20 AM
This should be it

Koen Roggemans made changes - 30/Aug/07 04:20 AM
Resolution Fixed [ 1 ]
Status Reopened [ 4 ] Resolved [ 5 ]
[ Permalink | « Hide ]
Nicolas Martignoni added a comment - 30/Aug/07 02:30 PM
Hi Koen,
The simpletest.php file you committed is empty.

[ Permalink | « Hide ]
Koen Roggemans added a comment - 31/Aug/07 04:21 AM
this is getting ridiculous.
Should be ok now

[ Permalink | « Hide ]
Nicolas Martignoni added a comment - 31/Aug/07 05:52 PM
Yes it's OK now
Closing

Nicolas Martignoni made changes - 31/Aug/07 05:52 PM
QA Assignee mina
Status Resolved [ 5 ] Closed [ 6 ]
Mitsuhiro Yoshida committed 1 file to 'Lang CVS' - 25/May/08 11:38 PM
Removed translated string file and help fiels for questionnaire MDL-10883.
MODIFY ja_utf8/README   Rev. 1.719    (+1 -1 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators