Issue Details (XML | Word | Printable)

Key: MDL-10920
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Martin Dougiamas
Reporter: David Mudrak
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

mod/data/preset/imagegallery/lang/en_utf8/data.php should be renamed to datapreset_imagegallery.php

Created: 21/Aug/07 07:23 AM   Updated: 16/Nov/07 11:26 PM
Return to search
Component/s: Database activity module
Affects Version/s: 1.8.2
Fix Version/s: 1.8.3, 1.9

Issue Links:
Blockers
 
Duplicate
 
Relates
 

Participants: David Mudrak, Martin Dougiamas and Stephen Bourget
Security Level: None
QA Assignee: Stephen Bourget
Resolved date: 21/Aug/07
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
See MDL-9361 for more info about this

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
David Mudrak made changes - 21/Aug/07 07:25 AM
Field Original Value New Value
Link This issue blocks MDL-9361 [ MDL-9361 ]
moodler committed 2 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 21/Aug/07 11:34 AM
Moved language files for presets MDL-10920
MODIFY mod/data/lib.php   Rev. 1.113.2.7    (+2 -2 lines)
DEL mod/data/preset/imagegallery/lang/en_utf8/Attic/data.php   Rev. 1.1.6.1    (+0 -0 lines)
moodler committed 2 files to 'Moodle CVS' - 21/Aug/07 11:38 AM
FIxed language file location, merged from 1.8 MDL-10920
MODIFY mod/data/lib.php   Rev. 1.135    (+2 -2 lines)
DEL mod/data/preset/imagegallery/lang/en_utf8/Attic/data.php   Rev. 1.2    (+0 -0 lines)
moodler committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 21/Aug/07 11:39 AM
moodler committed 1 file to 'Moodle CVS' - 21/Aug/07 11:40 AM
Merged new file from 1.8 MDL-10920
MODIFY lang/en_utf8/datapreset_imagegallery.php   Rev. 1.2    (+5 -0 lines)
Martin Dougiamas added a comment - 21/Aug/07 11:42 AM
In fact, because it''s in core it should be

moodle/lang/en_utf8/datapreset_imagegallery.php

That was student code that slipped through the review. Core lang files should never be in the module space.

FIXED!


Martin Dougiamas made changes - 21/Aug/07 11:42 AM
Fix Version/s 1.8.3 [ 10230 ]
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
martignoni committed 1 file to 'Lang CVS' - 21/Aug/07 04:33 PM
Moved lang file MDL-10920
ADD fr_utf8/datapreset_imagegallery.php   Rev. 1.1    (+0 -0 lines)
Mitsuhiro Yoshida committed 5 files to 'Lang CVS' - 22/Aug/07 11:49 PM
Translated new strings for admin, error, filters MDL-10181.
Adding a new translated lang file for imagegallery MDL-10920.
MODIFY ja_utf8/error.php   Rev. 1.29    (+3 -1 lines)
MODIFY ja_utf8/filters.php   Rev. 1.2    (+5 -1 lines)
ADD ja_utf8/datapreset_imagegallery.php   Rev. 1.1    (+0 -0 lines)
MODIFY ja_utf8/README   Rev. 1.493    (+1 -1 lines)
MODIFY ja_utf8/admin.php   Rev. 1.194    (+11 -2 lines)
Nicolas Martignoni made changes - 24/Aug/07 05:10 PM
Link This issue has been marked as being related by MDL-10979 [ MDL-10979 ]
Martin Dougiamas made changes - 24/Sep/07 12:29 PM
Link This issue is duplicated by MDL-11405 [ MDL-11405 ]
Stephen Bourget added a comment - 16/Nov/07 11:26 PM
Verified in Moodle 1.8 and 1.9

Closing


Stephen Bourget made changes - 16/Nov/07 11:26 PM
QA Assignee sbourget
Status Resolved [ 5 ] Closed [ 6 ]