Moodle

Should tag order be respected...

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9
  • Component/s: Unknown
  • Labels:
    None
  • Environment:
    Any Moodle >= 1.9
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Hi,

I was playing with the cool tags at moodle.org when I've experienced one annoying (subjective) behavior. Just sharing it here:

When adding tags I wanted to introduce them in order, i.e. if "Education" is more important (for me) than "Macs" I use to write them in that order and want to show my tags (user profle) respecting that order.

But it seems that the order is completely lost, mixing them without apparent order (both when displayed and when re-edited in the profile page).

I really think that a lot of people can find this (subjectively) annoying and they want their original order to be respected.

Just one (simple?) idea.

Ciao

  1. install.xml.patch
    24/Aug/07 5:45 AM
    2 kB
    Luiz Cruz
  2. lib.php.patch
    24/Aug/07 5:45 AM
    4 kB
    Luiz Cruz
  3. upgrade.php.patch
    24/Aug/07 11:08 AM
    0.8 kB
    Luiz Cruz

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Adding Luiz here to know about the idea... Martin decides about it, anyway.

Show
Eloy Lafuente (stronk7) added a comment - Adding Luiz here to know about the idea... Martin decides about it, anyway.
Hide
Luiz Cruz added a comment -

tag\lib.php patch to keep order of tag instances

Show
Luiz Cruz added a comment - tag\lib.php patch to keep order of tag instances
Hide
Luiz Cruz added a comment -

adds ordering field to tag_instance table

Show
Luiz Cruz added a comment - adds ordering field to tag_instance table
Hide
Luiz Cruz added a comment -

I think this is pretty relevant... I created the patches to correct this behavior.

Should I commit this ??

Show
Luiz Cruz added a comment - I think this is pretty relevant... I created the patches to correct this behavior. Should I commit this ??
Hide
Martin Dougiamas added a comment -

Yes, OK. Can you also make a patch for lib/db/upgrade.php to upgrade the table?

Show
Martin Dougiamas added a comment - Yes, OK. Can you also make a patch for lib/db/upgrade.php to upgrade the table?
Hide
Martin Dougiamas added a comment -

Committed - thanks Luiz! Works much better now.

Show
Martin Dougiamas added a comment - Committed - thanks Luiz! Works much better now.
Hide
Helen Foster added a comment -

Closing, as tag order is now respected. Thanks Luiz

Show
Helen Foster added a comment - Closing, as tag order is now respected. Thanks Luiz

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: