Issue Details (XML | Word | Printable)

Key: MDL-10992
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Martin Dougiamas
Reporter: Luiz Cruz
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-13404

limit size of tags

Created: 25/Aug/07 11:57 AM   Updated: 21/Feb/08 01:32 PM
Component/s: Other
Affects Version/s: 1.9
Fix Version/s: None

Participants: Luiz Cruz, Martin Dougiamas and Mathieu Petit-Clair
Security Level: None
Resolved date: 21/Feb/08
Affected Branches: MOODLE_19_STABLE


 Description  « Hide
Maybe it´s a good idea to lower the limit for the size of tags ?? 50 characters max??

Take a look at this:
http://moodle.org/tag/index.php?id=71

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Martin Dougiamas added a comment - 25/Aug/07 11:39 PM
Yes, good idea. Can you make it truncate to 50 (in code only, don't touch db)

Martin Dougiamas added a comment - 25/Aug/07 11:40 PM
Best would be just to ignore and not add any new tags that are over the constant value (ie 50)

Mathieu Petit-Clair added a comment - 12/Feb/08 01:57 PM
del.icio.us has a length limit set to 128 chars. As tags are part of the url (which has a 255 chars limit), I guess this makes sense.

If the length is too long to get a good presentation, maybe these tags should be excluded from the tag cloud, or be abbreviated (in the way internationalization gets abbbreviated to i18n, or by just putting "..." at the end, etc.).

I don't think there should be a hard-coded limit on content for a question of presentation.


Mathieu Petit-Clair added a comment - 21/Feb/08 01:32 PM
We keep the current limit (50). I put a comment in the code not to exceed 85 chars, which could make the tag impossible to store in a varchar(255).