[#MDL-11090] Password in lesson not visible at settings page

Issue Details (XML | Word | Printable)

Key:	MDL-11090
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Major
Assignee:	Howard Miller
Reporter:	Ralf Hilgenstock
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Password in lesson not visible at settings page

Created: 01/Sep/07 02:39 AM Updated: 11/Dec/08 01:07 AM

Component/s:

Lesson

Affects Version/s:

1.6, 1.7, 1.7.1, 1.7.2, 1.8, 1.8.1, 1.8.2, 1.9

Fix Version/s:

1.9.4, 2.0

Participants:	Dan Marsden, Howard Miller, Mark Nielsen, Petr Škoda (skodak), Ralf Hilgenstock and Tim Hunt
Security Level:	None
QA Assignee:	Tim Hunt
Resolved date:	10/Dec/08
Affected Branches:	MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE, MOODLE_20_STABLE

Description

« Hide

A password at lesson settings page is not visible if a teacher opens the settings page later again.

Better solution would be to use a hide/view option and to show that a Password is set by points. Such a function is available for the keyword at course settings page.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Mark Nielsen added a comment - 30/Dec/07 04:46 AM

Big problem here is that the password is hashed in the database, so it cannot be printed in plain text. This turned out to be a bad idea and I'm not sure how to go about resolving it without breaking previous passwords. Any ideas?

[ Permalink | « Hide ]

Howard Miller added a comment - 26/Nov/08 11:36 PM

Password is now visible in lesson versions newer than today (version 2008112600). Compatibility with the old md5 passwords is retained.

[ Permalink | « Hide ]

Dan Marsden added a comment - 28/Nov/08 06:11 PM

Hi Howard,

the version date in HEAD is older than the one in 1.9Stable so this patch breaks upgrades - can you merge these changes into HEAD please?

thanks!

Dan

[ Permalink | « Hide ]

Dan Marsden added a comment - 28/Nov/08 06:12 PM

ah - I see you have merged - just missed the version.php file

[ Permalink | « Hide ]

Petr Škoda (skodak) added a comment - 28/Nov/08 06:14 PM

next time please do NOT use date for version in STABLE branch - use just the last two digits

[ Permalink | « Hide ]

Petr Škoda (skodak) added a comment - 28/Nov/08 06:17 PM

fixed

[ Permalink | « Hide ]

Howard Miller added a comment - 28/Nov/08 06:32 PM - edited

Cool... is that version thing in the developer docs somewhere? I didn't know. Coding guidelines?

EDIT.... mind you. It's kind of obvious when you think about it for a couple of minutes :-D

[ Permalink | « Hide ]

Tim Hunt added a comment - 09/Dec/08 03:03 PM

Howard, I think you need to trim() the $userpassword in the non-md5 case too.

[ Permalink | « Hide ]

Howard Miller added a comment - 10/Dec/08 06:40 PM

trim added... thanks for spotting that, Tim

[ Permalink | « Hide ]

Tim Hunt added a comment - 11/Dec/08 01:07 AM

Thanks Howard.

All content on this web site is made available under the GNU General Public License, unless otherwise stated.