|
|
| Participants: |
Nick Freear
|
| Security Level: |
None
|
| Resolved date: |
05/Sep/07
|
| Affected Branches: |
MOODLE_18_STABLE
|
| Fixed Branches: |
MOODLE_18_STABLE, MOODLE_19_STABLE
|
|
Nick 22 Aug, "" I discovered a while ago that help links in forms are created between the </label> and the form control, NOT at the end of the <label> element as I expected.
a) Currently Moodle has: <label for="x">Label</label> <a href="...">Help link</a> <input type="text" id="x" />
b) I think this order is preferable, to ensure that the link is accessible from forms mode - does this make sense?
<label for="x">Label <a href="...">Help link</a> </label> <input type="text" id="x" />
""
Chetz after testing, "The link within the label read perfectly in JAWS, whereas the link outside the label was ignored in forms mode."
--
The attached patch modifies the MoodleQuickForm_Renderer::_elementTemplates array in 'lib/formslib.php'.
There don't appear to be any styling issues around this, so I will apply this immediately.
|
|
Description
|
Nick 22 Aug, "" I discovered a while ago that help links in forms are created between the </label> and the form control, NOT at the end of the <label> element as I expected.
a) Currently Moodle has: <label for="x">Label</label> <a href="...">Help link</a> <input type="text" id="x" />
b) I think this order is preferable, to ensure that the link is accessible from forms mode - does this make sense?
<label for="x">Label <a href="...">Help link</a> </label> <input type="text" id="x" />
""
Chetz after testing, "The link within the label read perfectly in JAWS, whereas the link outside the label was ignored in forms mode."
--
The attached patch modifies the MoodleQuickForm_Renderer::_elementTemplates array in 'lib/formslib.php'.
There don't appear to be any styling issues around this, so I will apply this immediately. |
Show » |
committed 1 file to 'Moodle CVS' - 05/Sep/07 10:34 PM
MDL-11134, Accessibility: move help link into <label>, so it won't be ignored in JAWS forms mode.
|
|
|
committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 05/Sep/07 10:38 PM
MDL-11134, Accessibility: move help link into <label>, so it won't be ignored in JAWS forms mode. Merged.
|
|
|
made changes - 05/Sep/07 10:44 PM
| Field |
Original Value |
New Value |
|
Status
|
Open
[ 1
]
|
Resolved
[ 5
]
|
|
Fix Version/s
|
|
1.8.3
[ 10230
]
|
|
Resolution
|
|
Fixed
[ 1
]
|
|
Fix Version/s
|
|
1.9
[ 10190
]
|
made changes - 21/Nov/07 07:55 PM
|
Issue Type
|
Bug
[ 1
]
|
Sub-task
[ 5
]
|
|
Parent
|
|
MDL-12298
[ 23539
]
|
|
I've committed the patch to HEAD and 1.8 branch, tagged as _MERGED - fixed.