Issue Details (XML | Word | Printable)

Key: MDL-11134
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Nick Freear
Reporter: Nick Freear
Votes: 0
Watchers: 3
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-12298

Help links in forms are outside the <label> - they will be ignored in JAWS forms mode

Created: 05/Sep/07 10:05 PM   Updated: 21/Nov/07 07:55 PM
Return to search
Component/s: Accessibility, Forms Library
Affects Version/s: 1.8, 1.8.1, 1.8.2
Fix Version/s: 1.8.3, 1.9

File Attachments: 1. File patch-access-form-help-pos-2.diff (3 kB)

Environment:
JAWS and other screen readers have a 'forms mode' for inputting data in forms on the Web. In this mode, where there are <label> elements explicitly linked to form elements ONLY the fieldset-legends, labels and the form controls themselves are verbalised.
See, http://docs.moodle.org/en/Development:Accessibility_notes#What_JAWS_says

Participants: Nick Freear
Security Level: None
Resolved date: 05/Sep/07
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
Nick 22 Aug, "" I discovered a while ago that help links in forms are created between the </label> and the form control, NOT at the end of the <label> element as I expected.
a) Currently Moodle has: <label for="x">Label</label> <a href="...">Help link</a> <input type="text" id="x" />

b) I think this order is preferable, to ensure that the link is accessible from forms mode - does this make sense?
<label for="x">Label <a href="...">Help link</a> </label> <input type="text" id="x" />
""
Chetz after testing, "The link within the label read perfectly in JAWS, whereas the link outside the label was ignored in forms mode."
--

The attached patch modifies the MoodleQuickForm_Renderer::_elementTemplates array in 'lib/formslib.php'.
There don't appear to be any styling issues around this, so I will apply this immediately.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Nick Freear committed 1 file to 'Moodle CVS' - 05/Sep/07 10:34 PM
MDL-11134, Accessibility: move help link into <label>, so it won't be ignored in JAWS forms mode.
MODIFY lib/formslib.php   Rev. 1.124    (+5 -5 lines)
Nick Freear committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 05/Sep/07 10:38 PM
MDL-11134, Accessibility: move help link into <label>, so it won't be ignored in JAWS forms mode. Merged.
MODIFY lib/formslib.php   Rev. 1.96.2.9    (+5 -5 lines)
Nick Freear added a comment - 05/Sep/07 10:44 PM
(Jamie, I added you as a watcher as it's mostly your work.)

I've committed the patch to HEAD and 1.8 branch, tagged as _MERGED - fixed.


Nick Freear made changes - 05/Sep/07 10:44 PM
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 1.8.3 [ 10230 ]
Resolution Fixed [ 1 ]
Fix Version/s 1.9 [ 10190 ]
Nick Freear made changes - 21/Nov/07 07:55 PM
Issue Type Bug [ 1 ] Sub-task [ 5 ]
Parent MDL-12298 [ 23539 ]