Moodle

Enrolment data discarded during upgrade

Details

  • Affected Branches:
    MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE

Description

When upgrading from 1.6.x, new role assignments are given default values rather than retaining those stored in user_students and user_teachers. This appears to be the only place Internal Enrolment keeps a user's enrolment date and method.

Attached is a patch which retains enrolment dates and methods during upgrade.

Issue Links

This issue will help resolve:
MDL-14395 Upgrading to roles loses timestart and timeend from user_students and user_teacher tables Critical Closed
This issue has a non-specific relationship to:
MDL-10502 Manually assigning a role in a course does not record timestart and timeend values for courses with enrollment durations Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Chris Bandy added a comment -

Updated patch against HEAD (accesslib.php 1.441)

Show
Chris Bandy added a comment - Updated patch against HEAD (accesslib.php 1.441)
Hide
Permalink
Chris Bandy added a comment -

Updating affected versions.

Show
Chris Bandy added a comment - Updating affected versions.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Assigning to Petr, for your consideration.

Thanks for the report Chris (I've deleted the requested subtask).

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Assigning to Petr, for your consideration. Thanks for the report Chris (I've deleted the requested subtask). Ciao
Hide
Permalink
Petr Škoda (skodak) added a comment -

MD was working on this, right?

Show
Petr Škoda (skodak) added a comment - MD was working on this, right?
Hide
Permalink
N Hansen added a comment -

Wish I had had this yesterday when I upgraded and lost all this info!!!!

Show
N Hansen added a comment - Wish I had had this yesterday when I upgraded and lost all this info!!!!
Hide
Permalink
N Hansen added a comment -

May I ask why such a serious bug with a patch offered wasn't taken care of months ago?

Show
N Hansen added a comment - May I ask why such a serious bug with a patch offered wasn't taken care of months ago?
Hide
Permalink
Martin Dougiamas added a comment - - edited

Somehow I never saw this one before(it was flagged as minor). Thanks, Chris, I'll patch everything today.

Show
Martin Dougiamas added a comment - - edited Somehow I never saw this one before(it was flagged as minor). Thanks, Chris, I'll patch everything today.
Hide
Permalink
Martin Dougiamas added a comment -

Patched in CVS

Show
Martin Dougiamas added a comment - Patched in CVS
Hide
Permalink
Petr Škoda (skodak) added a comment -

reviewed, closing

Show
Petr Škoda (skodak) added a comment - reviewed, closing

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.