Issue Details (XML | Word | Printable)

Key: MDL-11142
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Martin Dougiamas
Reporter: Chris Bandy
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Enrolment data discarded during upgrade

Created: 06/Sep/07 02:30 PM   Updated: 22/Apr/08 03:56 PM
Return to search
Component/s: Enrolments, Roles
Affects Version/s: 1.7.4, 1.8.5, 1.9
Fix Version/s: 1.7.5, 1.8.6, 1.9.1

File Attachments: 1. Text File accesslib.php.patch (2 kB)

Issue Links:
Dependency
 
Relates
 

Participants: Chris Bandy, Eloy Lafuente (stronk7), Martin Dougiamas, N Hansen and Petr Skoda
Security Level: None
QA Assignee: Petr Skoda
Resolved date: 18/Apr/08
Affected Branches: MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches: MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
When upgrading from 1.6.x, new role assignments are given default values rather than retaining those stored in user_students and user_teachers. This appears to be the only place Internal Enrolment keeps a user's enrolment date and method.

Attached is a patch which retains enrolment dates and methods during upgrade.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Chris Bandy added a comment - 16/Apr/08 01:58 AM
Updated patch against HEAD (accesslib.php 1.441)

Chris Bandy added a comment - 16/Apr/08 02:02 AM
Updating affected versions.

Eloy Lafuente (stronk7) added a comment - 16/Apr/08 09:16 AM
Assigning to Petr, for your consideration.

Thanks for the report Chris (I've deleted the requested subtask).

Ciao


Petr Skoda added a comment - 16/Apr/08 03:04 PM
MD was working on this, right?

N Hansen added a comment - 18/Apr/08 09:01 AM
Wish I had had this yesterday when I upgraded and lost all this info!!!!

N Hansen added a comment - 18/Apr/08 09:02 AM
May I ask why such a serious bug with a patch offered wasn't taken care of months ago?

Martin Dougiamas added a comment - 18/Apr/08 11:11 AM - edited
Somehow I never saw this one before(it was flagged as minor). Thanks, Chris, I'll patch everything today.

Martin Dougiamas added a comment - 18/Apr/08 11:35 AM
Patched in CVS

Petr Skoda added a comment - 22/Apr/08 03:56 PM
reviewed, closing