Issue Details (XML | Word | Printable)

Key: MDL-11142
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Martin Dougiamas
Reporter: Chris Bandy
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Enrolment data discarded during upgrade

Created: 06/Sep/07 02:30 PM   Updated: 22/Apr/08 03:56 PM
Return to search
Component/s: Enrolments, Roles
Affects Version/s: 1.7.4, 1.8.5, 1.9
Fix Version/s: 1.7.5, 1.8.6, 1.9.1

File Attachments: 1. Text File accesslib.php.patch (2 kB)
Issue Links:
Dependency
 
Relates
 

Participants: Chris Bandy, Eloy Lafuente (stronk7), Martin Dougiamas, N Hansen and Petr Skoda
Security Level: None
QA Assignee: Petr Skoda
Resolved date: 18/Apr/08
Affected Branches: MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches: MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
When upgrading from 1.6.x, new role assignments are given default values rather than retaining those stored in user_students and user_teachers. This appears to be the only place Internal Enrolment keeps a user's enrolment date and method.

Attached is a patch which retains enrolment dates and methods during upgrade.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Chris Bandy added a comment - 16/Apr/08 01:58 AM
Updated patch against HEAD (accesslib.php 1.441)

Chris Bandy made changes - 16/Apr/08 01:58 AM
Field Original Value New Value
Attachment accesslib.php.patch [ 13661 ]
Chris Bandy made changes - 16/Apr/08 01:58 AM
Attachment enrol_date.diff [ 11782 ]
[ Permalink | « Hide ]
Chris Bandy added a comment - 16/Apr/08 02:02 AM
Updating affected versions.

Chris Bandy made changes - 16/Apr/08 02:02 AM
Affects Version/s 1.8.5 [ 10252 ]
Affects Version/s 1.9 [ 10190 ]
Affects Version/s 1.8.3 [ 10230 ]
Affects Version/s 1.8.4 [ 10242 ]
Affects Version/s 1.7.4 [ 10243 ]
Affects Version/s 1.7.3 [ 10212 ]
Description When upgrading from 1.6.x, new role assignments are given default values rather than retaining those stored in user_students and user_teachers. This appears the only place Internal Enrolment keeps a user's enrolment date and method.

If I understand correctly, attached is a patch. 		When upgrading from 1.6.x, new role assignments are given default values rather than retaining those stored in user_students and user_teachers. This appears to be the only place Internal Enrolment keeps a user's enrolment date and method.

Attached is a patch which retains enrolment dates and methods during upgrade.
Priority Minor [ 4 ] Major [ 3 ]
[ Permalink | « Hide ]
Eloy Lafuente (stronk7) added a comment - 16/Apr/08 09:16 AM
Assigning to Petr, for your consideration.

Thanks for the report Chris (I've deleted the requested subtask).

Ciao


Eloy Lafuente (stronk7) made changes - 16/Apr/08 09:16 AM
Affects Version/s 1.7.2 [ 10174 ]
Affects Version/s 1.8.1 [ 10213 ]
Affects Version/s 1.8.2 [ 10220 ]
Affects Version/s 1.8 [ 10130 ]
Affects Version/s 1.8.3 [ 10230 ]
Affects Version/s 1.7.1 [ 10151 ]
Affects Version/s 1.7.3 [ 10212 ]
Affects Version/s 1.8.4 [ 10242 ]
Affects Version/s 1.7 [ 10120 ]
Assignee Martin Dougiamas [ dougiamas ] Petr Skoda [ skodak ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 16/Apr/08 03:04 PM
MD was working on this, right?

Petr Skoda made changes - 16/Apr/08 03:04 PM
Assignee Petr Skoda [ skodak ] Martin Dougiamas [ dougiamas ]
[ Permalink | « Hide ]
N Hansen added a comment - 18/Apr/08 09:01 AM
Wish I had had this yesterday when I upgraded and lost all this info!!!!

[ Permalink | « Hide ]
N Hansen added a comment - 18/Apr/08 09:02 AM
May I ask why such a serious bug with a patch offered wasn't taken care of months ago?

N Hansen made changes - 18/Apr/08 09:05 AM
Link This issue will help resolve MDL-14395 [ MDL-14395 ]
Martin Dougiamas made changes - 18/Apr/08 11:10 AM
Fix Version/s 1.7.5 [ 10251 ]
Priority Major [ 3 ] Critical [ 2 ]
Fix Version/s 1.8.6 [ 10270 ]
Fix Version/s 1.9.1 [ 10240 ]
[ Permalink | « Hide ]
Martin Dougiamas added a comment - 18/Apr/08 11:11 AM - edited
Somehow I never saw this one before(it was flagged as minor). Thanks, Chris, I'll patch everything today.

Martin Dougiamas made changes - 18/Apr/08 11:27 AM
Link This issue has a non-specific relationship to MDL-10502 [ MDL-10502 ]
moodler committed 1 file to 'Moodle CVS' on branch 'MOODLE_17_STABLE' - 18/Apr/08 11:28 AM
MDL-11142 Roles upgrade was losing timestart and timeend for teachers and students :-(
MODIFY lib/accesslib.php   Rev. 1.166.2.48    (+3 -3 lines)
moodler committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 18/Apr/08 11:30 AM
MDL-11142 Roles upgrade was losing timestart and timeend for teachers and students (Merged from 1.7)
MODIFY lib/accesslib.php   Rev. 1.221.2.51    (+4 -4 lines)
moodler committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 18/Apr/08 11:31 AM
MDL-11142 Roles upgrade was losing timestart and timeend for teachers and students (Merged from 1.7)
MODIFY lib/accesslib.php   Rev. 1.421.2.60    (+4 -4 lines)
moodler committed 1 file to 'Moodle CVS' - 18/Apr/08 11:33 AM
MDL-11142 Roles upgrade was losing timestart and timeend for teachers and students (Merged from 1.7)
MODIFY lib/accesslib.php   Rev. 1.480    (+4 -4 lines)
[ Permalink | « Hide ]
Martin Dougiamas added a comment - 18/Apr/08 11:35 AM
Patched in CVS

Martin Dougiamas made changes - 18/Apr/08 11:35 AM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 22/Apr/08 03:56 PM
reviewed, closing

Petr Skoda made changes - 22/Apr/08 03:56 PM
Status Resolved [ 5 ] Closed [ 6 ]
QA Assignee skodak

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators