Moodle

& needs fix to & in block_tag_youtube for 'en' and other language packs

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9
  • Component/s: Accessibility, Language
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

The attached patch fixes the bugs in, cvsroot/moodle/lang/*/block_tag_youtube.php for: es, sr_lt, sr_cr, de, fr, tr Turkish.

Notes:

  • I converted my Eclipse "lang" project to UTF-8 before creating the patch - hopefully OK!
  • the YouTube block was only added in 1.9 Dev.
  • this is not "Accessibility" per se, more "Standards".

This drives home for me - we need to address validation/semantics of language packs, particularly help files See related bug MDL-9890, "Help should be well-formed..."

Issue Links

This issue blocks:
MDL-12902 Multi-language help should be accessible, XHTML Strict and semantic Minor Closed
This issue has a non-specific relationship to:
MDL-9890 Help should be well-formed, XHTML Strict and semantic Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Nick Freear added a comment -

Koen,
I hope you don't mind me adding you to the watch list. This could be the 1st of many patches to help files in language packs (if I start tackling general validation/semantic bugs) - will translators mind? I can post to the "languages" forum, but I plan to chip away at this in spare moments - it may be slow.
Comments welcome!

Thanks, Nick

Show
Nick Freear added a comment - Koen, I hope you don't mind me adding you to the watch list. This could be the 1st of many patches to help files in language packs (if I start tackling general validation/semantic bugs) - will translators mind? I can post to the "languages" forum, but I plan to chip away at this in spare moments - it may be slow. Comments welcome! Thanks, Nick
Hide
Permalink
Koen Roggemans added a comment -

Hi Nick,

Thanks for inviting me in and for your efforts on the lang packs!

I think semantic changes are not a problem at all, as long as the meaning isn't changed (like features added or removed or functionality changed). So if it is only that, I wouldn't bother posting in the lang forum. But if there are some errors in the content of help files, it would be good to know for the other languages too. A post in the lang forum would be great.

I've been looking at your other changes in the English helpfilese (MDL-9890) for applying it to the other language packs, but I'm still fighting with my Eclipse search and replace (very few spare moments ) Once I get into it, I'll try to fix some more langpacks.

Show
Koen Roggemans added a comment - Hi Nick, Thanks for inviting me in and for your efforts on the lang packs! I think semantic changes are not a problem at all, as long as the meaning isn't changed (like features added or removed or functionality changed). So if it is only that, I wouldn't bother posting in the lang forum. But if there are some errors in the content of help files, it would be good to know for the other languages too. A post in the lang forum would be great. I've been looking at your other changes in the English helpfilese (MDL-9890) for applying it to the other language packs, but I'm still fighting with my Eclipse search and replace (very few spare moments ) Once I get into it, I'll try to fix some more langpacks.
Hide
Permalink
Nick Freear added a comment -

Hi,
I've now got permissions to write to the 'lang' module, so I've finally committed this v. simple patch, except for the 'fr' French language pack, which was fixed by Nicolas - thank you!

Koen, thanks for the comments and offer of help. You're free to do fixes if you wish, but I aim to take a different approach to MDL-9890 - instead of doing 2 big rounds of fixes to just one language 'en', I'd like to do a small number of fixes per patch/at a time for ALL languages, at least where I can automate using search/replace or a script. I think this will be more efficient, and give more uniform results.

Having said that, I don't expect to do much until next week - too busy!
Many thanks

Nick

Show
Nick Freear added a comment - Hi, I've now got permissions to write to the 'lang' module, so I've finally committed this v. simple patch, except for the 'fr' French language pack, which was fixed by Nicolas - thank you! Koen, thanks for the comments and offer of help. You're free to do fixes if you wish, but I aim to take a different approach to MDL-9890 - instead of doing 2 big rounds of fixes to just one language 'en', I'd like to do a small number of fixes per patch/at a time for ALL languages, at least where I can automate using search/replace or a script. I think this will be more efficient, and give more uniform results. Having said that, I don't expect to do much until next week - too busy! Many thanks Nick
Hide
Permalink
Nick Freear added a comment -

Hi
I've found that Martin D (moodler) committed semantic fixes to many language packs 5/1/2007,
"" Converted all these for XHTML strictness:
<p align="center"><b>xxxxxxxx</b></p>
to
<h1>xxxxxxxxx</h1>
using

foreach dir (*_utf8/help)
cd $dir
perl -pi -e 's/p align="center"\>\<b\>(.+)\<\/b\><\/p>/h1\>$1\<\/h1\>/i' .html */.html //.html *///.html
cd ../..
end
""
But, sunner_sun updated on 23/3/207, overwriting the fixes, - this was the comment
"Tons of new translation and modification by Shanghai Normal University, especially kuangliang12345[at]163.com"

We need to impress on translators the need to keep their CVS up to date, and not to overwrite markup fixes - something for the language forum.
Shouldn't take much to redo, but it's unfortunate!
http://moodle.cvs.sourceforge.net/moodle/lang/zh_cn_utf8/help/advancedsettings.html?r1=1.2&r2=1.3

Show
Nick Freear added a comment - Hi I've found that Martin D (moodler) committed semantic fixes to many language packs 5/1/2007, "" Converted all these for XHTML strictness: <p align="center"><b>xxxxxxxx</b></p> to <h1>xxxxxxxxx</h1> using foreach dir (*_utf8/help) cd $dir perl -pi -e 's/p align="center"\>\<b\>(.+)\<\/b\><\/p>/h1\>$1\<\/h1\>/i' .html */.html //.html *///.html cd ../.. end "" But, sunner_sun updated on 23/3/207, overwriting the fixes, - this was the comment "Tons of new translation and modification by Shanghai Normal University, especially kuangliang12345[at]163.com" We need to impress on translators the need to keep their CVS up to date, and not to overwrite markup fixes - something for the language forum. Shouldn't take much to redo, but it's unfortunate! http://moodle.cvs.sourceforge.net/moodle/lang/zh_cn_utf8/help/advancedsettings.html?r1=1.2&r2=1.3
Hide
Permalink
Koen Roggemans added a comment -

I know Nick - I had that problem already a few times. (eg the BOM bug and previous attempts for XHTML strict a couple of years ago). It happens that translators start of from very outdated English language packs.
The problem is that translators are not always developers and not always connected to the Moodle heartbeat. Most of them are not even subscribed to the languages forum.
I think the only thing that can be done is contact the people who caused the damage personally (and redo it ).

Show
Koen Roggemans added a comment - I know Nick - I had that problem already a few times. (eg the BOM bug and previous attempts for XHTML strict a couple of years ago). It happens that translators start of from very outdated English language packs. The problem is that translators are not always developers and not always connected to the Moodle heartbeat. Most of them are not even subscribed to the languages forum. I think the only thing that can be done is contact the people who caused the damage personally (and redo it ).
Hide
Permalink
Nick Freear added a comment -

Specific bug is fixed for 1.9 - see MDL-12902 for the generic multi-language issue with help files.

Show
Nick Freear added a comment - Specific bug is fixed for 1.9 - see MDL-12902 for the generic multi-language issue with help files.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.