Moodle

19PERF META BUG: Inspect and merge Catalyst accesslib improvements into HEAD

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9
  • Component/s: Roles / Access
  • Labels:
    None

Description

The performance patches from http://moodle.org/mod/forum/discuss.php?d=79455 need to be examined, tested.

1) Examine new code in various environments and file/fix bugs here as necessary
2) Test common operations such as logging in, listing courses, searching courses, moving around, assigning roles, using modules, switch user, login as on:
a) small sites
b) large sites (25,000 students / 10,000 courses / 100,000 enrolments)
and measure page generation times and database load for current HEAD and new code
3) Along the way keep fixing any divergences in functionality by posting them here.
4) If after all that, if the new code is better overall by, say, 20% or more then let's add it to HEAD ASAP.
5) Continue testing in HEAD.

Make sure you have a look at the testing and dev hints mentioned in the forum thread above.

Issue Links

Progress
Resolved Sub-Tasks

Sub-Tasks

Activity

Hide
Martin Dougiamas added a comment -

Can you land these patches in HEAD tomorrow, Martin? (Thursday)

I think it's very clear that the performance improvements are there and it seems to be working . Putting them in HEAD will make further examination and polishing a lot easier for the rest of us.

Show
Martin Dougiamas added a comment - Can you land these patches in HEAD tomorrow, Martin? (Thursday) I think it's very clear that the performance improvements are there and it seems to be working . Putting them in HEAD will make further examination and polishing a lot easier for the rest of us.
Hide
Martin Dougiamas added a comment -

Actually, Yu iwas a bit worried about MDL-11220 and think a solution might be non-trivial so perhaps if we can solve that first before a merge.

Show
Martin Dougiamas added a comment - Actually, Yu iwas a bit worried about MDL-11220 and think a solution might be non-trivial so perhaps if we can solve that first before a merge.
Hide
Martín Langhoff added a comment -

Just to assuage any concerns, I am taking MDL-11220 seriously, and I think I have a fix. It's my priority for tomorrow. And – agreed – I wouldn't dream of merging with that bug open.

Show
Martín Langhoff added a comment - Just to assuage any concerns, I am taking MDL-11220 seriously, and I think I have a fix. It's my priority for tomorrow. And – agreed – I wouldn't dream of merging with that bug open.
Hide
Martín Langhoff added a comment - - edited

I am going to be trying to finish this off in the next couple of days. Other projects are starting to pull me in all sorts of directions, and hacking on this code needs quite a bit of focus (at least for me!). So – testers/reviewers, hit it hard so I can address all anything you unearth.

Show
Martín Langhoff added a comment - - edited I am going to be trying to finish this off in the next couple of days. Other projects are starting to pull me in all sorts of directions, and hacking on this code needs quite a bit of focus (at least for me!). So – testers/reviewers, hit it hard so I can address all anything you unearth.
Hide
Martin Dougiamas added a comment -

Yep, it's looking pretty good. Definitely good enough to merge into CVS. Can you start tackling this please? I'm keen to give 1.9 time to mature with this patch baked in!

Show
Martin Dougiamas added a comment - Yep, it's looking pretty good. Definitely good enough to merge into CVS. Can you start tackling this please? I'm keen to give 1.9 time to mature with this patch baked in!
Hide
AjnabiZ added a comment -

I hope its ready

Show
AjnabiZ added a comment - I hope its ready
Hide
Martín Langhoff added a comment -

I'm intending to clear these up – including the issues raised in he last couple of days – this week. Got time set aside Monday & Tuesday for it.

Show
Martín Langhoff added a comment - I'm intending to clear these up – including the issues raised in he last couple of days – this week. Got time set aside Monday & Tuesday for it.

People

Vote (2)
Watch (7)

Dates

  • Created:
    Updated:
    Resolved: