Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Critical
-
Resolution: Fixed
-
Affects Version/s: 1.8
-
Component/s: Administration, Authentication, MNet
-
Labels:None
-
Affected Branches:MOODLE_18_STABLE
-
Fixed Branches:MOODLE_18_STABLE, MOODLE_19_STABLE
Description
Cannot create child authentication plugins because it will throw a Fatal Error upon installation. Tracked down the culprit in function mnet_get_functions defined in admin/mnet/adminlib.php. Attached is a proposed fix, but several other solutions come to mind that take advantage of existing API to manage enrol/auth plugins.
Attachments
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Thanks Petr for your quick response! Having the patch in so quickly is really appreciated 
I agree with using the x_once() approach since one never knows when it might have already been included, especially with plugins and class definitions. Along this line, I was wondering if Moodle has a coding preference to write includes/requires as statements or as functions. So:
require_once 'path/to/file';
or
require_once('path/to/file');
Cheers and thanks again Petr!
I agree with using the x_once() approach since one never knows when it might have already been included, especially with plugins and class definitions. Along this line, I was wondering if Moodle has a coding preference to write includes/requires as statements or as functions. So:
require_once 'path/to/file';
or
require_once('path/to/file');
Cheers and thanks again Petr! 
The quick patch is in CVS, I have changed one more include to include_once(). I agree this use of include() is a potential problem because it might cause breakage in the future in some contexts, when including library files we should IMO always use xx_once(). The exceptions are our version, access, defaults where we construct arrays or set some variables.
CCing Martín, please file a new issue if other improvements needed, feel free to revert the commit
thanks for the report and patch