Moodle

Grade Letters must be settings, not user preferences

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9
  • Component/s: Gradebook
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Grade letters currently work like this:

Site preferences are default for:
Course user preferences which affect : display for graders only

The problem is that the grade letters need to work in lots of reports/imports/exports and they need to work consistently, like this:

1. Site settings define overall letter boundaries which act as a default.
2. Course settings are set on plugin menu under Edit -> Grade Display (each can be site default or some local override). Also here is a course default for "Real / Percentage / Letters / Default"
3. Grade_item settings have another setting for "Real / Percentage / Letters / Default"

1 would require a new grade_letters table (set courseid to zero)
2 would use the same table (set courseid to courseid) for the boundaries, and a config_plugins entry for the grade display
3) would require a new field on grade_item called "display".

There needs to be changes in the grade classes too so that these are all resolved correctly.

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Some ideas pasted from the HQ:

1) For courses, disabled by default and if the edit button is pressd, bump, defaults are copied to the course context and make editable.
2) Option to "reset to defaults", i.e. delete the contextid (course) related records.
3) Some capability should control who has access to edit contextid letters.

Show
Eloy Lafuente (stronk7) added a comment - Some ideas pasted from the HQ: 1) For courses, disabled by default and if the edit button is pressd, bump, defaults are copied to the course context and make editable. 2) Option to "reset to defaults", i.e. delete the contextid (course) related records. 3) Some capability should control who has access to edit contextid letters.
Hide
Nicolas Connault added a comment - - edited

I'm wondering if the gradedisplay type prefs for range and averages rows should be left in the grader report preferences form or should be removed, and we leave the entire column's display to be controlled by the grade_item/course/site. The idea originally was to show "real" grades in the middle, and letters instead of averages at the bottom.

With these 2 preferences, each user that has manage capability can change the way the ranges and averages rows display their values.

Question then: is the rationale for removing the gradedisplaytype for grades out of the preferences, also valid for these 2 other prefs?

If they stay in preferences, they should however lose their "inherit" option, which will double up with the default option.

Show
Nicolas Connault added a comment - - edited I'm wondering if the gradedisplay type prefs for range and averages rows should be left in the grader report preferences form or should be removed, and we leave the entire column's display to be controlled by the grade_item/course/site. The idea originally was to show "real" grades in the middle, and letters instead of averages at the bottom. With these 2 preferences, each user that has manage capability can change the way the ranges and averages rows display their values. Question then: is the rationale for removing the gradedisplaytype for grades out of the preferences, also valid for these 2 other prefs? If they stay in preferences, they should however lose their "inherit" option, which will double up with the default option.
Hide
Nicolas Connault added a comment -

All done! Phew!

Show
Nicolas Connault added a comment - All done! Phew!
Hide
Andrew Davis added a comment -

All working as you would expect. Closing.

Show
Andrew Davis added a comment - All working as you would expect. Closing.

People

Dates

  • Created:
    Updated:
    Resolved: