Issue Details (XML | Word | Printable)

Key: MDL-11312
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Nicolas Connault
Reporter: Martin Dougiamas
Votes: 1
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Grade Letters must be settings, not user preferences

Created: 18/Sep/07 01:04 AM   Updated: 17/Nov/09 11:00 AM
Return to search
Component/s: Gradebook
Affects Version/s: 1.9
Fix Version/s: 1.9

Participants: Eloy Lafuente (stronk7), Martin Dougiamas and Nicolas Connault
Security Level: None
Resolved date: 19/Sep/07
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE

Sub-Tasks  All   Open   
 Sub-Task Progress: 
No sub-tasks match this view.

 Description  « Hide
Grade letters currently work like this:

    Site preferences are default for:
    Course user preferences which affect : display for graders only

The problem is that the grade letters need to work in lots of reports/imports/exports and they need to work consistently, like this:

    1. Site settings define overall letter boundaries which act as a default.
    2. Course settings are set on plugin menu under Edit -> Grade Display (each can be site default or some local override). Also here is a course default for "Real / Percentage / Letters / Default"
    3. Grade_item settings have another setting for "Real / Percentage / Letters / Default"
    
1 would require a new grade_letters table (set courseid to zero)
2 would use the same table (set courseid to courseid) for the boundaries, and a config_plugins entry for the grade display
3) would require a new field on grade_item called "display".

There needs to be changes in the grade classes too so that these are all resolved correctly.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Nicolas Connault committed 6 files to 'Moodle CVS' - 18/Sep/07 10:26 PM
MDL-11312 Added new grade_letters table, and new grade_items.display field.
MODIFY lib/grade/simpletest/testgradecategory.php   Rev. 1.6    (+2 -2 lines)
MODIFY lib/grade/grade_item.php   Rev. 1.112    (+7 -1 lines)
MODIFY lib/db/install.xml   Rev. 1.116    (+16 -4 lines)
MODIFY lib/simpletest/fixtures/gradetest.php   Rev. 1.20    (+217 -1 lines)
MODIFY lib/db/upgrade.php   Rev. 1.124    (+54 -25 lines)
MODIFY version.php   Rev. 1.539    (+1 -1 lines)