Issue Details (XML | Word | Printable)

Key: MDL-11342
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Mathieu Petit-Clair
Reporter: Alan Trick
Votes: 0
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

file path not urlencoded

Created: 19/Sep/07 09:24 AM   Updated: 02/May/08 04:18 PM
Return to search
Component/s: Resource
Affects Version/s: 1.8.2
Fix Version/s: 1.8.6, 1.9.1

File Attachments: 1. Text File resource.class.php.patch (0.7 kB)

Issue Links:
Dependency
 

Participants: Alan Trick and Mathieu Petit-Clair
Security Level: None
Resolved date: 02/May/08
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
file directory dies not urlencode the file names it lists, so if you upload a file with a # in the name, it will output that as-is in the url which will cause the link to be invalid. I attached a patch to fix the problem.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Alan Trick added a comment - 02/May/08 07:47 AM
Note: this also affects 1.9

Mathieu Petit-Clair added a comment - 02/May/08 03:30 PM
MDL-14279 will fix that problem in 1.9, but you might want to apply the patch attached to that report for 1.8, as I don't think it will be applied as-is in 1.8.

Mathieu Petit-Clair added a comment - 02/May/08 03:48 PM
Sorry, I looked at this too quickly. I'll apply the patch, thanks.