Moodle

file path not urlencoded

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8.2
  • Fix Version/s: 1.8.6, 1.9.1
  • Component/s: Resource
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE

Description

file directory dies not urlencode the file names it lists, so if you upload a file with a # in the name, it will output that as-is in the url which will cause the link to be invalid. I attached a patch to fix the problem.

Issue Links

This issue will be resolved by:
MDL-14279 Use get_file_url instead of manual slasharguments check Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Alan Trick added a comment -

Note: this also affects 1.9

Show
Alan Trick added a comment - Note: this also affects 1.9
Hide
Permalink
Mathieu Petit-Clair added a comment -

MDL-14279 will fix that problem in 1.9, but you might want to apply the patch attached to that report for 1.8, as I don't think it will be applied as-is in 1.8.

Show
Mathieu Petit-Clair added a comment - MDL-14279 will fix that problem in 1.9, but you might want to apply the patch attached to that report for 1.8, as I don't think it will be applied as-is in 1.8.
Hide
Permalink
Mathieu Petit-Clair added a comment -

Sorry, I looked at this too quickly. I'll apply the patch, thanks.

Show
Mathieu Petit-Clair added a comment - Sorry, I looked at this too quickly. I'll apply the patch, thanks.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.