Moodle

Leave old $string['editlang'] in HEAD branch

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8, 1.8.1, 1.8.2
  • Fix Version/s: None
  • Component/s: Language
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE

Description

The string $string['editlang'] is not used any more in 1.8.x and was deleted from HEAD. The following commit should be reverted.

Index: admin.php
===================================================================
RCS file: /cvsroot/moodle/moodle/lang/en_utf8/admin.php,v
retrieving revision 1.144
retrieving revision 1.145
diff -u -d -r1.144 -r1.145

Issue Links

Activity

Hide
Koen Roggemans added a comment -

Hi David,
I think you took this string out - can't see why though. For backwards compatibility, it's best to leave old strings in...

Show
Koen Roggemans added a comment - Hi David, I think you took this string out - can't see why though. For backwards compatibility, it's best to leave old strings in...
Hide
David Mudrak added a comment -

I am sorry - I totally forgot backwards compatibility issue and the rule "Never delete strings". You are right - the string should go back into the HEAD.

On the other hand - keeping such dead souls brings more work for new translators as they translate [almost] useless strings. Maybe we could manage do some clean up in 2.0?

Show
David Mudrak added a comment - I am sorry - I totally forgot backwards compatibility issue and the rule "Never delete strings". You are right - the string should go back into the HEAD. On the other hand - keeping such dead souls brings more work for new translators as they translate [almost] useless strings. Maybe we could manage do some clean up in 2.0?
Hide
David Mudrak added a comment -

The string is back in HEAD. Closing.

Show
David Mudrak added a comment - The string is back in HEAD. Closing.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: