Details
Bug
Minor
Description
At line 1405 there were missing quotes arounf the {$context->id} variable: when it is empty it makes the query crash and the XML Parser throws an error...
$sql = "SELECT ctx.path, rc.roleid, rc.capability, rc.permission
FROM {$CFG->prefix}role_capabilities rc
JOIN {$CFG->prefix}context ctx
ON rc.contextid=ctx.id
WHERE (rc.roleid IN ($roleids)
==> AND (ctx.id='{$context->id}' OR ctx.path LIKE '{$context->path}/%'))
$wherelocalroles
ORDER BY ctx.depth ASC, ctx.path DESC, rc.roleid ASC ";
Issue Links
| This issue has a non-specific relationship to: | ||||
| MDL-11360 | Call to a member function on a non-object |
|
|
|
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Well, the problem happened just after an upgrade from the CVS.
Putting the quotes fixed the error... for a while... Actually I had to rebuild all the tables from scratch 
but fortunatelly it is a test server 
Thank you for the hint on XML Source: after playing around with the code |-) for a while I found out 
PS: in MySQL, a query like ... ctx.ID= OR ... thorws an error, not a warning, so I make it ... ctx.id='' OR ... and it is a 0 record SQL instead of an error
but fortunatelly it is a test server
Thank you for the hint on XML Source: after playing around with the code |-) for a while I found out
PS: in MySQL, a query like ... ctx.ID= OR ... thorws an error, not a warning, so I make it ... ctx.id='' OR ... and it is a 0 record SQL instead of an error 
I'm pretty sure this is not an issue anymore, but assigning to Martin L to check.
The actual fix proposed here is not ideal, I think, because quotes around a number slow things down, and also because the SQL shouldn't even be called if there is no $context->id ..