[#MDL-11385] Fix the XMLDB Editor to avoid some default comments...

Issue Details (XML | Word | Printable)

Key:	MDL-11385
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Minor
Assignee:	Eloy Lafuente (stronk7)
Reporter:	Eloy Lafuente (stronk7)
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Fix the XMLDB Editor to avoid some default comments...

Created: 21/Sep/07 05:37 PM Updated: 25/Sep/07 06:29 AM

Return to search

Component/s:

Database SQL/XMLDB

Affects Version/s:

1.9

Fix Version/s:

1.9

Environment:

Any

Participants:	Eloy Lafuente (stronk7)
Security Level:	None
Resolved date:	25/Sep/07
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

Avoid default comments for id fields, keys and indexes.

Clean current ones from install.xml files

Ciao :-)

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 25/Sep/07 02:26 AM

They are:

"id of the table, please edit me"->within new created install.xml files
"Primary key for XXX"-> within new created install.xml files

"id of the table, please edit me"~~> within new created tables~~>id
"primary key of the table, please edit me" ~~>within new created tables~~>pk

"Default comment for the field, please edit me" when adding a new field
"Default comment for the index, please edit me" when adding a new index
"Default comment for the key, please edit me" when adding a new key

Remove them from the XMLDEditor and from the current install.xml files

Only the table comment will remain with one: "Default comment for the table, please edit me", because it's interesting to add meaningful comments for the table.

Eloy Lafuente (stronk7) committed 5 files to 'Moodle CVS' - 25/Sep/07 02:40 AM

Deleting some default comments that the XMLDB editor was
generating here and there. Only the table one remains. ~~MDL-11385~~

MODIFY	admin/xmldb/actions/new_table/new_table.class.php	Rev. 1.5	(+0 -2 lines)
MODIFY	admin/xmldb/actions/new_index/new_index.class.php	Rev. 1.4	(+1 -2 lines)
MODIFY	admin/xmldb/actions/new_field/new_field.class.php	Rev. 1.4	(+1 -2 lines)
MODIFY	admin/xmldb/actions/create_xml_file/create_xml_file.class.php	Rev. 1.4	(+3 -3 lines)
MODIFY	admin/xmldb/actions/new_key/new_key.class.php	Rev. 1.4	(+1 -2 lines)

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 25/Sep/07 02:41 AM

XMLDB Editor fixed. Going to iterate over all install.xml destroying those "default" comments.

Eloy Lafuente (stronk7) committed 2 files to 'Moodle CVS' - 25/Sep/07 03:08 AM

First pass. Deleting some default comments. ~~MDL-11385~~

MODIFY	lib/db/install.xml		Rev. 1.119		(+53 -53 lines)
MODIFY	backup/db/Attic/install.xml		Rev. 1.3		(+2 -2 lines)

Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' - 25/Sep/07 03:36 AM

One more default and useless comment deleted. ~~MDL-11385~~

MODIFY

admin/xmldb/actions/new_table_from_mysql/new_table_from_mysql.class.php

Rev. 1.7

(+0 -1 lines)

Eloy Lafuente (stronk7) committed 7 files to 'Moodle CVS' - 25/Sep/07 06:10 AM

Second pass. Some more default comments are out. ~~MDL-11385~~

MODIFY	backup/db/Attic/install.xml	Rev. 1.4	(+5 -5 lines)
MODIFY	lib/db/install.xml	Rev. 1.120	(+53 -53 lines)
MODIFY	blocks/rss_client/db/install.xml	Rev. 1.3	(+2 -2 lines)
MODIFY	enrol/authorize/db/install.xml	Rev. 1.6	(+3 -3 lines)
MODIFY	blocks/search/db/install.xml	Rev. 1.4	(+1 -1 lines)
MODIFY	enrol/paypal/db/install.xml	Rev. 1.3	(+2 -2 lines)
MODIFY	blocks/db/Attic/install.xml	Rev. 1.4	(+3 -3 lines)

Eloy Lafuente (stronk7) committed 18 files to 'Moodle CVS' - 25/Sep/07 06:17 AM

Second pass. Modules. Some more default comments are out. ~~MDL-11385~~

MODIFY	mod/exercise/db/Attic/install.xml	Rev. 1.2	(+7 -7 lines)
MODIFY	mod/chat/db/install.xml	Rev. 1.3	(+4 -4 lines)
MODIFY	mod/scorm/db/install.xml	Rev. 1.7	(+11 -11 lines)
MODIFY	mod/lesson/db/install.xml	Rev. 1.7	(+10 -10 lines)
MODIFY	mod/resource/db/install.xml	Rev. 1.4	(+2 -2 lines)
MODIFY	mod/hotpot/db/install.xml	Rev. 1.4	(+7 -7 lines)
MODIFY	mod/forum/db/install.xml	Rev. 1.5	(+9 -9 lines)
MODIFY	mod/lams/db/Attic/install.xml	Rev. 1.2	(+2 -2 lines)
MODIFY	mod/choice/db/install.xml	Rev. 1.2	(+4 -4 lines)
MODIFY	mod/data/db/install.xml	Rev. 1.9	(+7 -7 lines)
MODIFY	mod/survey/db/install.xml	Rev. 1.3	(+4 -4 lines)
MODIFY	mod/label/db/install.xml	Rev. 1.3	(+2 -2 lines)
MODIFY	mod/glossary/db/install.xml	Rev. 1.4	(+9 -9 lines)
MODIFY	mod/assignment/db/install.xml	Rev. 1.4	(+3 -3 lines)
MODIFY	mod/journal/db/Attic/install.xml	Rev. 1.4	(+3 -3 lines)
MODIFY	mod/wiki/db/install.xml	Rev. 1.4	(+5 -5 lines)
MODIFY	mod/workshop/db/Attic/install.xml	Rev. 1.5	(+9 -9 lines)
MODIFY	mod/quiz/db/install.xml	Rev. 1.10	(+17 -17 lines)

Eloy Lafuente (stronk7) committed 8 files to 'Moodle CVS' - 25/Sep/07 06:20 AM

Second pass. Questions. Some more default comments are out. ~~MDL-11385~~

MODIFY	question/type/multianswer/db/install.xml	Rev. 1.2	(+2 -2 lines)
MODIFY	question/type/calculated/db/install.xml	Rev. 1.2	(+2 -2 lines)
MODIFY	question/type/match/db/install.xml	Rev. 1.2	(+3 -3 lines)
MODIFY	question/type/truefalse/db/install.xml	Rev. 1.2	(+2 -2 lines)
MODIFY	question/type/numerical/db/install.xml	Rev. 1.2	(+2 -2 lines)
MODIFY	question/type/shortanswer/db/install.xml	Rev. 1.2	(+2 -2 lines)
MODIFY	question/type/randomsamatch/db/install.xml	Rev. 1.2	(+2 -2 lines)
MODIFY	question/type/multichoice/db/install.xml	Rev. 1.5	(+2 -2 lines)

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 25/Sep/07 06:29 AM

Done. Now all the default comments above are out.

Eloy Lafuente (stronk7) made changes - 25/Sep/07 06:29 AM

Field	Original Value	New Value
Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

All content on this web site is made available under the GNU General Public License, unless otherwise stated.