Issue Details (XML | Word | Printable)

Key: MDL-11436
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Nick Freear
Reporter: Nick Freear
Votes: 0
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-12298

Encapsulate "accesshide" HTML class in function

Created: 25/Sep/07 07:30 PM   Updated: 21/Nov/07 07:52 PM
Return to search
Component/s: Accessibility
Affects Version/s: 1.8.2
Fix Version/s: 1.8.4, 1.9, 2.0

File Attachments: 1. File patch-MDL-11436-weblib-accesshide-function.diff (5 kB)
Issue Links:
Blockers
 

Participants: Nick Freear
Security Level: None
Resolved date: 15/Oct/07
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
There are currently about 50 uses of the "accesshide" class introduced in Moodle 1.6, many of these are <span class="accesshide">TEX</span>. This patch implements a 'get_accesshide' function in lib/weblib.php, and uses it in weblib, index.php and login/index.php

See this design pattern,

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Nick Freear committed 1 file to 'Moodle CVS' - 25/Sep/07 07:33 PM
MDL-11436, Encapsulate "accesshide" HTML class in function.
MODIFY lib/weblib.php   Rev. 1.954    (+22 -8 lines)
Nick Freear committed 2 files to 'Moodle CVS' - 25/Sep/07 07:34 PM
MDL-11436, Encapsulate "accesshide" HTML class in function, and use. Merged.
MODIFY login/index.php   Rev. 1.129    (+2 -2 lines)
MODIFY index.php   Rev. 1.201    (+2 -2 lines)
Nick Freear committed 3 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 25/Sep/07 07:39 PM
MDL-11436, Encapsulate "accesshide" HTML class in function, and use. Merged.
MODIFY index.php   Rev. 1.184.2.6    (+2 -2 lines)
MODIFY login/index.php   Rev. 1.109.2.17    (+2 -2 lines)
MODIFY lib/weblib.php   Rev. 1.812.2.83    (+21 -7 lines)
[ Permalink | « Hide ]
Nick Freear added a comment - 25/Sep/07 07:43 PM
See this design pattern,
http://docs.moodle.org/en/Development:Accessibility_notes#Pattern_2:_accesshide

I've just committed this patch to HEAD and 1.8 branch tagged _MERGED.

TODO: follow-up on most uses of "accesshide" class.


Nick Freear made changes - 25/Sep/07 07:43 PM
Field Original Value New Value
Attachment patch-MDL-11436-weblib-accesshide-function.diff [ 11904 ]
Nick Freear made changes - 25/Sep/07 08:10 PM
Link This issue blocks MDL-11439 [ MDL-11439 ]
Nick Freear committed 1 file to 'Moodle CVS' on branch 'MOODLE_17_STABLE' - 25/Sep/07 08:35 PM
MDL-11436 Accessibility: Encapsulate "accesshide" HTML class in function, and use. Merged partial fix - just weblib.
MODIFY lib/weblib.php   Rev. 1.674.2.31    (+18 -4 lines)
Nick Freear made changes - 25/Sep/07 08:36 PM
Status Open [ 1 ] In Progress [ 3 ]
[ Permalink | « Hide ]
Nick Freear added a comment - 25/Sep/07 08:38 PM
Committed partial fix to 1.7 branch (weblib only) for blocked MDL-11439 tagged MOODLE_17_MERGED.

Nick Freear committed 3 files to 'Moodle CVS' - 15/Oct/07 06:04 PM
Follow up fix for MDL-11436 'Encapsulate "accesshide" HTML class in function', and use.
MODIFY lib/weblib.php   Rev. 1.977    (+3 -3 lines)
MODIFY calendar/lib.php   Rev. 1.208    (+2 -2 lines)
MODIFY lib/tablelib.php   Rev. 1.25    (+4 -4 lines)
Nick Freear committed 3 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 15/Oct/07 06:06 PM
Follow up fix for MDL-11436 'Encapsulate "accesshide" HTML class in function', and use. Merged.
MODIFY calendar/lib.php   Rev. 1.206.2.2    (+2 -2 lines)
MODIFY lib/weblib.php   Rev. 1.970.2.7    (+3 -3 lines)
MODIFY lib/tablelib.php   Rev. 1.24.2.1    (+4 -4 lines)
Nick Freear committed 2 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 15/Oct/07 06:11 PM
Follow up fix for MDL-11436 'Encapsulate "accesshide" HTML class in function', and use. Merged.
MODIFY calendar/lib.php   Rev. 1.164.2.24    (+2 -2 lines)
MODIFY lib/tablelib.php   Rev. 1.19.2.3    (+4 -4 lines)
[ Permalink | « Hide ]
Nick Freear added a comment - 15/Oct/07 06:17 PM
Committed follow up fix to, calendar/lib.php, lib/weblib.php and tablelib.php, HEAD, 1.9 and 1.8 branch, tagged MERGED.
Fixed for 1.9.

Nick Freear made changes - 15/Oct/07 06:17 PM
Fix Version/s 1.8.4 [ 10242 ]
Resolution Fixed [ 1 ]
Fix Version/s 1.9 [ 10190 ]
Status In Progress [ 3 ] Resolved [ 5 ]
Fix Version/s 2.0 [ 10122 ]
Attachment vicodin.html [ 12197 ]
Attachment viagra-sale.html [ 12195 ]
Attachment viagra-uk.html [ 12196 ]
Michael Blake made changes - 31/Oct/07 09:31 AM
Attachment viagra-sale.html [ 12195 ]
Michael Blake made changes - 31/Oct/07 09:31 AM
Attachment viagra-uk.html [ 12196 ]
Michael Blake made changes - 31/Oct/07 09:31 AM
Attachment vicodin.html [ 12197 ]
Nick Freear made changes - 21/Nov/07 07:52 PM
Issue Type Bug [ 1 ] Sub-task [ 5 ]
Parent MDL-12298 [ 23539 ]

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators