|
[
Permalink
| « Hide
]
Helen Foster added a comment - 29/Sep/07 02:21 PM
Moodle 1.8 is also affected.
Helen Foster made changes - 29/Sep/07 02:21 PM
Issue is in a change in the resource_get_type output.
This affects the This function should extract the "type" value from the $typrec->type string that is now resource&type=<typename> Following code fixes the issue, recodeing the way this function gets files : Note that although I signal wherethe major fix is, it affects entire code of the function. Note again that I prepared the code for eventual reintegration of all module docs and language files within the module directory so that a module should be entirely self-contained. function include_help_for_each_resource($file, $langs, $helpdir) { require_once($CFG->dirroot .'/mod/resource/lib.php'); foreach ($typeset as $type) { $filepath = "$helpdir/resource/type/{$type}.html"; // If that does not exist, try a fallback into the module code folder. if (file_exists_and_readable($filepath)) {
echo '<hr size="1" />';
@include($filepath); // The actual helpfile
break; // Out of loop over languages.
} Assigning this to Jérôme... ciao
Eloy Lafuente (stronk7) made changes - 12/May/08 09:27 AM
Martin Dougiamas made changes - 15/May/08 03:02 PM
Patch attached. Thank you Valery
Jerome Mouneyrac made changes - 16/May/08 04:17 PM
Uhm...
perhaps... I would modify the resource_get_types() function to return one more attribute, say, $type->name or $type->code or something like that. And them, I'd use that new attribute directly in help.php Ciao
Jerome Mouneyrac made changes - 16/Jun/08 11:03 AM
new patch attached (I fixed XHTML issue too)
Jerome Mouneyrac made changes - 16/Jun/08 11:04 AM
Jerome Mouneyrac made changes - 16/Jun/08 11:11 AM
Jerome Mouneyrac made changes - 16/Jun/08 11:11 AM
Looks perfect for me. If it also works... +1 :-D
Thanks, ciao
Jerome Mouneyrac committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 17/Jun/08 09:47 AM
Jerome Mouneyrac committed 2 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 17/Jun/08 09:52 AM
Jerome Mouneyrac committed 2 files to 'Moodle CVS' - 17/Jun/08 10:00 AM
commited and tested in 1.8 Stable, 1.9 Stable and HEAD
Jerome Mouneyrac made changes - 17/Jun/08 10:02 AM
Ralf, thanks for reporting this issue, Valery and Eloy, thanks for your contributions, and Jerome, thanks for fixing it
Helen Foster made changes - 17/Jun/08 04:49 PM
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||