Issue Details (XML | Word | Printable)

Key: MDL-11506
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Francois Marier
Reporter: Chris Bandy
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Table headings do not respect align property: print_table regression

Created: 29/Sep/07 12:20 PM   Updated: 07/Dec/07 01:07 PM
Return to search
Component/s: Accessibility
Affects Version/s: 1.7, 1.7.1, 1.7.2, 1.8, 1.8.1, 1.8.2
Fix Version/s: 1.8.4, 1.9, 2.0

File Attachments: 1. Text File weblib.patch (0.9 kB)
Issue Links:
Relates
 

Participants: Chris Bandy, Francois Marier and Martin Dougiamas
Security Level: None
Resolved date: 07/Dec/07
Affected Branches: MOODLE_17_STABLE, MOODLE_18_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
The styles erroneously removed at line 3455 of weblib.php v1.776 (line 4153 of v1.958) successfully validate.

The typo "sytle" may have caused the mix up.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Chris Bandy added a comment - 29/Sep/07 12:23 PM
Forgot to mention that it validates as XHTML 1.0 Strict

Chris Bandy made changes - 29/Sep/07 12:23 PM
Field Original Value New Value
Link This issue has been marked as being related by MDL-7861 [ MDL-7861 ]
[ Permalink | « Hide ]
Martin Dougiamas added a comment - 01/Oct/07 01:49 PM
I have a fix, just waiting for CVS to work again

Martin Dougiamas made changes - 01/Oct/07 01:49 PM
Fix Version/s 1.8.3 [ 10230 ]
Fix Version/s 1.9 [ 10190 ]
Martin Dougiamas made changes - 11/Oct/07 02:41 PM
Fix Version/s 1.8.4 [ 10242 ]
Fix Version/s 1.8.3 [ 10230 ]
[ Permalink | « Hide ]
Chris Bandy added a comment - 18/Oct/07 04:41 AM
Bump. Still present on line 4258 of weblib.php v1.978

[ Permalink | « Hide ]
Chris Bandy added a comment - 14/Nov/07 05:22 AM
Bump. Still present on line 4291 of weblib.php v1.984

[ Permalink | « Hide ]
Francois Marier added a comment - 07/Dec/07 08:27 AM
Trivial patch which removes the typo and uncomment the original line.

I have tested it and it validates fine.


Francois Marier made changes - 07/Dec/07 08:27 AM
Attachment weblib.patch [ 12572 ]
[ Permalink | « Hide ]
Martin Dougiamas added a comment - 07/Dec/07 12:48 PM
Cool, thanks!

Martin Dougiamas made changes - 07/Dec/07 12:48 PM
Assignee Martin Dougiamas [ dougiamas ] Francois Marier [ francois ]
Francois Marier made changes - 07/Dec/07 01:07 PM
Fix Version/s 2.0 [ 10122 ]
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
fmarier committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 07/Dec/07 01:58 PM
weblib: Fix typo in print_table() which was causing invalid <th> tag
MDL-11506
MODIFY lib/weblib.php   Rev. 1.812.2.91    (+3 -5 lines)
fmarier committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 07/Dec/07 01:59 PM
weblib: Fix typo in print_table() which was causing invalid <th> tag
MDL-11506
MODIFY lib/weblib.php   Rev. 1.970.2.30    (+3 -5 lines)
fmarier committed 1 file to 'Moodle CVS' - 07/Dec/07 02:00 PM
weblib: Fix typo in print_table() which was causing invalid <th> tag
MDL-11506
MODIFY lib/weblib.php   Rev. 1.1000    (+3 -5 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators