Moodle

Write entries mod/data:writeentry <-- should not treat adding, editing and deleting all together

Details

  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

Write entries mod/data:writeentry <-- this setting let us to set permissions for example to students, to allow them to

  • add
  • edit (own)
  • delete (own)
    entries. These features should be treated separatively, in the sense that there should be three separate setting fields:
  • Add entries mod/data:addentry
  • Edit own entries mod/data:editentry
  • Delete own entries mod/data:deleteentry

Attachments

  1. Text File
    mdl-11511.patch
    14/Apr/08 10:35 PM
    6 kB
    Dan Poltawski
  2. Text File
    take2.patch
    14/Apr/08 10:47 PM
    6 kB
    Dan Poltawski

Issue Links

This issue has a non-specific relationship to:
MDL-11533 two more capabilities for databases Major Open
This issue has been marked as being related by:
MDL-17216 Capabilities for the database module are not atomic and ambigous, blocking designing desired module instances Minor Open
MDL-14409 Template tags mismatch as Guest breaks list view Blocker Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dan Poltawski added a comment -

This patch adds capabilities for doing 'own operations' (edit own entry/delete own entry). Intentionally low-impact.

The manageentries capability should probably be split down more too.

Show
Dan Poltawski added a comment - This patch adds capabilities for doing 'own operations' (edit own entry/delete own entry). Intentionally low-impact. The manageentries capability should probably be split down more too.
Hide
Permalink
Petr Škoda (skodak) added a comment - - edited

I like the idea, but did not test the patch: +1
MD will have to confirm creation of new cap if this goes to 1.9.1...

Show
Petr Škoda (skodak) added a comment - - edited I like the idea, but did not test the patch: +1 MD will have to confirm creation of new cap if this goes to 1.9.1...
Hide
Permalink
Dan Poltawski added a comment -

Updated to a slightly less ugly patch..

Show
Dan Poltawski added a comment - Updated to a slightly less ugly patch..
Hide
Permalink
Dan Poltawski added a comment -

Grr, actually logic is questionable in second patch if they have manage entries but now edit own entries perm.

Show
Dan Poltawski added a comment - Grr, actually logic is questionable in second patch if they have manage entries but now edit own entries perm.
Hide
Permalink
Dongsheng Cai added a comment -

add 2 new caps in mod/data

Show
Dongsheng Cai added a comment - add 2 new caps in mod/data
Hide
Permalink
Martin Dougiamas added a comment -

Hmm, think about this a bit. Does it really make sense to offer Add without Edit? They would just add another one. Or Edit without Add? or Add without Delete? These kind of complications were all avoided with a single capability.

Show
Martin Dougiamas added a comment - Hmm, think about this a bit. Does it really make sense to offer Add without Edit? They would just add another one. Or Edit without Add? or Add without Delete? These kind of complications were all avoided with a single capability.
Hide
Permalink
Martin Dougiamas added a comment -

Dongsheng please don't commit these things without some review!

Show
Martin Dougiamas added a comment - Dongsheng please don't commit these things without some review!
Hide
Permalink
Petr Škoda (skodak) added a comment -

Add without Edit - like forum after the edit period (did not study the code yet how that exactly works now)
They would just add another one. - not if there is max entry limit
Or Edit without Add? - you could have the add initially, but remove it later
Add without Delete - I like that

Show
Petr Škoda (skodak) added a comment - Add without Edit - like forum after the edit period (did not study the code yet how that exactly works now) They would just add another one. - not if there is max entry limit Or Edit without Add? - you could have the add initially, but remove it later Add without Delete - I like that
Hide
Permalink
Dan Poltawski added a comment -

Reason for add without edit was so we could override capabilities and [ab?]use the module as a mechanism for students adding suggestions, then a teacher could approve and edit a field periodically.

I guess I could see a similar use with the collaborative glossary example:

  • student adds glossary entry
  • teacher cleans it up and approves it
  • student can't edit it again
Show
Dan Poltawski added a comment - Reason for add without edit was so we could override capabilities and [ab?]use the module as a mechanism for students adding suggestions, then a teacher could approve and edit a field periodically. I guess I could see a similar use with the collaborative glossary example:
  • student adds glossary entry
  • teacher cleans it up and approves it
  • student can't edit it again

People

Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.