Issue Details (XML | Word | Printable)

Key: MDL-11511
Type: Task Task
Status: Reopened Reopened
Priority: Major Major
Assignee: Dan Poltawski
Reporter: Rafa? Nowak
Votes: 2
Watchers: 4
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Write entries mod/data:writeentry <-- should not treat adding, editing and deleting all together

Created: 29/Sep/07 10:54 PM   Updated: 05/Mar/09 07:30 AM
Return to search
Component/s: Database activity module
Affects Version/s: 1.8.2
Fix Version/s: 2.0

File Attachments: 1. Text File mdl-11511.patch (6 kB)
2. Text File take2.patch (6 kB)

Issue Links:
Relates

Participants: Dan Poltawski, Dongsheng Cai, Martin Dougiamas, Petr Skoda and Rafa? Nowak
Security Level: None
Resolved date: 17/Apr/08
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
Write entries mod/data:writeentry <-- this setting let us to set permissions for example to students, to allow them to
* add
* edit (own)
* delete (own)
entries. These features should be treated separatively, in the sense that there should be three separate setting fields:

- Add entries mod/data:addentry
- Edit own entries mod/data:editentry
- Delete own entries mod/data:deleteentry

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Dan Poltawski added a comment - 14/Apr/08 10:35 PM
This patch adds capabilities for doing 'own operations' (edit own entry/delete own entry). Intentionally low-impact.

The manageentries capability should probably be split down more too.


Petr Skoda added a comment - 14/Apr/08 10:40 PM - edited
I like the idea, but did not test the patch: +1
MD will have to confirm creation of new cap if this goes to 1.9.1...

Dan Poltawski added a comment - 14/Apr/08 10:47 PM
Updated to a slightly less ugly patch..

Dan Poltawski added a comment - 14/Apr/08 10:50 PM
Grr, actually logic is questionable in second patch if they have manage entries but now edit own entries perm.

Dongsheng Cai added a comment - 17/Apr/08 01:59 PM
add 2 new caps in mod/data

Martin Dougiamas added a comment - 17/Apr/08 02:57 PM
Hmm, think about this a bit. Does it really make sense to offer Add without Edit? They would just add another one. Or Edit without Add? or Add without Delete? These kind of complications were all avoided with a single capability.

Martin Dougiamas added a comment - 17/Apr/08 02:59 PM
Dongsheng please don't commit these things without some review!

Petr Skoda added a comment - 17/Apr/08 03:48 PM
Add without Edit - like forum after the edit period (did not study the code yet how that exactly works now)
They would just add another one. - not if there is max entry limit
Or Edit without Add? - you could have the add initially, but remove it later
Add without Delete - I like that

Dan Poltawski added a comment - 17/Apr/08 04:08 PM
Reason for add without edit was so we could override capabilities and [ab?]use the module as a mechanism for students adding suggestions, then a teacher could approve and edit a field periodically.

I guess I could see a similar use with the collaborative glossary example:

  • student adds glossary entry
  • teacher cleans it up and approves it
  • student can't edit it again