Overall I think it's good, but it's a major change. I'm a bit worried about regressions ... feels like a 2.0 change to me right now ...

The doublling up under Modules is a bit wierd. How about we just have Activities / Filters / Blocks folders and put a "Manage" item always first under all of them.

I'll keep looking at it.

admin/block.php?adminedit=off&section=blocksettingsearch (turning off block editing) resulted in error: A required parameter (block) was missing

Can you work on it a bit more, perhaps even in a branch?

• supports config_plugin
• improved searching
• first error selected
• form values not reset when error found
• auth page converted - auth plugins not converted yet (needs more work)
• tree reordering (above comment)
• minor bugfixes
• other improvements and speedups

• config_plugin fully supported
• auth modules partially converted
• improved searching
• bug fixing
• error focus
• performance improvements - partial tree loading - no settings for external pages and course page
• added lang strings for blocvks and modules
• more improvements

• rewritten css in admin tree block - no more space;space; span br constructs there
• fixed bunch of incorrect links with hardcoded /admin/
• other minor changes

Frontpage as admin for example:

before
1.2375 secs
Included 124 files
DB queries 107

after:
0.802977 secs
Included 137 files
DB queries 46

• require_once($CFG->dirroot.'/admin/mnet/adminlib.php');
  + require_once("$CFG->wwwroot/$CFG->admin/mnet/adminlib.php");

http://moodle.org/mod/forum/discuss.php?d=88002

We fixed this locally by changing our code for our customized block and renaming settings.php. However, in general, any block that happens to have a file named settings.php will break the admin tree.

We did not report the problem at the time as it appears that the newer version of the attendance block does not have this file. But you may see other reports of this problem because of the use of settings.php for use by the admin block since this patch was made.

In our case, it actually broke access to much of the admin block for administrators, so it was more difficult to track down than one part of the attendance block not being compatible.

I was already planning some new diagnostic code as part of upgrade that show all non-core modules, blocks, filters and other extensions including missing plugins.

Thanks for the info.

I have a patch (that I needed internally) to add support for local/lib.php to add items to the admin menu, it would be aces for you to approve it & I'll commit it:

http://paste.dollyfish.net.nz/8ff286

+ if (file_exists($CFG->dirroot.'/local/localsettings.php')) { + include($CFG->dirroot.'/local/localsettings.php'); + }