Issue Details (XML | Word | Printable)

Key: MDL-11562
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Critical Critical
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-11561

supportname and supportemail are not initialized properly during install

Created: 03/Oct/07 03:52 AM   Updated: 03/Oct/07 06:34 AM
Return to search
Component/s: Administration
Affects Version/s: 1.9
Fix Version/s: 1.9

Participants: Petr Skoda
Security Level: None
Resolved date: 03/Oct/07
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
the trouble is that the defaults are available only after admin user setup

solution is to implement new get_defaultsetting() method in admin_setting class and allow the defaults to be NULL, then add is_null() test before applying the defaults after main table setup, then apply the default again after admin user setup...



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda committed 8 files to 'Moodle CVS' - 03/Oct/07 05:38 AM
MDL-11562 supportname and supportemail are are now initialized after admin user setup
MDL-11566 only site shortname, fullname and desc are required/displayed during installation
MDL-11567 fixed upgradesettings redirects if error in settings
MDL-11143 defaultfrontpageroleid moved to Frontpage settings page (easier to find), speedup
MODIFY lib/adminlib.php   Rev. 1.151    (+27 -9 lines)
MODIFY admin/settings/frontpage.php   Rev. 1.5    (+49 -47 lines)
MODIFY admin/index.php   Rev. 1.284    (+4 -3 lines)
MODIFY user/editadvanced.php   Rev. 1.21    (+4 -1 lines)
MODIFY admin/upgradesettings.php   Rev. 1.20    (+17 -9 lines)
MODIFY admin/settings/top.php   Rev. 1.15    (+3 -1 lines)
MODIFY admin/settings/server.php   Rev. 1.25    (+9 -13 lines)
MODIFY lang/en_utf8/admin.php   Rev. 1.152    (+1 -0 lines)
Petr Skoda added a comment - 03/Oct/07 06:34 AM
should be fixed in cvs

Petr Skoda made changes - 03/Oct/07 06:34 AM
Field Original Value New Value
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
martignoni committed 1 file to 'Lang CVS' - 04/Oct/07 02:37 AM
MDL-11562 supportname and supportemail are are now initialized after admin user setup
MDL-11566 only site shortname, fullname and desc are required/displayed during installation
MDL-11567 fixed upgradesettings redirects if error in settings
MDL-11143 defaultfrontpageroleid moved to Frontpage settings page (easier to find), speedup
MODIFY fr_utf8/admin.php   Rev. 1.193    (+2 -1 lines)