Issue Details (XML | Word | Printable)

Key: MDL-11563
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 0
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-11561

replace hardcoded permission check from admin_tree_block

Created: 03/Oct/07 03:56 AM   Updated: 29/Oct/07 06:37 AM
Return to search
Component/s: Administration
Affects Version/s: 1.9
Fix Version/s: 1.9

Issue Links:
Duplicate
 

Participants: Petr Skoda
Security Level: None
Resolved date: 29/Oct/07
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
it is fast, but it breaks 3rd party extensions, frontpage editting, etc.
solution: add has_capability test to files in admin/settings/; one big simple if (has_capability() or has_capability())
each settings file can decide what to do; the speed should be nearly the same - includes some 10 more file + some has_capability() calls


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda committed 14 files to 'Moodle CVS' - 29/Oct/07 07:35 AM
MDL-11563 replaced hardcoded permission check from admin_tree_block
MODIFY blocks/admin_tree/block_admin_tree.php   Rev. 1.29    (+5 -29 lines)
MODIFY admin/settings/location.php   Rev. 1.5    (+6 -1 lines)
MODIFY admin/settings/appearance.php   Rev. 1.26    (+6 -1 lines)
MODIFY admin/settings/server.php   Rev. 1.27    (+6 -1 lines)
MODIFY admin/settings/security.php   Rev. 1.22    (+4 -1 lines)
MODIFY admin/settings/Attic/misc.php   Rev. 1.15    (+6 -1 lines)
MODIFY admin/settings/top.php   Rev. 1.16    (+2 -1 lines)
MODIFY admin/settings/unsupported.php   Rev. 1.2    (+4 -1 lines)
MODIFY admin/settings/language.php   Rev. 1.8    (+6 -1 lines)
MODIFY admin/settings/mnet.php   Rev. 1.4    (+7 -1 lines)
MODIFY admin/settings/grades.php   Rev. 1.19    (+12 -6 lines)
MODIFY admin/settings/frontpage.php   Rev. 1.9    (+4 -4 lines)
MODIFY admin/settings/courses.php   Rev. 1.15    (+6 -1 lines)
MODIFY admin/settings/users.php   Rev. 1.27    (+3 -3 lines)
Petr Skoda committed 14 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 29/Oct/07 07:36 AM