Moodle

improve perf of admin settings

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9
  • Component/s: Administration
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

1/ we can now override the get_defaultsetting() method and only find out the details when we really need it
== add new subclasses of admin_setting for settings that have expensive defaults

2/ add new subclasses of admin_setting for settings that have expensive options (lists of classes, encodings, etc.)

Activity

Hide
Martin Dougiamas added a comment -

Regarding this, I think we decided instead on a new capability to hide the whole thing.

http://moodle.org/mod/forum/discuss.php?d=79455#p354480 and MDL-11195

The expense of the menu then only applies to a very few people per site (and it's not THAT bad) ...

Show
Martin Dougiamas added a comment - Regarding this, I think we decided instead on a new capability to hide the whole thing. http://moodle.org/mod/forum/discuss.php?d=79455#p354480 and MDL-11195 The expense of the menu then only applies to a very few people per site (and it's not THAT bad) ...
Hide
Martín Langhoff added a comment -

Yep - intending to look at mdl-11195 tomorrow, but happy for if someone else wishes to take it over

Show
Martín Langhoff added a comment - Yep - intending to look at mdl-11195 tomorrow, but happy for if someone else wishes to take it over
Hide
Petr Škoda (skodak) added a comment -

I have added a lazy loading of options into admin_setting_configselect class,
see lib/adminlib.php/admin_setting_grade_profilereport class

we can add new classes for the most expensive ones now

Show
Petr Škoda (skodak) added a comment - I have added a lazy loading of options into admin_setting_configselect class, see lib/adminlib.php/admin_setting_grade_profilereport class we can add new classes for the most expensive ones now
Hide
Petr Škoda (skodak) added a comment -

should be mostly done

Show
Petr Škoda (skodak) added a comment - should be mostly done

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: