Issue Details (XML | Word | Printable)

Key: MDL-11564
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 0
Watchers: 3
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-11561

improve perf of admin settings

Created: 03/Oct/07 03:58 AM   Updated: 01/Dec/07 06:34 AM
Return to search
Component/s: Administration
Affects Version/s: 1.9
Fix Version/s: 1.9

Participants: Martin Dougiamas, Martín Langhoff and Petr Skoda
Security Level: None
Resolved date: 01/Dec/07
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
1/ we can now override the get_defaultsetting() method and only find out the details when we really need it
    == add new subclasses of admin_setting for settings that have expensive defaults

2/ add new subclasses of admin_setting for settings that have expensive options (lists of classes, encodings, etc.)

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Martin Dougiamas added a comment - 03/Oct/07 03:25 PM
Regarding this, I think we decided instead on a new capability to hide the whole thing.

http://moodle.org/mod/forum/discuss.php?d=79455#p354480 and MDL-11195

The expense of the menu then only applies to a very few people per site (and it's not THAT bad) ...


Martín Langhoff added a comment - 03/Oct/07 05:40 PM
Yep - intending to look at mdl-11195 tomorrow, but happy for if someone else wishes to take it over

Petr Skoda added a comment - 29/Oct/07 06:40 AM
I have added a lazy loading of options into admin_setting_configselect class,
see lib/adminlib.php/admin_setting_grade_profilereport class

we can add new classes for the most expensive ones now


Petr Skoda added a comment - 01/Dec/07 06:34 AM
should be mostly done