Moodle

Grade-item ordering no longer reflected on grader report

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9
  • Component/s: Gradebook
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

The attached screenshots show some problems with ordering .... I'm sure this used to work, there seems to be a regression, perhaps introduced with the fixes to user report?

Attachments

  1. screenshot-1.jpg
    101 kB
    04/Oct/07 12:02 AM
  2. screenshot-2.jpg
    130 kB
    04/Oct/07 12:03 AM
  3. screenshot-3.jpg
    159 kB
    04/Oct/07 12:03 AM

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

I can not reproduce it, I would need to see the db (sortorder field) to find the source of the problem
I have also reviewed the code, I can not see any reason why it should be failing to sort it properly

Show
Petr Škoda (skodak) added a comment - I can not reproduce it, I would need to see the db (sortorder field) to find the source of the problem I have also reviewed the code, I can not see any reason why it should be failing to sort it properly
Hide
Permalink
Martin Dougiamas added a comment -

On http://test.moodle.com/grade/report/grader/index.php?id=2 (messy demo site, needs rebuilding) the categories seem to be OK but look at the ordering of the items within the first category for example.

Show
Martin Dougiamas added a comment - On http://test.moodle.com/grade/report/grader/index.php?id=2 (messy demo site, needs rebuilding) the categories seem to be OK but look at the ordering of the items within the first category for example.
Hide
Permalink
Martin Dougiamas added a comment -

Here's a much cleaner example in a course I built up from scratch:

http://test.moodle.com/grade/report/grader/index.php?id=4

The ordering was in fact FINE when I first created the activities, and stayed fine when I added the categories.

It changed to the current wrong ordering after I created some groups. It doesn't sound related but ...

Show
Martin Dougiamas added a comment - Here's a much cleaner example in a course I built up from scratch: http://test.moodle.com/grade/report/grader/index.php?id=4 The ordering was in fact FINE when I first created the activities, and stayed fine when I added the categories. It changed to the current wrong ordering after I created some groups. It doesn't sound related but ...
Hide
Permalink
Martin Dougiamas added a comment -

Aha:

Order is correct when [-] is showing (ie category total included).

Order is incorrect when [o] is showing (ie category total not included)

Show
Martin Dougiamas added a comment - Aha: Order is correct when [-] is showing (ie category total included). Order is incorrect when [o] is showing (ie category total not included)
Hide
Permalink
Petr Škoda (skodak) added a comment -

AAAh, I see - it will be easy to fix!

Show
Petr Škoda (skodak) added a comment - AAAh, I see - it will be easy to fix!
Hide
Permalink
Petr Škoda (skodak) added a comment -

should be fixed in cvs, thats for the steps to replicate the problem,
I made a mistake and was trying to switch the placement of categoryitem even when it was not there...

Show
Petr Škoda (skodak) added a comment - should be fixed in cvs, thats for the steps to replicate the problem, I made a mistake and was trying to switch the placement of categoryitem even when it was not there...
Hide
Permalink
Martin Dougiamas added a comment -

Confirmed, this works correctly for me now - thanks, Petr.

Show
Martin Dougiamas added a comment - Confirmed, this works correctly for me now - thanks, Petr.
Hide
Permalink
Philip Butcher added a comment -

Almost but not quite. The Course total used to respect the aggregation position, and in my setting appear on the right, but as of today it has started appearing on the left, irrespective of the aggregation position setting. The Category totals do appear in the correct position.

Show
Philip Butcher added a comment - Almost but not quite. The Course total used to respect the aggregation position, and in my setting appear on the right, but as of today it has started appearing on the left, irrespective of the aggregation position setting. The Category totals do appear in the correct position.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.