|
Hi I agree about 0 not being the best solution. But I really think it isn't easy to guess one perfect timeout (mainly because different cron executions can have different parts executed - clean-up tasks, backup...)
So I would propose to: 1) NOW, and for 1.7, 1.8 and HEAD, reset time_limit to 0 inside the module loop. And I'm going to implement 1) now. Mainly because current behaviour is, IMO, worse than having 0 (for big sites it causes big problems). Let's do better than 0 later. Oki? We need cron running completely to be able to continue testing the whole cron execution. Thanks and ciao Committed to HEAD. Going to perform some tests before backporting to 1.7 and 1.8...
Also to HEAD, I've added the same reset of time_limit=0 to blocks cron.
thanks Eloy, it is funny we often have the same ideas how to solve problems
thanks Backported to both 17_STABLE and 18_STABLE.
I think this can be causing real problem to a bunch of sites (with some important tasks like users/logs/cache maintenance never being executed). So, I would review 17_STABLE and 18_STABLE status and release 1.7.3 and 1.8.3 ASAP. +1 for that. I continue reviewing cron... one note from HQ chat that, perhaps should become a new bug in the tracker, for your consideration: "I think we could detect unfinished cron and mail admins. Yep should introduce some "inteligence" to the cron, like scheduled backups, both preventing multiple executions and informing admin if something is unfinished. yep. (agree). oki. 100%" I guess this can be marked resolved now.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
I guess it was me who added the short timeout there because we had some trouble with forum mailing at that time, hmmm