Issue Details (XML | Word | Printable)

Key: MDL-11599
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Petr Skoda
Reporter: Nicolas Connault
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Grader report's range row produces errors when set to inherit, and when some grade_items are Letter

Created: 04/Oct/07 11:17 PM   Updated: 05/Oct/07 01:09 AM
Return to search
Component/s: Gradebook
Affects Version/s: 1.9
Fix Version/s: 1.9

Participants: Nicolas Connault and Petr Skoda
Security Level: None
Resolved date: 05/Oct/07
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
To reproduce:

1. Setup 2 grade items in a course
2. Set the site settings grade_report_averagesdisplaytype and grade_report_rangesdisplaytype to Inherit
3. Set the course's preferences averagesdisplaytype and rangesdisplaytype to default(inherit)
4. Set one of the grade item's display settings to Letter, the other to Percentage

I get this:

( ! ) Warning: end() [function.end]: Passed variable is not an array or object in D:\VertrigoServ\www\moodle_head\grade\report\grader\lib.php on line 1001
Call Stack
# Time Memory Function Location
1 0.0234 128608 {main}( ) ..(null):0
2 1.8421 16314368 grade_report_grader->get_rangehtml( ) ..(null):162
3 1.8714 16316080 end ( ) ..(null):1001

( ! ) Warning: reset() [function.reset]: Passed variable is not an array or object in D:\VertrigoServ\www\moodle_head\grade\report\grader\lib.php on line 1002
Call Stack
# Time Memory Function Location
1 0.0234 128608 {main}( ) ..(null):0
2 1.8421 16314368 grade_report_grader->get_rangehtml( ) ..(null):162
3 1.8716 16316312 reset ( ) ..(null):1002

Which is caused by a contextid for the item with Letter displaytype which doesn't have a match in the grade_letters table. I'm not sure what's supposed to happen here.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Nicolas Connault added a comment - 04/Oct/07 11:33 PM
Actually, the issue isn't inherit, it's LETTER in general.

If the ranges row is set to LETTER display type, errors occur and nothing gets shown. Other values (REAL or PERCENTAGE) work fine.


Petr Skoda made changes - 05/Oct/07 01:00 AM
Field Original Value New Value
Status Open [ 1 ] In Progress [ 3 ]
Petr Skoda committed 1 file to 'Moodle CVS' - 05/Oct/07 01:09 AM
MDL-11599 missing return statement
MODIFY grade/report/lib.php   Rev. 1.28    (+2 -2 lines)
Petr Skoda added a comment - 05/Oct/07 01:09 AM
grrr, missing return statement, fixed - sorry...

Petr Skoda made changes - 05/Oct/07 01:09 AM
Status In Progress [ 3 ] Resolved [ 5 ]
Fix Version/s 1.9 [ 10190 ]
Resolution Fixed [ 1 ]