Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 1.7.2, 1.8.2, 1.9
-
Component/s: Other
-
Labels:None
-
Affected Branches:MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
-
Fixed Branches:MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
Description
There are multiple issues with Moodle files containing empty or blank lines[1] and/or white space before or after the PHP open and close tags, notably with config.php and theme files. ([1] Lines consisting of only white spaces or tabs.)
So I've decided to search them all and request the developers to nuke them smile. As there are tons of files, I've come up with the following find + Perl one-liner that does all the dirty job automagicaly (run it at the top of your CVS working copy directory):
find . -type f -exec perl -e '$/ = undef; $_ = <>; print $ARGV . "\n" if ((m#^([ t\n])<?php#si) or (m#?>\n([ \t\n])$#s) or (m#?>([ \t]+)$#s))' {} ";"
It prints the paths of the offending files. As of today, there are 35 files having this 'problem'.
If there is no objection to this, I can do it myself, but I'd want to get '+1' from some core developers first.
Saludos. Iñaki.
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Has been reported here: http://phplens.com/lens/lensforum/msgs.php?id=16991
+1 too (if we modify our adodb don't forget to add that to the readme_moodle.txt file to be able to track local modifications).
Ciao 
Fixed in CVS and modified lib/adodb/readme_moodle.txt as per Eloy's request
Saludos. Iñaki.
Saludos. Iñaki. Hehe, only one small "but":
Just noticed that you've applied the change to other branches but, have you moved the MOODLE_17_MERGED and MOODLE_18_MERGED floating tags?
I guess no:
- http://docs.moodle.org/en/Development:Unmerged_files#MOODLE_17_-_MDL-11632
- http://docs.moodle.org/en/Development:Unmerged_files#MOODLE_18_-_MDL-11632
(I've kept them separated from the official list)
Ciao
- http://docs.moodle.org/en/Development:Unmerged_files#MOODLE_17_-_MDL-11632
- http://docs.moodle.org/en/Development:Unmerged_files#MOODLE_18_-_MDL-11632
Yeah, Eloy. I haven't forgot to update the tags. But switching branchs in CVS (at least with Sourceforge's CVS) is sooooooo painfully slow (it takes 20-30 minutes from home, where I do these things) and it was late at night. So I decided to leave it for today. I'm doing it right now
Having used git for several months where switching Moodle branches takes 1-2 seconds, the CVS switching time feels like an eternity to me.
Saludos. Iñaki.
Having used git for several months where switching Moodle branches takes 1-2 seconds, the CVS switching time feels like an eternity to me.
Saludos. Iñaki. 
Adding some developers to request their opinion.
Saludos. Iñaki.